From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-71342-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 11664 invoked by alias); 22 Apr 2011 08:24:11 -0000
Received: (qmail 11652 invoked by uid 22791); 22 Apr 2011 08:24:11 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Apr 2011 08:23:45 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D46F6CB0352;	Fri, 22 Apr 2011 10:23:44 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id x6d8i9WDlFXT; Fri, 22 Apr 2011 10:23:41 +0200 (CEST)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id B0E4ACB023D;	Fri, 22 Apr 2011 10:23:41 +0200 (CEST)
Subject: Re: [patch] Convert coff64-rs6000.c to iso-c
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <m2r58uog0t.fsf@igel.home>
Date: Fri, 22 Apr 2011 08:24:00 -0000
Cc: binutils <binutils@sourceware.org>, Nick Clifton <nickc@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <910A4793-5695-44D9-9983-8C489776B919@adacore.com>
References: <49F283B4-757D-4BFF-9FCB-94097A486783@adacore.com> <4DAC3D3A.7090106@redhat.com> <Pine.LNX.4.64.1104211016590.9614@digraph.polyomino.org.uk> <4DB03A7B.4090002@redhat.com> <7D113C3D-4663-40D1-97CA-972703D8C55E@adacore.com> <m2r58uog0t.fsf@igel.home>
To: Andreas Schwab <schwab@linux-m68k.org>
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00323.txt.bz2


On Apr 22, 2011, at 10:18 AM, Andreas Schwab wrote:

> Tristan Gingold <gingold@adacore.com> writes:
>=20
>> As discussed...
>>=20
>> Sanity checked by building for powerpc64-ibm-aix6.
>>=20
>> Ok for trunk ?
>>=20
>> Tristan.
>>=20
>> bfd/
>> 2011-04-22  Tristan Gingold  <gingold@adacore.com>
>>=20
>> 	* coff64-rs6000.c: Convert to ISO-C.  Remove PARAMS and PTR macros.
>=20
> I guess quite a few declaration can be removed since the definitions are
> now providing the prototypes, and a few more by moving the include of
> "coffcode.h" after the definitions it uses.

That's asking for more work than initially planned, and also asking for mor=
e checking.

Can we do that incrementally: first the obvious conversion, then the small =
reorg ?

Tristan.