From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id D415F3858CDA for ; Tue, 2 Jul 2024 06:25:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D415F3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D415F3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719901545; cv=none; b=iacTcQQohjTjJ2peHvOJHxy3YpK8q3+T+8OmRyfdIYlfgBSNLKENbOojXxRsLcPrfHjO5QoW5eLNDKJFROu1i0B3+tlS+T95DvpLBMJiy1uJ1+T7l8lGu2eAn/J2R0SQl8qZLBMXsSnLkj5b0cP89tF5//iTNynZ2rXsvcg4amU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719901545; c=relaxed/simple; bh=O8hcuG+bo2mUd21BFTMuXGPgF2ivUzZOa5eYpQN6eFQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=W4voiEcL8oYqTwDDv1RPUECV2b3Ou7qg/15NGhLI2dnbu2JTUw3T/THkgGvxRuoH/wixNtIqT8l+4gOLoQ/GDrN+xx8sQ4ZrZZnGSD/Vgnd+tTzBI+DBMyZRMRgOqa8Xh6XlVsHd8fLb/MnR9+CTOoOIHnY9tK9Tb7Le3sWVAcQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ec50a5e230so38164501fa.0 for ; Mon, 01 Jul 2024 23:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719901542; x=1720506342; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=KYQqPfAqx7XALUdqGavie5o/a37BwH0DxT+zdTXCjp4=; b=EjzoKGeTFBVZkXnXwf6MsH0xaHFs4quWxZqdWaAiyooDg7D6b5s7PH9/vonkLxgsOG xuONLsccTZvzRNm/con5W7eASmbwPQNfwus4tvYE9xcziqskOjVIpSw+4Ru/rI9nYW4/ i7Z0bXNMQPH3/h1GncJqLQKI8FfBTiYBdinz+Quc2lFfYpbMtTXp3C+deiVV2fdpNYiS 7RZmVu6yFg/9DFDaWnvT+LEyXrJ2nImF7xgua4KBzfS/CYFQoRPttbE1ymIPOz6r/5JH TXih86npUeAiMbW5xZziHVVomanYj0I+pgq1zWnTh1Xux5WlIlVKjkHdHgVc1W/5t0E/ mOmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719901542; x=1720506342; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KYQqPfAqx7XALUdqGavie5o/a37BwH0DxT+zdTXCjp4=; b=LM7F0tyNtR/ymqimVNXC01y8Kc19fnP+8q9MNwR4aRURqv1eYVjcbQ0OAawMcPjiD2 b3xLKn+eLBChSDqYsGl2h3tmj9/5cat0huo8mF+dDoZmPrE7sgj1z2icDVWwRa+US8Ob x86UkrUf6YMSnqnYXpC0Yt5YjYsW+FNlXxegSM0jWsFXZFjgGsUxD5S9sWsM0VN9bMAV V7E04QNmR00r5nF/5Q5/86v3HnNtCCL9tRFiBXQ60SJF7tt/pGjXGQuXXteilNs65A5P kXOPcDD8ipYcttbr1zVf5dYQpAw+YgdebFd+8yAQ39tc0ktBrL1Kz+8cLisEQCd352hM h68A== X-Forwarded-Encrypted: i=1; AJvYcCUQTu46jv45PvFpAV0h58E2sOCjZFmtcQCWtQ26ONjc1G4hjx+cmmU9m4poOnpRyuRic2wSD78OqHqfy3tzcvTrc2F9R4Vkow== X-Gm-Message-State: AOJu0Yy+XC0GXXuq/1MCDJ0IvEyrKAVyjl20AfzPe5J/gCcZ744kV2YN AFnNEdbVS8gcBN2+pRQhJxwNfdIhEXiCAClJkGnxBkVqRvrwKCyiWlun4frCKA== X-Google-Smtp-Source: AGHT+IG2aiKExPkHP73UFUUMAPKpCfOIfzbCobSStQhxow5/VVaofjGJCdfMWUYhQilSYJM0mHosQA== X-Received: by 2002:a2e:9a13:0:b0:2ec:50ed:b59f with SMTP id 38308e7fff4ca-2ee5e6bc27cmr68499791fa.34.1719901541193; Mon, 01 Jul 2024 23:25:41 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fb015f00f1sm2604035ad.82.2024.07.01.23.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 23:25:40 -0700 (PDT) Message-ID: <918ab67b-1d82-4893-b8d0-dd620b846e41@suse.com> Date: Tue, 2 Jul 2024 08:25:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: hash with segment id and pcrel_hi address while recording pcrel_hi To: lifang_xia Cc: Nelson Chu , binutils@sourceware.org, Alan Modra , Nick Clifton References: <20240621012445.91320-1-lifang_xia@linux.alibaba.com> <2E2DC05E-8CF4-4CFA-8D69-CFC04B20965A@linux.alibaba.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2E2DC05E-8CF4-4CFA-8D69-CFC04B20965A@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02.07.2024 05:20, lifang_xia wrote: >> 2024年6月25日 16:25，Jan Beulich 写道： >> I don't really understand, though, why htab_hash_pointer() wants / needs >> using here. Wouldn't (deriving from what was there before) >> "e->address + 59 * e->seg->id" suffice (multiplier subject to possible >> improvement), and be less of a behavioral change? > "e->address + 59 * e->seg->id” would be fine. It's just necessary > to ensure uniqueness within a finite range. > As for the multiplier, do you have any suggestions? I feel that 59 might be > too small. Is 127 a better choice? Why would you think the absolute value matters much? As to 127, I'd view this as sub-optimal, for being 2^^7-1 (i.e. a little too "regular"). But surely you should be fine picking whatever larger prime you like. Jan