From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 7BBA0385841A for ; Fri, 30 Jun 2023 20:45:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BBA0385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1b7fb02edfaso17348195ad.3 for ; Fri, 30 Jun 2023 13:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688157901; x=1690749901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dX7CcU7CaM/q9gJQDPxbqnCF+bQD6EfOV2dbkllM7kc=; b=VLWoJZfkQUK95+YrAc6xQK/SU0AomzWYvGZk6xwmfaPzRey+xtaHvQncJ01jTx7i1R qgvj1ZYygYLBNL+mB/UXwekt2rs7io6O8I2jf+/HKkVIQf2kWgg9VAeddvTXLGSoL2B8 6ZhlzGXw5rhQ26FQvNMo6YrgKWb4+dXTIgyY1rhKAjWVqIVE3ucTYeaSwOGlAC8c8smx oyAnro6rMvSHwKyY/FVHzWhbocmFs5y3SFda5C2dVLgOQN/HffNc7aNdNGT9561cy9Fa SKAt6C+slvuDUQ3fjy31dW3qdM320G0+iRNnaeF/3LJ3QQmddiZTF5Vk8Nm8cGPaei7g 0L6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688157901; x=1690749901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dX7CcU7CaM/q9gJQDPxbqnCF+bQD6EfOV2dbkllM7kc=; b=ZeBHYBkUHF/hhb6nD5HOQyVIuQtLMMToCoXZQb3OsMd+rhXmLUGNWtsMX3nwVcYRuc DW+gtY6hdrQFB0wzgaeQdxQ46Uz7oG1V7mG2jVx+ybf60X4XG615LEjx1fMptS0E4AcO dQFG59zqMsrejoc5xwRCX5LupJhpcGYF1ObkGWnE4AESXjAx2uX2SSbsoAtlMZxXl8T0 sz7vXcI7ksOwLePGWHTuoUbp9psfezv7UYsUEUz3EMPB+yhwVO1k+C4i3SkiptopJj3v 1oDH3OFTQbHi+nXK+juXoRB1ThA3OFB4rVbBzKoOB1gXW6Y9Bof7nJ4D6KLtvwqcJiU+ vOCQ== X-Gm-Message-State: ABy/qLbakrjPKAclZblqqESUuSTPWsoW9l6hcqZO2mY0P7eFR+5Y7Xz9 HJZmHcsby53SxvSp31wKRXA06k/TypA= X-Google-Smtp-Source: APBJJlEzxLLqvvis9PH2PsIj+tA7/qxfyi5PDdiqo7taAh1r9SxEvpkv2UbFZ2lkxzDQcwxNLI+X3A== X-Received: by 2002:a17:902:a9c2:b0:1b8:7c59:7d0a with SMTP id b2-20020a170902a9c200b001b87c597d0amr1140291plr.28.1688157901371; Fri, 30 Jun 2023 13:45:01 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id iz5-20020a170902ef8500b001b01547d0e8sm6407016plb.142.2023.06.30.13.45.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 13:45:00 -0700 (PDT) Message-ID: <91af0cee-baf3-fea1-9364-db269a232051@gmail.com> Date: Fri, 30 Jun 2023 14:44:59 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 09/14] Allow nested implications for extensions. Content-Language: en-US To: Nathan Huckleberry , binutils@sourceware.org Cc: nhuck@pmull.org References: <20230629171839.573187-1-nhuck@google.com> <20230629171839.573187-10-nhuck@google.com> From: Jeff Law In-Reply-To: <20230629171839.573187-10-nhuck@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: > Certain extensions require two levels of implications. For example, > zvkng implies zvkn and zvkn implies zvkned. Enabling zvkng should also > enable zvkned. > > This patch fixes this behavior. > > Signed-off-by: Nathan Huckleberry > --- > bfd/elfxx-riscv.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) No problem with the actual code. I would suggest a comment explicitly stating this only allows two levels rather than arbitrary levels of nesting. As with the others, it needs ChangeLog and NEWS entries. With those changes it'll be fine for the trunk. Thanks, jeff