From: Shaokun Zhang <zhangshaokun@hisilicon.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Jingtao Cai <caijingtao@huawei.com>, Bo Dong <dongbo4@huawei.com>,
<binutils@sourceware.org>
Subject: Re: [PATCH RESEND v2] Aarch64: Allow explicit size specifier for predicate operand of {sq, uq, }{incp, decp}
Date: Thu, 10 Mar 2022 17:38:53 +0800 [thread overview]
Message-ID: <91de3faa-b7b5-07ae-37ef-0eb996bc340a@hisilicon.com> (raw)
In-Reply-To: <d4e11858-f9ca-d908-b154-ea1aea7c7d01@hisilicon.com>
Hi Jan,
On 2022/3/2 15:36, Shaokun Zhang wrote:
> Hi Jan,
>
> On 2022/2/21 21:13, Jan Beulich wrote:
>> On 16.02.2022 01:53, Shaokun Zhang wrote:
>>> --- a/gas/testsuite/gas/aarch64/sve-movprfx_23.d
>>> +++ b/gas/testsuite/gas/aarch64/sve-movprfx_23.d
>>> @@ -9,29 +9,29 @@ Disassembly of section .*:
>>>
>>> 0+ <.*>:
>>> [^:]+: 04512461 movprfx z1.h, p1/m, z3.h
>>> -[^:]+: 256c8021 incp z1.h, p1 // note: merging predicate expected due to preceding `movprfx' at operand 2
>>> +[^:]+: 256c8021 incp z1.h, p1.h // note: merging predicate expected due to preceding `movprfx' at operand 2
>>
>> I have a more general question here: Couldn't the spec make optional the
>> use of all the same size specifiers when there are multiple, same element
>> size operands? One such suffix of course needs to be there to disambiguate
>
> We are not from ARM SPEC group and don't know the exact considerations for
> the forbidden omitting suffix. We guess people will have different answers from
> different points of view.
>
>From our point of view, a suffix makes the assembly more consistent with the
> scalar versions of `incp`, e.g. `incp x1, p2.b`. And the predicate register acts more
> like a vector register within this instruction, with suffix, the addend for each element
> is clear once reading the assembly string.
>
> Not sure that anyone from ARM in the mail-list can give more hints or thoughts.
>
No any more comments from Arm guys.
Is it ok for trunk?
Thanks,
Shaokun
> Cheers,
>
>
>> different element size forms of the same insn, but the redundancy merely
>> adds clutter imo.
>>
>> Jan
>>
>> .
>>
next prev parent reply other threads:[~2022-03-10 9:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 0:53 Shaokun Zhang
2022-02-21 13:13 ` Jan Beulich
2022-03-02 7:36 ` Shaokun Zhang
2022-03-10 9:38 ` Shaokun Zhang [this message]
2022-03-10 10:38 ` Jan Beulich
2022-03-10 11:33 ` Shaokun Zhang
2022-03-10 11:50 ` Jan Beulich
2022-03-10 12:24 ` Shaokun Zhang
2022-03-10 12:27 ` Shaokun Zhang
2022-09-12 8:17 ` Richard Sandiford
2022-09-12 8:27 ` Jan Beulich
2022-09-12 9:38 ` Richard Sandiford
2022-09-28 2:19 ` dongbo (E)
2022-09-30 14:54 ` Richard Sandiford
2022-10-09 1:31 ` dongbo (E)
2022-10-10 10:25 ` Richard Sandiford
2022-10-11 2:19 ` dongbo (E)
2022-10-17 9:33 ` Richard Sandiford
2022-10-18 5:57 ` dongbo (E)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91de3faa-b7b5-07ae-37ef-0eb996bc340a@hisilicon.com \
--to=zhangshaokun@hisilicon.com \
--cc=binutils@sourceware.org \
--cc=caijingtao@huawei.com \
--cc=dongbo4@huawei.com \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).