From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 4A08A385C413 for ; Thu, 7 Dec 2023 09:11:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A08A385C413 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A08A385C413 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701940283; cv=none; b=VdL7K5J7/OgnubRsmkYGdqZ6Sg+hvrYXTUgTgk38KSIRhMWOi1DD892Cb0AZPQ6fOVI4IFHE6S6QkaCFdR2zd0ayjeCQ6tQtw5y4/Y9cruR13xs7YA7xxfIemYE1Bfe7EhTA/FO+oh+20+Bg716FIrkE3irUwFhovSPRo8QoFdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701940283; c=relaxed/simple; bh=Lm5PyuyU3a2n2Jo3M7gLMhkD1Hx/tTJURalSR4gFwt4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GqEI7RanVvhyxKLPO+MOa5XaKsQNZcE2NwOMhMOZI2DSotRystcyqXALaNe4l7OZUj+/bHJ+BgsVMi1KVLoB08WJSY0AuvGkw/a5boAbAF9FqRUi49t+3O6d4ihjf+LgIQM99eicKnPisl36bF/gfTPm8Mg5CSN8gPk1gSzUdn8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-333630e9e43so691304f8f.2 for ; Thu, 07 Dec 2023 01:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1701940274; x=1702545074; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5RBiKSNF59klL+WJOkek6KissOxBESeBTOzxCjewjHc=; b=IonLfQI7JY5RIPCBU6BJQbmD+15IsGHLXxFzJd3CfRm7B9h7kj5DuwXxKwEhhCJd22 Stfx3I0EKxuUXgL52yyspoi8Di8EgD50gQmagGCBng5Yg00CEyJ+9gD+u7JO9uHaaWG0 fm1uo4lASmtjG2am+LN8WeT+7Blma1HD906/4yiLZ6roMOAGQZlb/gG7qb1XRXBt0+4D /5+tl8I3VaBtHAGz0leLp60WkniZvONE7GlzuEiCk1kVYM59seL/lvnuXsPLZJBGLutQ BPqaDZvhOGLm7iFcMQK3Z+T88rd0chj4Sj/ISHUVNT1MDmquemClWXuyIJDHNu79Xx54 twHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701940274; x=1702545074; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5RBiKSNF59klL+WJOkek6KissOxBESeBTOzxCjewjHc=; b=bSrj5/B0J0uWZT1+w3LgB4WID3r3uByQZ6df5rV1tOa/0hcaE87rA90coH01KNmuSJ SCCA4sr7ySuI7p2fyVvdJpHyLKGuh6+STgA3XBuhoI4qRQSST3p1/sa5axn4RwxY5dhq UyB10c5FH68A32wM6oIpj7U/5wugFZoB42m8owz9YV3E0HQmQNYzOefvEdnSAF74+ywE zVp8lN8d9efZjDmIe4+cnYgmmEgkakxlbxBECLNCw/tXCrVT6+cv59Df3bwpSVBltxnv bZYnvNFkn2ZtpaehXIK4qttCjiTcBhQ7m8rGJsJR+UevuL4PNNdhR3Lf2mLnnmvrzaIo 82VA== X-Gm-Message-State: AOJu0YzmnUMH6EoVtZXOtPk5j/4c5chjSopK6NPVrU6GytpjYgnUs0fh NNxm/+GOtsQQBLDiRYskP381HXcb+My/E/C/RkAy X-Google-Smtp-Source: AGHT+IEgVNirpG2r+olXZQklmg9k3SGcRhBfiRKk2mC2a8gCsQWSZmnZs/5YM6Cpgsg7p4zErpZQpw== X-Received: by 2002:a05:600c:3548:b0:40b:5e1e:fb96 with SMTP id i8-20020a05600c354800b0040b5e1efb96mr994946wmq.75.1701940273988; Thu, 07 Dec 2023 01:11:13 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id h8-20020a05600c350800b0040c03c3289bsm1192028wmq.37.2023.12.07.01.11.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Dec 2023 01:11:13 -0800 (PST) Message-ID: <91e88561-b8e5-453e-a4ec-1640cc37c240@suse.com> Date: Thu, 7 Dec 2023 10:11:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Support APX PUSHP/POPP Content-Language: en-US To: "Cui, Lili" Cc: binutils@sourceware.org, hongjiu.lu@intel.com References: <20231207085610.2901080-1-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231207085610.2901080-1-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07.12.2023 09:56, Cui, Lili wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -3894,7 +3894,8 @@ is_apx_evex_encoding (void) > static INLINE bool > is_apx_rex2_encoding (void) > { > - return i.rex2 || i.rex2_encoding; > + return i.rex2 || i.rex2_encoding > + || i.tm.opcode_modifier.operandconstraint == REX2_REQUIRED; Nit: Odd indentation. > @@ -10621,6 +10624,19 @@ putop (instr_info *ins, const char *in_template, int sizeflag) > case 'P': > if (l == 0) > { > + if (!cond && ins->last_rex2_prefix >= 0 && (ins->rex & REX_W)) > + { > + /* For pushp and popp, p is printed and do not print {rex2} > + for them. */ > + *ins->obufp++ = 'p'; > + ins->rex2 |= REX2_SPECIAL; Apart from the two minor cosmetic remarks (one above, one below) the dealing with unused REX2 bits is the main thing needing resolution. H.J., awaiting your input on that matter. The other remark I have to make: Sending individual patches out of context is certainly irritating, at least to me. In this submission you don't even mention any of the dependencies. Yet this also extends to you sending new versions of individual patches of the earlier 9-patch series. I understand you're eager to make progress, but please also consider the recipients' perspective. > + break; > + } > + > + /* If "!p" prints nothing in intel_syntax. */ > + if (!cond && ins->intel_syntax) > + break; I'm afraid I can't make sense of the comment here. What is it that you're trying to express? Jan