From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) by sourceware.org (Postfix) with ESMTPS id 2931F3858D3C for ; Fri, 7 Oct 2022 13:03:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2931F3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOrpyIg7rArv44/2fE60piApwpelhPo/R+4k9UBnpLAoyZbp33A8nfDFVisLWOsBodfTfWKp5FRWz41i8iBwxpHoqwyaV2AfhXp1nEJY0xNmAPKXxHRmokqcViYC9Z8EDVrZWh27en+IqgI4VCkmI17dHI5yoEBB4EtuX/e3NTccJze91SQ976R4xnI7tIubEtv/gUQI84+EiH1PplSqrZZQ336OMEQ8NONNAZJD9rGMU9iqDzkOlKjVwbuMk6HqyHIqUCnS4iozRKmckfifCwqb0DPo2mhheO0G9K3LuVYfPQIFw6ZbHccvNu9UktiyQsXC1MPzCdEQhKJTCDcvRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xwpQagAEuIdEe/X0bcGeCCAAkXbqGRYSvpzs3+PdIf0=; b=SqaCDPd4DQfK2o6QBtQkcxQJ7tLpm7V+rqxGguqtNrwFZc5Ar+HDxwtJo15z2Mv4j4qY3s8s8leTCzjVfWYyOc53Uu8WYVcRuztlosvcGg776Cu2i8c8wQAi0fhLK00Z5BW8WiFDO93wJ2MJpX/fTNSRJ42MwKDB/1UQpWih9N+TdiWgTvcHtaMOHlHLAAeOQJCfTFSmvMrdyPv4F1+5uuVMu1luHN+5ujal81L8KG0Fc/g+aHuo9uN++dz06kYWjRK6m18jnPyxXgGDFt9pqJhOUG3mkAtIR+UjXd33kxVRNM83WnV+ZiePmLdasCWVnl4ah8k6NbMcN5Yr0+0P8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwpQagAEuIdEe/X0bcGeCCAAkXbqGRYSvpzs3+PdIf0=; b=xVt/2bkcPFI43wxCkxYblhrQsb8RFsdEGhpnLxmTatpKCEFtnr8W/wm6Te1YT53rPdVRPioDYR8N07c1X9PCSzW5qFVOvGdmXRYeKDlREKKlW92uEf/vNBjhOf15d4jS+QNDctvmxcHX4MJNlLScCKfCp9u7k9WOPg2CaNd+7Va4QUoXa1YkxFQDXpWMLMo6Ti4HVj/cDdCqd6apoF21FD7mHPRZGGq5eJGasBn+4IG2QDE3ofcleYikfV3TOUZ7IV2tj5r4NwIcXraTGYwV0v5iodu4iU2fJgSspItcBZineXirit8i70245U/gpo3rc+u0Klsj8QopinR4dr64NA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8378.eurprd04.prod.outlook.com (2603:10a6:10:25f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Fri, 7 Oct 2022 13:03:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Fri, 7 Oct 2022 13:03:08 +0000 Message-ID: <91ef1832-d8fe-9737-a9a0-85fb66f6eb4b@suse.com> Date: Fri, 7 Oct 2022 15:03:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v3 3/7] x86: re-work insn/suffix recognition Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20e2773a-2e47-869b-1900-709f8ad4cd6b@suse.com> <9f97da22-8125-ed4e-6def-ef14ca170b51@suse.com> <2c52318b-c398-9f3a-ccbe-135caa6b3e2d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8378:EE_ X-MS-Office365-Filtering-Correlation-Id: d57ecdb2-18a1-4c68-c928-08daa86447b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1gEoJQLzoRYuq4qi1k0f1j/YbKf1vUXQmvjqOZeP1c5PgWBNP6xBIePh77RqTOEjNMTHwc0O9E22aumRUpc078vWN2UywJfNP9CF65nqTOFSMgOBXxWv4rwHWw/hULLNbzMa4uKrxF9dl69K2mRDLl6t6MJnnR8+KIaAto+m8x5eN48HBrqboyvQtXA2lHE4o1+q9rHsLK2DgFXhqjX1rvFr8lEcZjk/Dm+pFJeLkrNlx59cNTwnwgi/knp337DrbYdidfJ6lZBtMXIVJbffCtW54EJEva0ZYWmaFiKH2AtyFItjx6aws9hhdtTSrnLevSYmYegAMJkkK1DV5bBRFYPVLwtwhTrB85fDVdteNnp2BgQXOrJYqXJxFJYBVHdt5d3GUZF2rr/OBzWa80C4XRtvI8BiRD60iFxTtna2VjBbi/KF3BSURZ08bZFQpBbE4cE8hGzHV9MmCmSvwAm2bYFaRIgwIUzo5lKJIayZjeWgmJY+v9Tb7bHotBaQv/J7pZmnM1vF0sdRUsEkMUsjJQF00zmeH9n5ZzTk6roN5DWI51ufR1CLHuD+AKIrQgNmUuTBLx5Y8oNUGceZ6B34a+JZJhgd+E8Nwh93Mh2Rk5Zrlyv+tLh8ubZO5NVo11S0uhH0GJiBbNgF/CJoPNyfHzwlxIq5HR34dnRe76JDIFRMzCcnqSOSA13MtGanjEr8PDrUDPrMBUaA4XxE3hMnsbtFJjkBRUu7nEfTfRP8JF/aC9LJ3reP9o/XnFoQz0hejOxEPH1xfGZKKcFP4W1+Eo0kQbq9Hq08dTyJrZu0sN0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(376002)(39860400002)(346002)(451199015)(6512007)(26005)(8676002)(38100700002)(66556008)(66476007)(53546011)(478600001)(6506007)(4326008)(36756003)(66946007)(6486002)(86362001)(316002)(6916009)(186003)(83380400001)(2616005)(31696002)(41300700001)(2906002)(8936002)(31686004)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEh4eE43ZnpDbFZwSHk1QmFzL2JWb3hYOXd4VldicVFzZytFODZzTmo4ei82?= =?utf-8?B?ODFxZ0JVVjJVZks4eHd6TkRnaldKcU9ZQlN3a2lZQXB5UytnbTBxemRnZktw?= =?utf-8?B?Nm1meEFlSjdxNmN4ZzJSeWo1LzZmVTkwMUtDK2lveTN3d1ZMam00VTJHL1Jr?= =?utf-8?B?L0l2OWs3WWdUdWF6bGtQcWd2b3k2Smh6Qy95L3FvK0FEVGZsMTFVMHc0SXJq?= =?utf-8?B?SnpDcEh0VkQ4MlhkZ0l4YzB2WmVPWFhjL0llc0h3VGpmRG04V21tLzBNejRE?= =?utf-8?B?Q2g5MCtFLzYxKysrV1hRM2RuYjlMWkx1bnpHOXNOTVNoWkpUNVdKNG9vVDBQ?= =?utf-8?B?VEJad0hCbTd0b1hwajVVMWliWm83TlFENXZ6TTk1bGVEYkw5eTV1cFlNUWVM?= =?utf-8?B?SXdzVDlRWVFHdTB6MnhmbWx0R3F0K2ZrRU12dlVlWjJDZ2lKQ0Q3Q0lBZElG?= =?utf-8?B?QVRjQXVZbEUzNGpjWCs2aVU1Sy9JRG8xZHM2QkNFVUZoWGNLWTZyRW1ZdWhQ?= =?utf-8?B?QUhDb3Rqa0VJRmR1UE0vS2trQVJVRHVSSWQ4Zkw0djZYOTUrYkxvaU1WdEd3?= =?utf-8?B?TkxpS0pVN0E5ZHROUTZuMWU3SkdWeXorRGxLcUtseTBORDNWcXBOOWxhajFI?= =?utf-8?B?MjJSTCtYWlRjVkJXb1FkTmhtVkpTeWpkdGNkN0VjNG02M25mUmpDd3RHZzJ2?= =?utf-8?B?VU5OQWNLNTN0S2FTVDNGa1pUWVRIb05YK2FxOWNiYWZaM3pjcCtDbHN0ZVRs?= =?utf-8?B?bDhOQ0N1Zk5YVzJVbXhrRFRHUExoR0w0TE5KbURCeHJibFhqTXlndjBWZG9D?= =?utf-8?B?VmxaT2UxbnZqL2dSVGs3YkdyeDdnQ0Q2bXh2RkRBNTVtc2IwdHprMDdPbHpr?= =?utf-8?B?bTJCN3dndUJwYVJPSnk2amg2eTVYd3huZENsek5hcEthdWU3MzdLWFB2dmMz?= =?utf-8?B?cFhvYm9kT1d1bzN4UGgrcjdiMjV1SGl2eXIyU3V6alRFcXhhK0dhYTIwazBU?= =?utf-8?B?L01NV1JBTDNoUlM5aGhQQUR6WURJYzh2QU9jT2tVOFVuL290T1EzRUVMZmc5?= =?utf-8?B?Rk0wTEsvVHR1ZTBlVERqSFZTRTFWcStZUGo5OFBTWiswWk1BWDhzcFJWQ3Fr?= =?utf-8?B?VjdWYTJ0UFgxTmVHdERpb1RXNnpSSC84dlpXTURSTEFnbDBybXdROVU2aUJx?= =?utf-8?B?dnJFMHhqak1TNlQzTnlXeUdKUjBuTUdud3MwaFlWWWFzZGw0eEFMNUdpeEd3?= =?utf-8?B?YTE4N3JEZnVxNkIzRlprMGE0OGpUYkx5MkdWTXFjeVBYQ0ZkaWVCR0JQT05x?= =?utf-8?B?QWNHb3l3NGlQQUU0RC9wWG14UTNpbFppQjFtK1ZPZGVCZ0gvYTZQMkFacjJt?= =?utf-8?B?Z1YybVhib0tOenVTYmlGUkMzTzhneUFMQjJzbXljM2ZWOEJFTDRaQTVYcnBQ?= =?utf-8?B?UjBkY1NuTmxJS09FZXh5djVHa3VPUWRQdDY1SmZqRzNncHd1UkluNWpOcHhD?= =?utf-8?B?WGZnNmcwc0lpeWFNK2hEK1FVZUdjT0t6UFhQWVFad2NhRVNIYzFYd1N3Y1Jw?= =?utf-8?B?emR1K21ibWhPdjZHZmJKS3ZiNExDc28yTGdXcFhIcXpLdlV3Wm9NVENPcklu?= =?utf-8?B?aWhXOWdraFk2RWI0WHFUMTlmeHFwT0ZwbDZtUjdTZlJVekwzRCsybnFkRytr?= =?utf-8?B?bmRyK1lTR3lrbnMyL3p5UUJtbytnbEdVZ2p3cDI1eEVQWnJPdzY5d21ZSmtv?= =?utf-8?B?cFBXY3V3OFFLNUE1S0hIRVMrQkhkSmtNbWpoYkVTOGJSd0hQaFZMZktNdWdn?= =?utf-8?B?TlBZT2ZPTjZXUjg1NVU3SWRNRnI4Rm5WNEptR1FoSXY1ZUpFeDN2NmVzb0Zs?= =?utf-8?B?ZVNKbXNEUlNDRDA0NzR0RzFUNnB3UXpGdzZJYVF6NEdxZlppa3NLaFpxU2NQ?= =?utf-8?B?WkhIalEzREs0OXI5ai8zMWxVanVzeDNydHVEYlM5R2phbGt1MDc2UXk5YmRX?= =?utf-8?B?N0NIcERaaGxINGw1bzN5NWdrbmE3VnJyNVFvTEtsK2VNR0V0NW9yeGxIZW9C?= =?utf-8?B?V0ZIZzBiZVRBTmNTR2t4REs3Qm03YU8xeTFoMGR0WjZpZ1NmaHlibWN2MFFi?= =?utf-8?Q?seWcEHome/RkpRQdjn7zRBRp5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d57ecdb2-18a1-4c68-c928-08daa86447b7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 13:03:08.5394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TvxPSJUch2Rk+lOn2wAguWb2+hIf5SYMoHkK/1BjRT3+Lj5hPTqLwonHfcxgeiOcnYtSH3StjqWZZBt+mnI7Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8378 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.10.2022 20:41, H.J. Lu wrote: > On Thu, Oct 6, 2022 at 9:12 AM Jan Beulich wrote: >> >> On 06.10.2022 17:28, H.J. Lu wrote: >>> On Wed, Oct 5, 2022 at 11:58 PM Jan Beulich wrote: >>>> >>>> On 06.10.2022 08:15, Jan Beulich via Binutils wrote: >>>>> On 06.10.2022 01:52, H.J. Lu wrote: >>>>>> Does the new assembler work on Linux kernel which has "rep movsd"? >>>>> >>>>> No. And it shouldn't, as they should never have used MOVSD. The only valid >>>>> mnemonic (in AT&T syntax) is MOVSL. If you're meaning to suggest that we >>>>> continue to support MOVSD in AT&T mode, then this will - once again for >>>>> consistency - need extending to _all_ other D-suffixable insns the SDM >>>>> specifies. I can only repeat what I've said before: Consistency is a >>>>> requirement such that users can predict assembler behavior. >>>> >>>> Note how Clang's integrated assembler doesn't even support CMPSD as a >>>> string instruction - that's imo yet more odd behavior, and likely >>>> attributed _solely_ to the goal of wanting to work around code wrongly >>>> using such. >>> >>> I think we should avoid changing assembly sources if possible. Should we keep >>> CMPSD/MOVSD without any operands? This won't cause any confusion. >> >> Since Clang doesn't support CMPSD, I'd be (hesitantly) okay with keeping >> just the single MOVSD template having no operands. I'm still be inclined >> to warn if it ends up being used, so that people can correct their code. >> If you can explain why you think CMPSD also needs retaining in a similar >> way, I might be talked into keeping the operand-less form there as well. >> But anything going beyond that would have me fall back to requiring >> consistency throughout the mnemonics a D suffix might be used with as >> per vendor documentation. > > Warning is fine with me. We should accept MOVSD and CMPSD without > operands. As it turns out, still dropping the two templates and adding a little bit of code to parse_insn() is easier, especially for the purpose of emitting a warning (which otherwise would need new code elsewhere, in a perhaps less logical place). Before I submit v4 - are there any comments on any of the other patches in this series? Jan