From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2044.outbound.protection.outlook.com [40.107.249.44]) by sourceware.org (Postfix) with ESMTPS id B5A5B385AC3B for ; Tue, 25 Oct 2022 15:41:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5A5B385AC3B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7TNgME06YNqLwfrT/dtoKit5BMyGo/q3LpNE69uRq4WQWFjnAt8VmGuFY+l/2O/lstacy+mIu++7VJSzRVNgpJtNl3tf9y7Tpb/flxgw+/K5VwTAUhOKLctIcZuOI2xTyoDWiRljDBVYgNHTpuztxEmFB4Xmi/8dM7KHWW6U2UOiL2f7PMj6i0XcnF8ZidpalHS79/h4Irl5oYNvB964lKjKYBurmiEeOy89vG0YZT5iNrWNcW7BJnCEyFmogQXF9U/7KVkRvWEB0eDxS8eseBRssU+QUCzWzn/+hUbwvHaSBqD9NNXSu/wWG/zS/rBdLWVh8VFN1spAM8vrr5+ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/PPgt8jW3PI66fpfKO4Ixqi9hQgjanA3u5LzliIiSCI=; b=CwrHDVTBlacqPit790Uf0JHP5G4Rpvscfh1BIqwV7cqfjaqfHfWVG0fYuc9WjOuPyxgUXMRT7CA/WKaSnLFYcL6xDsT6StqkNjazEL/VHTKqert9KtAJnCNFPjDdh21DJmfc6EWp1F3QclS2jE6ficQbniIixvtOMm8wuc2b77Hi62cD05xOE779FutlCJo9se0mmePmdvJ12X9faRSL3G6szbKSAH8tYlfUWiItKn0Vqe3cEUOzBl+dRzQTvuAA6XCGEku5sy0oJli7zWSorQnREg/glXgVPu+WCzuEqyBOwcFYJXlkYrvtX6w8mEXdnix6r3GZ8ptrirSKtiHw8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/PPgt8jW3PI66fpfKO4Ixqi9hQgjanA3u5LzliIiSCI=; b=UCXzOy0mA+6bpYUol3WNcfrs9D8xSZofC+kFqhrjL9UUAa2ngOaDV9Da+4dblSOuZ4eQTo4fqw07jH8QWNFpdVZvdMZ2Jq5MuifjkxgJjoRWE3WMPwxcEDrbFMK+GUil/v6LEz0qSwgp+JyZMZahkEzYHRmMA4g/5+sXhCmvO0iYScZt1dGpwr04h1Y1HHMmkUclZjvq+OFFkYHId54HCXTRDkla2bcpNEGAkhjTeYv3edRYX9zs5p817114bO1TBETpdx8qVdtFqsTiDgvNX8Ar+8eNxKnEYoyOe0cEKKuinh5B5m3xk2LWjNwlWkz0P9WGNkauD0m9KQfJZcU1rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9504.eurprd04.prod.outlook.com (2603:10a6:20b:4d2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 15:41:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 15:41:48 +0000 Message-ID: <92294830-ae0c-72a5-c07c-32c003dc52fe@suse.com> Date: Tue, 25 Oct 2022 17:41:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 10/10] Support Intel PREFETCHI Content-Language: en-US To: "Cui, Lili" Cc: "binutils@sourceware.org" , "Jiang, Haochen" , "hjl.tools@gmail.com" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-11-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9504:EE_ X-MS-Office365-Filtering-Correlation-Id: 02f2169e-4eed-474a-e8fb-08dab69f6ddc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lhK6x+TVEety38r+0LCcv5cOZceXh1kn+cBbpPg4kEMH4SV/BqOmJR8Z9Ltq5JSQiY1s7vBwJTOQcj+u/rmYyKAw/5kTxJW4qzWCysrUJ+QN+QsCkkW+JMGoONTTWvcz2UP2oT/fvnS2zaC3uDgBp1wWbUt3xCZULFaBR3sjh1sJdaNeYsGt+UIbMphLfRcX/0JCe/qx8sse6CoVZ2nep455YKtBQfcq5Sx5ZJ1l3XcmXq5Cgkv9YRDctVhmKBlsm+XIG5qK7AUNr8J/64URs+pdvVthK8BhjpTNQ9RcLT0XVo7qXwzvu8J1UW9J3yKoZBeAaUKaATwk6LeAmeETzW2My0BwbFVyxrcMeEQbsLrplkRhL2RnNMWIg7+5x/4z+9gsfZFr5hBxEn3DlWE5hkQordxyW5//4ykaNLTwMrmfEmNlXRpV/lnHHlefmTec/Op5ne3we1y2q1SAa1HE0hxYUupc55TZz47uz+RpT7/HYxUivzQ3C6gSgLW8UA/7tEFl2q17pOagbImxQLt/5PBGU1cE0lm0AuJwMJw0qY22+fxR8raLTpv7MsghT/lQOwBLOzeoQtXZm4vEN/Irp+vvcJXe9UwmBaPUhuUlYLUA1BgNX47GkCahXOlDItjHKTLHFB5GVA4uG4Som4tqJR3ciK8ijwSq2rYw6/pcGB4UZAz5ETmOBVmikmf8zEK3FzdVkmi0LN3a5STC12QiSjh9Jf75P/W6/xHzTycSOe7tT/nGv4FCnNolB81YnUH18aNMKBc/JrCZEUid0cGuvrfFifrkB2p+upYaO1wN9OA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199015)(36756003)(53546011)(2906002)(8936002)(4744005)(31696002)(86362001)(5660300002)(6506007)(66946007)(2616005)(186003)(6512007)(26005)(38100700002)(4326008)(66556008)(8676002)(478600001)(316002)(54906003)(6486002)(6916009)(66476007)(41300700001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWlpUG11YzRBd0NNcVBTMVA4WW4wN3MyRlh1ZWdYK3dQUnUrczJVYXBxMUxn?= =?utf-8?B?WUVQdTIvYzU3c0FUd1MxQVY5Z1gwR1pLdUxXdGg4cGpNK0JPN3RCcWRwbFBu?= =?utf-8?B?b0VqUWFETUhKbWJTSmQ4ZGE1bzNlT2F3RURFbGVqSGJmTG9mT3B3OGNWa2JE?= =?utf-8?B?czRLWjFxNXZHN1BldjJLVDlVMSt3WW5IY1IwNytNRmMzalBEcVFFZEFOR29h?= =?utf-8?B?MS92M0ovMVovYXFNdDhYMldxOVhRa0ZHVWNGWGtNSFkrbVJrY2tDL2taZlA2?= =?utf-8?B?cjh3NWtveVRzSnpiUjFHMERlSWJVajVCdExFQkp5NVdnd0UzMjRudHRBRXBI?= =?utf-8?B?dTdFajNObXZENEM3b2Z6TGFKZ3N6L1lJWllRQllEMWNmQTY2cjBSYmc4T3or?= =?utf-8?B?Nm1IKzRCYnFJNmtnUWIvQ1FuWFNPRHBwUkNNa1NkalJqNVlGOHBkdkJSUzZI?= =?utf-8?B?RUdUMHhTU3NmNmJUZEtGaFlraUQ5VUZmdDZ4dWFNV3F5SmxYbXFVa3JyaXBa?= =?utf-8?B?VCt6YWIrUGQyNU56OGszTFVoMlk0cWp4L0FEUE5TQ2Nxa1lxM0JYR3VPb2RX?= =?utf-8?B?K3dJQ1lpUDQ0S1JUcXlTL2xzVG1iK1hwaDVVRVBGV2txYmNxRHozeHNUYjdm?= =?utf-8?B?TGcycVlkdEhaeVRJN2ZZZ3AxRnBzcmEwbTlPSUNRbUZKaHZON3U3bzREbXRq?= =?utf-8?B?SUJyVGo1THR4cURBTENPNVRoeERlWUVKaUdqeVN2YmlyNlhoQ1BZN2Y5dmh6?= =?utf-8?B?a2YvRC9kWFBFQUwxakc4a3RvbXNISllkMW5nVkVxcHI4Y2Y0M3NaK21GMjJE?= =?utf-8?B?d1VnaU5XZCtzSXRRYmp6VXBUNGNRY3B1WVVMK1l3dzZrWnJORjg0eEF0RHBa?= =?utf-8?B?b2docHZVS0o1U2hvNlcvNXZaTkkrL1BoVkdkTjR3ZWVJclBDRmh3bVVEMm1s?= =?utf-8?B?aFFZd1ZLellnQUU1Yy9QMitFY05qKzBIMU02a3NXbXZMcW9CVlkxa2pFT05o?= =?utf-8?B?d1FIYlBxK1lsMFI2L0dIZC8vSk5jWUxBazZOSTFqTzJZc3BJaWxlWVNyYWpW?= =?utf-8?B?MTA5ZXNoVVZ1NkNJNjhwQmkwR3RZZzE4eUNHR09STGNPN01mN01nSkJZN1JH?= =?utf-8?B?dStBWTY2SUFHcVRrOFVMS1FqZzhtZDAvVEsreXF3YzBmMW1lQnFNdlIyWkRO?= =?utf-8?B?R0JqZ1dNam1LTVQ1ZDAreGVjenpuWTNqWVp5NzBhaUdTeW5uSS9UblhEaG8y?= =?utf-8?B?N0U2ZU1qNmdZZ25aMWRCaENtQjNWTm5uNmsrNUdkREx2NzArRXNZcmordndD?= =?utf-8?B?MXFYOWp2bjhiWElmRVhiRFpTYTNEMDV6dG9US1RicG1DK0lXbEJZTnEwRVBZ?= =?utf-8?B?NnF1ZjNxR0diVUE3NDNPN1R1NmRuRXRJV0VjbXVSK1pIamJrS3lGNm9GdmYy?= =?utf-8?B?cUg4eWNKRk4zc1BpaXVWRjBCMUZsdzdtTTJvd3pCaWpZeVpIMWdQMlQ0N3lz?= =?utf-8?B?YThlTmcwNjZJSzVQTFdPSWMyQVByZnRKMW1nRkswaDhYVTJTcE9MWkhzM3Bw?= =?utf-8?B?ZXVTYUhiTkFMSVc2Nzh5aXhCWE9UWUNRcytmeWpaMU5YZGVnMUFtbi8rOVV3?= =?utf-8?B?UDRJV28xRjZiVVUxb2tjeEQzQnB4cmRISnNkVldxSnhRQytybUVKbW9na3ZJ?= =?utf-8?B?WGdhR1U5Rjc1QkpUejBySGt0VE5icGdTY2Jxc3VqMDB4bGsrQkdHdi9MZW5K?= =?utf-8?B?Z0lNaG45T0phajNCdVlZMGxwYkE4dFlHUVd0Nk1OV2diUW5ibERYTzkwWEdJ?= =?utf-8?B?ekF3M25TcHN1L05uTHFadk1Rc3VaZGhZa0RMK2VVQXZMaVhQRWxnSnpsUGVh?= =?utf-8?B?bmNpV0MxZ0l3VUJkY2dCWW9ENkkraElGelE0eHZZS0YwOUF2TFI3V0x5NTh4?= =?utf-8?B?WEZOU1BMSHFqZ3ZLaWhuK0dCdTZLNFRIa2cyUzByZ3dONVZNWEMzOW9oRFIz?= =?utf-8?B?bHBxdEZadFJiWTdEZVhrWVN6elp3SUZBV2ltWFpJTTk1RUJManQ2UE9qZVpv?= =?utf-8?B?UW9MVTJpMERoVnFmb2llVENWSW1CbkpPTGUxdUJkczlEOHd3S1JmWVgrN3M4?= =?utf-8?Q?wUS2nSWIJNAP+QAoWTzWy3v2u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02f2169e-4eed-474a-e8fb-08dab69f6ddc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:41:48.6845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LBQKGHKwVuo+C7abUBC5BpWlMsac5tS6qlhU18jMrT2pK2ebHyEX2ET8vDGV3Y+BYXjuhc0kufs0gtlx5fewjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9504 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.10.2022 15:03, Cui, Lili wrote: >>> + { >>> + if (ins->intel_syntax) >>> + ins->mnemonicendp = stpcpy (ins->obuf, "nop "); >>> + else >>> + ins->mnemonicendp = stpcpy (ins->obuf, "nopl "); >> >> Why "nopl"? There's no NP ahead of the opcode (and you also don't go >> through prefix_table[]), so I expect operand size should be expressed here >> correctly. > I changed it to nop. But that still doesn't correctly express operand size. It needs to be nopl / nopq / nopw depending on operand size prefix and REX.W. IOW no different than how this opcode would (hopefully) disassemble before your change. Jan