From: Jens Remus <jremus@linux.ibm.com>
To: binutils@emagii.com, binutils@sourceware.org
Cc: nickc@redhat.com, Ulf Samuelsson <ulf@emagii.com>
Subject: Re: [PATCH v3 5/7] Add testsuite for ASCII command
Date: Mon, 8 Jul 2024 18:23:38 +0200 [thread overview]
Message-ID: <933bc9f5-3001-43b2-93d6-80db0890c947@linux.ibm.com> (raw)
In-Reply-To: <20240708150422.4926-6-binutils@emagii.com>
Am 08.07.2024 um 17:04 schrieb binutils@emagii.com:
> From: Ulf Samuelsson <ulf@emagii.com>
>
> Signed-off-by: Ulf Samuelsson <ulf@emagii.com>
> ---
> ld/testsuite/ld-scripts/ascii.d | 25 ++++++++++++++++++++
> ld/testsuite/ld-scripts/ascii.s | 11 +++++++++
> ld/testsuite/ld-scripts/ascii.t | 38 ++++++++++++++++++++++++++++++
> ld/testsuite/ld-scripts/script.exp | 1 +
> 4 files changed, 75 insertions(+)
> create mode 100644 ld/testsuite/ld-scripts/ascii.d
> create mode 100644 ld/testsuite/ld-scripts/ascii.s
> create mode 100644 ld/testsuite/ld-scripts/ascii.t
>
...
> diff --git a/ld/testsuite/ld-scripts/ascii.s b/ld/testsuite/ld-scripts/ascii.s
> new file mode 100644
> index 00000000000..a1b6148dc79
> --- /dev/null
> +++ b/ld/testsuite/ld-scripts/ascii.s
> @@ -0,0 +1,11 @@
> + .extern ecc_start
Nit: Use a tab instead of the 8 spaces for indentation.
> + .section .text
> +main:
> + .long 0x45444F43
> + .long 0x12345678
> +
> + .section .data
> + .long 0x9abcdef0
> +
> + .section .bss
> + .long 0
...
Regards,
Jens
--
Jens Remus
Linux on Z Development (D3303) and z/VSE Support
+49-7031-16-1128 Office
jremus@de.ibm.com
IBM
IBM Deutschland Research & Development GmbH; Vorsitzender des
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/
next prev parent reply other threads:[~2024-07-08 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 15:04 [PATCH v3 0/7] ASCII output section command binutils
2024-07-08 15:04 ` [PATCH v3 1/7] ldlex.l: Add ASCII token binutils
2024-07-08 15:04 ` [PATCH v3 2/7] ldgram.y: Add ASCII parsing binutils
2024-07-08 16:22 ` Jens Remus
2024-07-08 15:04 ` [PATCH v3 3/7] ldlang.*: process ASCII command binutils
2024-07-08 15:04 ` [PATCH v3 4/7] ld.texi: Add ASCII to info file binutils
2024-07-08 15:04 ` [PATCH v3 5/7] Add testsuite for ASCII command binutils
2024-07-08 16:23 ` Jens Remus [this message]
2024-07-08 15:04 ` [PATCH v3 6/7] NEWS: Add " binutils
2024-07-08 15:04 ` [PATCH v3 7/7] ChangeLog: " binutils
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=933bc9f5-3001-43b2-93d6-80db0890c947@linux.ibm.com \
--to=jremus@linux.ibm.com \
--cc=binutils@emagii.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=ulf@emagii.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).