From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] x86: Don't use .insn with '/'
Date: Thu, 4 Jan 2024 10:33:04 +0100 [thread overview]
Message-ID: <936f138d-fca9-4dba-809a-e8f9ddaa1ed3@suse.com> (raw)
In-Reply-To: <20231229235033.338761-1-hjl.tools@gmail.com>
On 30.12.2023 00:50, H.J. Lu wrote:
> '/' starts a comment for some targets. Use .byte instead of .insn with
> '/'.
>
> * testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s: Use .byte
> instead of .insn with '/'.
Nack. The proper approach is to pass --divide to gas for such tests. I've
made very clear during review of the APX series that _wherever possible_
the more descriptive .insn should be used in preference to .byte.
Jan
> --- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> @@ -39,11 +39,11 @@ _start:
> .insn EVEX.L0.NP.0f38.W1 0xf5, %rax, (%rax,%rbx){1to8}, %rcx
>
> #{evex} inc %rax %rbx EVEX.vvvv != 1111 && EVEX.ND = 0.
> - .insn EVEX.L0.NP.M4.W1 0xff/0, (%rax,%rcx), %rbx
> + .byte 0x62, 0xf4, 0xe4, 0x08, 0xff, 0x04, 0x08
> # pop2 %rax, %r8 set EVEX.ND=0.
> - .insn EVEX.L0.M4.W0 0x8f/0, %rax, %r8
> + .byte 0x62, 0xf4, 0x3c, 0x08, 0x8f, 0xc0
> .byte 0xff, 0xff, 0xff
> # pop2 %rax, %r8 set EVEX.vvvv = 1111.
> .insn EVEX.L0.M4.W0 0x8f, %rax, {rn-sae},%r8
> # pop2 %r8, %r8.
> - .insn EVEX.L0.M4.W0 0x8f/0, %r8,{rn-sae}, %r8
> + .byte 0x62, 0xd4, 0x3c, 0x18, 0x8f, 0xc0
prev parent reply other threads:[~2024-01-04 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 23:50 H.J. Lu
2023-12-29 23:50 ` [PATCH 2/2] x86: Append "#pass" to APX tests H.J. Lu
2024-01-04 9:35 ` Jan Beulich
2024-01-04 9:33 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=936f138d-fca9-4dba-809a-e8f9ddaa1ed3@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).