From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 0BC3F3857C60 for ; Thu, 4 Jan 2024 09:32:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BC3F3857C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0BC3F3857C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704360778; cv=none; b=YqoQVp2FPqQqschozcpdADiMySz0BaaElnf+TKunUl+NtkNxcpewFsltv1hjx7xw1NGepWRGdQdRNGXXEGec+JrGFoz10bhyz2tp3X6httco8VSQK0tacxTpqlx6FHqetrYL8Uvujs5imhZoUt0Y3LMmRvgRHo0zdk8BJ5J5WGI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704360778; c=relaxed/simple; bh=ViRSsj8MCLyee1lvML3ruA7CmxpQtHTK1UPO8ULralU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cQGVX6L0hZD+ANfSR6G8LnFEFrK4DTy7xv8nztniHuWFOX9GjPx9HHH7v88PelI3e9SM4Pt5Cl+Fry1NF/lfT5PwEma0PMHkw21DeOUwRkMeP28WjnY/al4jYnAnfYVgHSmnByiQpCZiajCVxgCw7EMD95D38xWNWdMfzJOLrbw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50eabbc3dccso306712e87.2 for ; Thu, 04 Jan 2024 01:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704360775; x=1704965575; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sMx2u/2QN+LfdMf+Z1CQbgSTYOw8mUsHTHSqIp2HzXA=; b=gSM+z+vK+48SEKN95WtBL59t2jH8rT6zVhh/n/4TwsJaMr0c323jXJ1tIgGQCPt5+m PnF/6rBOe7taW2NZt6aKYaEcBVwucwQeCjQwR3cT93ntpOhW7uWqBtkQyy4h/igcMo8K bCRYuoHDmgnqqTK7rAHNhqRwiGn5hVuXJ5vA1YDP+YtC4YI40KXadHfcCDsd0Q1I/j40 0ZleBbf01mtdhEHQCGAb86g9P9RZGHS8cCf3MXEt8bmiWRPJjGtACNkbaYm39DBNJNOj wtzcRGMYvB6mtNEPIC7jPmEww1dm0kzR0Wt/rRo+duWOP2jq9sInnlxA/DZkfHYckbF7 szdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704360775; x=1704965575; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sMx2u/2QN+LfdMf+Z1CQbgSTYOw8mUsHTHSqIp2HzXA=; b=LSib/VKL9+x4hqzbIwjqZbk23RlK3eFxkLgFBFk7siD1VbsekDVo1v4OvLYJWks/mE 93TA23Lu1qMlkVGKxEfBr/uyx8+qWCmxUJRzJu6M5XAEVjjn+QokyiSCRYTvfbs4zNio qvkAFyXagfa9aSUVa1l5HADwaim51oVTNdos5w1GdU0XcjA64ltsiy9PwD+8CCxhChQA CCUtUDjXVZTXnHf7ATPaDd264V1Qw4k/BcE6wJGiHUf1trBmdeib7dJ6CkP5HBGEHbc6 oHMRl3x0tNJPhup4hOWlSB2At1l/LO8YlwydfEQfHmzpu1s+0oEus3qPDGHmKurW/I3g jvZg== X-Gm-Message-State: AOJu0YxFI9/iItIDV4Xs6NsYPA8KrbvYHQQjPHVTVvMSyDfhlHHtXpn7 BnoTk8dOn9Ou8gjbirxR0I3seb2hYsDh X-Google-Smtp-Source: AGHT+IEe0qmku1xGZgPLHdNKomwuyJgCNzuH6pVMPiv2n0ZyisHubgwVPqoSYjXsPc/1TWvRl9eLhA== X-Received: by 2002:a19:4f0d:0:b0:50e:84b5:a4c with SMTP id d13-20020a194f0d000000b0050e84b50a4cmr109130lfb.232.1704360775504; Thu, 04 Jan 2024 01:32:55 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id f16-20020a02cad0000000b0046ded19fac5sm343009jap.47.2024.01.04.01.32.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 01:32:55 -0800 (PST) Message-ID: <936f138d-fca9-4dba-809a-e8f9ddaa1ed3@suse.com> Date: Thu, 4 Jan 2024 10:33:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] x86: Don't use .insn with '/' Content-Language: en-US To: "H.J. Lu" References: <20231229235033.338761-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231229235033.338761-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.12.2023 00:50, H.J. Lu wrote: > '/' starts a comment for some targets. Use .byte instead of .insn with > '/'. > > * testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s: Use .byte > instead of .insn with '/'. Nack. The proper approach is to pass --divide to gas for such tests. I've made very clear during review of the APX series that _wherever possible_ the more descriptive .insn should be used in preference to .byte. Jan > --- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s > +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s > @@ -39,11 +39,11 @@ _start: > .insn EVEX.L0.NP.0f38.W1 0xf5, %rax, (%rax,%rbx){1to8}, %rcx > > #{evex} inc %rax %rbx EVEX.vvvv != 1111 && EVEX.ND = 0. > - .insn EVEX.L0.NP.M4.W1 0xff/0, (%rax,%rcx), %rbx > + .byte 0x62, 0xf4, 0xe4, 0x08, 0xff, 0x04, 0x08 > # pop2 %rax, %r8 set EVEX.ND=0. > - .insn EVEX.L0.M4.W0 0x8f/0, %rax, %r8 > + .byte 0x62, 0xf4, 0x3c, 0x08, 0x8f, 0xc0 > .byte 0xff, 0xff, 0xff > # pop2 %rax, %r8 set EVEX.vvvv = 1111. > .insn EVEX.L0.M4.W0 0x8f, %rax, {rn-sae},%r8 > # pop2 %r8, %r8. > - .insn EVEX.L0.M4.W0 0x8f/0, %r8,{rn-sae}, %r8 > + .byte 0x62, 0xd4, 0x3c, 0x18, 0x8f, 0xc0