From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2086.outbound.protection.outlook.com [40.107.104.86]) by sourceware.org (Postfix) with ESMTPS id 97ADD3858C41 for ; Wed, 16 Aug 2023 09:00:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97ADD3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LY3Ks4l3f5sQB9sHBzzIRbdwGPUGfGYkxl8cD42656UzRfZTzbyFYKsdpf2WVrkkaxBQsoLkZ45fJfu4zDMADoQ8WnXGN0wxx0ixqR3Em1NPu35LFzaLqOKWZ1DGbAyJXFMauO3S/VRYCO6ahYoH/YNoaeSI044LrJj8Iq6MuwfqUrio7UQatCrbsrBHy5myQOc50MWQGf3T34EKZOuPhbdimHsxFbK4Fqi6qF0k5U4uJZfYtxaJ5tEQUrgm901ObbGvvwmYt1z2pLRkqXKD5sQPo0JWLOHD6D8xhjdPWealxgRLdDACuQPiP0LpXrzpaf7VdApKrusvTU38g5FDeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7E8B82rm4NvM2fkMUhZjjbjUZU+K734OT2Dv9zQbJsw=; b=MibJp7HmkIFMrLoIvLhPXukTyuWkrbJcSBXTCtpXF9Mzwi7H7gDk/UJa+uBKzwe4WKJjGNZZMuMHu09bN2yh5TodeTiOPYsUi4VsHni5hZRcWkLRUb1k5sPlBtZEKiEdPCtRwscOV/j1LOMvUFpUnPIGhBDY4GcStktkmiht+ZSagzxFMA52S4V+qX3qo1qesB6aPyUSQRA2EtAVsr6cvKxcG/YFBKPm/7Kv93MrGn4GyqTTEWxa3rnfsWClb1rOdOIx14yhKkGwwz5ImLDP7ETS+1vsKcHYpBm3AYaz+LrrpWqhd82/I6zdztJZF4H+D0EsdIIDUSMumrbUlbFH7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7E8B82rm4NvM2fkMUhZjjbjUZU+K734OT2Dv9zQbJsw=; b=q0rDw0kuLbwO81vd0lZ+J0KefX0yIc1EcIyk4oLsPJm+Sht9YxVUzUi9NPSQDTYOLOd6z6rXeUVf7vl7Vmadr2sPwKrPmt82cl4vbAt2gFJLKt6Rjs56H7RyLQmXADWn+N0sk46MCYfPpAFPTWkTAyyoxgIa4X2onaX0e7Jjnng158T+3y4A9xEB2IhlsfhaX1EWKYUWu3gTIOVhq1RP4rYbcHjSB40y8bmdSejkfB+/thnFMrDj5FxIRimN/ibkQzGlExSNoGvtMYVLC4WQlD5f/NNsuOxtKPnONrZZpTgWZENQvSvaUjnq8Wsk6BD9zQjNMmbnck8GGnCyc+cIPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GV1PR04MB9136.eurprd04.prod.outlook.com (2603:10a6:150:27::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Wed, 16 Aug 2023 09:00:00 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::79a:54ba:8003:fbe7]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::79a:54ba:8003:fbe7%6]) with mapi id 15.20.6678.029; Wed, 16 Aug 2023 08:59:59 +0000 Message-ID: <93eedcac-d2b5-578e-0630-2ed71bf5ddae@suse.com> Date: Wed, 16 Aug 2023 10:59:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2] Support Intel AVX10.1 Content-Language: en-US To: "Jiang, Haochen" Cc: "binutils@sourceware.org" , "hjl.tools@gmail.com" References: <5eb31b18-e1ba-dbf1-bddb-ff03b61b25de@suse.com> <20230814064535.3228154-1-haochen.jiang@intel.com> <4c47b6af-ed3f-ec3f-4a28-cd6e052470f9@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0058.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GV1PR04MB9136:EE_ X-MS-Office365-Filtering-Correlation-Id: aacdace2-9deb-41c3-db0b-08db9e372bb5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IIJnNYU5Aj5585isVSALQhU9Yfz/f38Py5AdHONjzm9IvXpQtaNbGzUWBx9jG5kil5Ibh7evC+1o30hszB5mGDdDVwxg0kfOjvZ1XOLzRfPySq3H3L3hsztE+KWtuXtKN7HZ5iZSPXuxcfQMsAqhDvLnyCGbUo6GS8sllo6tLoX293szLdVybE2diEnDKv/Pr0v3ILmgMu8iNDlEMcmg/5tQ7Rd+ielQEzS6QCTkdeTr9R0YLEYrnyLQ4gfIOTM+/l9dkFuQfAk8Dgupe7J9rZCfYFdyWWupJbeVamDoURX1q46BP8YASY3LmyYXz6eOD1A6BFhLYR9xO1Xjfsh5jIlOJQ/93kww0drxfQ2+kcMDZsEEEIb/PwlU7sPP3vPRZktr5UXecdI6e6TK1xdb46cSAFPBTVHu+mf9IosfQZd1iDs+kInVECbUMo9eHeYp/+POvmd+YxwlMWiL6SqbMSboV4ktpXGDKC+z8Q9VGUdFnjRm/rKc4zunupfSdxgaD1ky84M70neVnECEy9jPs1Imgsga5qTvBsJs2e6q3zaOhiLOQHSsK51pYaVxr85ypSfaGc8MBands01ttsKZbOnZaqLEjPfaBHF3Y7+2o9i4hhuhbnasN/fVWlicjkB0DQ8csU8qSBjR9sOoyZ0b3A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(396003)(136003)(376002)(39860400002)(1800799009)(451199024)(186009)(2906002)(66899024)(86362001)(478600001)(31696002)(36756003)(2616005)(6486002)(6506007)(6512007)(53546011)(26005)(5660300002)(41300700001)(6916009)(316002)(54906003)(66946007)(66556008)(66476007)(4326008)(8676002)(8936002)(31686004)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTJpZTFFRTdsODUxdEloejlWWS9jSmFFZmRscGVhNzk5M29ZRXBoQ3F3eDJj?= =?utf-8?B?aWdabURjSlhKVHhqaXFFWURESXhNRU82N0g2WTVPZEtjSjJXdnA5RGZCSE5m?= =?utf-8?B?c1k0ZXBjQjVRNmJCMGtZdkpPajB0RGsyNzdTVTJGdkZua0FqbUhBRUxEQk5Z?= =?utf-8?B?R050aGc5QnJSNDBBRXRYYnowVnJYWHcxUVJPVEF5Y2xYRXBTM29FMFpxZ2Ni?= =?utf-8?B?RThxUkZNNjdEM3ZocWMvZkhBdExuWXJsRU02ZWN5N044ODJkVWRxYmNsTEZi?= =?utf-8?B?UmJFOUxrM2YwVG1LbVJaM3hoL3lmNFhJWnhDZEtCUm5VWTRrYmhFOXVDOHlD?= =?utf-8?B?bUVZN0pHNE5OS2JJcGZEOENGeG1oUVFmaDh4NFFrZ3hCQnJMMUNnc1UvUWNM?= =?utf-8?B?UzJpdUJweUFvUlo4QjBQV1BTUy9zTjI2eVdVa0x2SW9pWlRGczRVKzAzaExl?= =?utf-8?B?SUNNOU5ySkFhaEFIR3NRZTk2d1R0c3pEVFQ2QU5TQnpqUTllWWtlNlhmVDBU?= =?utf-8?B?d2ZYSEc3bmxuSE1xVy8xS2ZCN01veDVLUlEzQTRkbk5pbWdHNU5HVWY2N3hr?= =?utf-8?B?T3AyMVMwc1Z1ZjMvdGhYbCt4bnpBTlBIdnQ1Mi94YzM2d0gySS9mZXZsdWFX?= =?utf-8?B?cnJDcHJJRVI3R2dvMGJBb1JZL3VoWC9RVHNGZzd3d3c5M2g0c3dzdXU4aENK?= =?utf-8?B?NHFDcUdFY2RoZTVzOHBpakdUL1o0TWhpUkhQdWE2M2lsUFB4VGR2cWw1SGZ3?= =?utf-8?B?YjF2QnQyZFRaVU9mMzdvZ0MySVlCb2YzN3YvVGx0QWVOSWdYSDRib1U2VlpU?= =?utf-8?B?eVVlMjhNejhVQ0dDZkpPZUlzdnN4TVU1YjhDRlVVcVQ2bmhiNWNLaVRYR2t5?= =?utf-8?B?elpmR21yTnpMS01wbnJsdy9KVjBiTWFOSGp6a3ZxeG12OUh4WFd4QlVjbUpv?= =?utf-8?B?UldsMjNmUXJqVmZTTmRtbjV5RXNuTXRaaDJGcHBQYUlLMU9POGNHa0VNZlFB?= =?utf-8?B?UE4rSFB3VnJXNDAxaEhvVXFPZWxIaW0yVlBjZW8vM3ZSUTAzSnV1bTN1Q2Iz?= =?utf-8?B?SEkydm1EVlNhUGlYZUtsN3JPZjB2OFNyZk5FSEhtWWVudWljbmdEMDR0QlBF?= =?utf-8?B?ekNiZzlhdUYxRFlaT0k1UFBVckJyL0QzMFlYVWpQaXVxbkowYVVBOXQ3OVlZ?= =?utf-8?B?NHFGVjhuTU5FdzJDYTRUQUtSRDg1V1dVWkFDRERvR3Q0clNheEtOUXhnenI0?= =?utf-8?B?VEIyeDFVMzdLK1V2RVBkZDQwRXZGdVkzeDhZc3E4ZWJxVTN3OXZnekNUSjdF?= =?utf-8?B?dmpLMmh0YjJLbkMwN1ZPdmdZaGdKUXVUQzlMbWJYNGNXTlppTFZmMjJMSk5C?= =?utf-8?B?U0VGaEQ2aTRTL25MdkptZjNrSG5HcXFKRVZkZ2ljaDNxNERSbTdETUYyNEFj?= =?utf-8?B?YTZ3S0haSno1bXhNL1ZzVTBlT1FLSklkbXhPcEV3QVBUZVRVK1lCS20wSnll?= =?utf-8?B?RDNiS1NNNFpxUXdiK2ZMQjhsTUhXZHQzSG5VdG9RNzZNMEpxNXlialZvS1Zp?= =?utf-8?B?N2IyN3JRODBrUCs2RkttY1FMYVFPdEVXQkZFVE9YUklEOXp1OTlhWlZOWDNu?= =?utf-8?B?MlJCRHVvTlp0UjI1c2RpdEtaU3BNSUsxZ2FRZ0JLWjZhZDEzRTBCSjI3WjFy?= =?utf-8?B?ZVZZUWZwRVZRY0I3YTBkRlV4MVdpbmZSZHlyTzZ1MFVsdXM2Sk1FbGF4Sk9K?= =?utf-8?B?RjJxVms1b01nMmg0OG56L0xEMit5SDlSMWJzSXhBWVJXR1hZS2h0RHhXR3ZC?= =?utf-8?B?QzZyVVQ3S1l1aWxiSDF5NFRvaklZLzZwOWV6TTJVQmpDc0ViMzFLMm5XTjUz?= =?utf-8?B?WEdFekJYZHNUYXVRTDE2Y1FSL1RuTUFYZ2JlWDlBTDRGOWtpbWNmblQyUnNT?= =?utf-8?B?MHUzZ0IyRVFaVkxldVpXa1BXdjN6YVRldktmbmtkVnFmWmVRUjg2Tno1bzJh?= =?utf-8?B?RGVwRUZ2ZGRtRGsrNjF2VUNlOWFMYTJqTTBZbUNta1NhZXBsWlE1S1ZVbElC?= =?utf-8?B?aVkxVkhjWER2NG5PNjMyK29PcnBJWUdNYmkvb0JHbjlOVEorT09XTFdLUzg0?= =?utf-8?Q?KLlpyefE4dvx8KOMYg9MBBCPQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aacdace2-9deb-41c3-db0b-08db9e372bb5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 08:59:59.8231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +ulKzHkrQ7/rG9RwC2XHYIgsu8bnWQu5gn9ibYMRkdrY+zwF2QWRFhDbJqEEiaJ46iNcbQMm6Cq/eYBsJYLZlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9136 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16.08.2023 10:21, Jiang, Haochen wrote: >>> After I think twice on that, I suppose maybe it is not that appropriate to put it >>> into i386_opcode_modifier since in AVX10, the vector width is depends on CPU. >>> I suppose i386_opcode_modifier is a feature for instructions but not CPU. >> >> I disagree. See the uses of EVex, for example. As said above, I think >> maximum vector width and ISA extensions want dealing with separately, >> and only the latter would generally qualify for Cpu* flags. Furthermore >> recall that the attribute wants widening sooner or later, and Cpu* >> flags are uniformly boolean. Only attributes may have numeric values. > > After I checked code, I still miss the point here. > > My concern is how to actually disable the zmm registers for AVX10/256 > and ymm registers for theoretical AVX10/128. That's the easy part: That'll want doing in check_register(). The issue is with insns which do 512-bit operation despite not using zmm registers (think of vfpclassp* with memory operand). > I suppose i386_opcode_modifier > is more related to building up the whole encoding. But each AVX10.X/256 is an > actual arch. I wouldn't agree with the last sentence, but ... > Adding a feature in i386_opcode_modifier can indicate what is the maximum > vector length the instruction is allowed on all archs but has nothing to do with > disabling zmm registers on an 256-bit only arch. ... you still have a point here. Maybe it only wants to be a boolean, indicating that an insn is vector-length sensitive. Yet re-using the EVex attribute continues to be an option: With vector length constrained to 256 (or 128) bits, EVEX512 (or EVEX256) simply become unavailable for encoding, and EVEXDYN would be equally constrained. And if re-using that attribute continues to be an option, adding a new non-boolean attribute clearly is also possible. So I guess there may have been a slight misunderstanding: I was suggesting an attribute expressing permissible vector lengths (hence the consideration of re-using EVex), which would then be checked against the established (through whatever directive / command line option) maximum vector length. I did not suggest a new "max vector length" attribute. Jan