From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 55090388981D for ; Wed, 16 Mar 2022 16:55:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55090388981D Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-280-EalJY862OfWCJnDnYwdLfA-1; Wed, 16 Mar 2022 12:55:23 -0400 X-MC-Unique: EalJY862OfWCJnDnYwdLfA-1 Received: by mail-wm1-f72.google.com with SMTP id o10-20020a1c4d0a000000b0038c6e5fcbaeso967377wmh.9 for ; Wed, 16 Mar 2022 09:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=sxFUs7/4xtqttu7mlrl017Da4VkMueOEsCcKqcPIbds=; b=l/A+G8Lw6NSKaJ+39eeRd8TFVmxsAfgxA09nTgJMVxVDEf3cetkQvIjx1Q56JWLp75 8OAXXKAEmCoXAl3nXaiQd7+1AdH5SDc/RgVROo1SMOhxjQuW8s42FfV4/r2DpTJP2Vh5 dXQ/dUOfVyMauEpKzt9qXBxEThJQNGcZlv/djwcn1WKlFdzFZo6o+oxZxM6f8ki5CrmO MhRBv0//Ka1GAaagfRA8Crs80xTN3ZiaIgFzdnMI4NEgkqms25DPACd3bdDTo/5DLljX hrf3p+SH5PcG24vl/eNlpUsciOZOEztUuWmbyP6rxWTsE7ZDxlTBwMo0NJdR26S3rOO+ nWaw== X-Gm-Message-State: AOAM530Fjy9pLruOEw5Xq2DeGLWcNG6Q1EabCywO4IRolHeOT0NP90X+ FQyu8uevBZQOJA9pSeBDXP8wLeSSEu5smm/Ugnajq1QoQqQH8x7OfsIqIuxRs+A6siWaNUNcrER cvyTkiEFPp/4WQ6J7JA== X-Received: by 2002:a5d:6488:0:b0:203:b628:70d2 with SMTP id o8-20020a5d6488000000b00203b62870d2mr668513wri.83.1647449722589; Wed, 16 Mar 2022 09:55:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz60yDE8CqqnfhtyZAwcCq321huiCWi8oYJjUKDlxJgio5JFXjNfwf7KDfIvbgiMBZMNJLb2g== X-Received: by 2002:a5d:6488:0:b0:203:b628:70d2 with SMTP id o8-20020a5d6488000000b00203b62870d2mr668507wri.83.1647449722422; Wed, 16 Mar 2022 09:55:22 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-173-39.claranet.co.uk. [80.168.173.39]) by smtp.gmail.com with ESMTPSA id v10-20020a056000144a00b00203df06cf9bsm1998964wrx.106.2022.03.16.09.55.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 09:55:21 -0700 (PDT) Message-ID: <941f3fdc-bc52-afc9-9f70-69d25a236bc1@redhat.com> Date: Wed, 16 Mar 2022 16:55:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 To: Jan Beulich , Binutils References: From: Nick Clifton Subject: Re: [PATCH] gas: retain whitespace between strings In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 16:55:26 -0000 Hi Jan, > Change the scrubber to retain such whitespace, by making the processing > of strings more similar to that of symbols. And indeed this appears to > make sense when taking into account that for quite a while gas has been > supporting quoted symbol names. OK, that makes sense. > Taking a more general view, however, the change doesn't go quite far > enough. There are further cases where significant whitespace is removed > by the scrubber. The new testcase enumerates a few in its ".if 0" > section. I'm afraid the only way that I see to deal with this would be > to significantly simplify the scrubber, such that it wouldn't do much > more than collapse sequences of unquoted whitespace into a single blank. > To be honest problems in this area aren't really surprising when seeing > that there's hardly any checking of .macro use throughout the testsuite > (and in particular in the [relatively] generic tests under all/). Plus assembler macro syntax has never been that well specified. > Partly RFC: While I did test this for x86, I didn't get around yet to > run a much wider set of tests. I ran my regression tester with the patch applied and nothing turned up, so I am happy to approve the patch. One thing though - I think that it would be a good idea to extend the documentation to cover this behaviour. I do not mind if you do that as a separate patch, or just an extension to this one, but I think that it should be done. Cheers Nick