From: Richard Henderson <richard.henderson@linaro.org>
To: Stafford Horne <shorne@gmail.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Openrisc <openrisc@lists.librecores.org>,
GNU Binutils <binutils@sourceware.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: Maybe another or1k bug
Date: Wed, 7 Jul 2021 14:25:39 -0700 [thread overview]
Message-ID: <942dec94-e7e6-33d6-84e6-715e5e368c98@linaro.org> (raw)
In-Reply-To: <YOYXPQENdaFWobWO@antec>
On 7/7/21 2:06 PM, Stafford Horne wrote:
> +CC Richards other account
>
> Hi Richard,
>
> I Cced this to you twiddle.net account you on this one originally. Do you recall
> why we added the below check in or1k bfd? It seems to be overly restrictive and
> causing some issues below.
>
> case R_OR1K_INSN_REL_26:
> if (bfd_link_pic (info) && !SYMBOL_REFERENCES_LOCAL (info, h))
> ERROR
...
>> 4. The symbols are from `readelf -s`:
>>
>> 221: 00008ce4 716 FUNC GLOBAL PROTECTED 24 alSourcePausev
>> 222: 00008fb0 36 FUNC GLOBAL PROTECTED 24 alSourcePause
>> 223: 00008fd4 784 FUNC GLOBAL PROTECTED 24 alSourceStopv
>> 224: 000092e4 36 FUNC GLOBAL PROTECTED 24 alSourceStop
>> 225: 00009308 720 FUNC GLOBAL PROTECTED 24 alSourceRewindv
>> 226: 000095d8 36 FUNC GLOBAL PROTECTED 24 alSourceRewind
Ah, STV_PROTECTED. Unusual.
It looks like this should be SYMBOL_CALLS_LOCAL. The only difference from
SYMBOL_REFERENCES_LOCAL is versus protected symbols.
r~
next prev parent reply other threads:[~2021-07-07 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dbcce22d-b288-2451-4a8d-681f802c6f49@benettiengineering.com>
[not found] ` <CAAfxs77Y1qOzex=Bkn5c_4Zxt6nzZP2cpG6qJ85eXnrAm18FgA@mail.gmail.com>
[not found] ` <6bc67759-18c2-bca5-bdb2-c637e873b8ab@benettiengineering.com>
2021-06-17 23:41 ` Stafford Horne
2021-07-07 21:06 ` Stafford Horne
2021-07-07 21:25 ` Richard Henderson [this message]
2021-07-08 21:44 ` Stafford Horne
2021-07-08 22:57 ` Giulio Benetti
2021-07-11 8:36 ` Giulio Benetti
2021-07-11 13:24 ` Richard Henderson
2021-07-11 13:41 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942dec94-e7e6-33d6-84e6-715e5e368c98@linaro.org \
--to=richard.henderson@linaro.org \
--cc=binutils@sourceware.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=openrisc@lists.librecores.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).