From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by sourceware.org (Postfix) with ESMTPS id 7723A3858407 for ; Thu, 4 Aug 2022 14:08:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7723A3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f45.google.com with SMTP id q30so20989334wra.11 for ; Thu, 04 Aug 2022 07:08:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc; bh=reB1JVoNMpyLIitCMyhl9by3koq0P5PvOj2f5tBg5PA=; b=4scZxBytyi4deH0vMWHMy6FZgEyyhtjMfZR2nN9bXmyjmw3G8PBj3SMlqtDP1/rOfV tQLr/GT1elOsgea79uL3EFBHgJOC0//xr4zr+WTOivLZvSqiRLM9iBmkmAZacsUYF7Aq OI1Ed+umLWFi/+2sVxZ1j8DyrgT4RF2do9SPktQCIua8KtfgRnH7SGRtYTsarRUs7582 SbLcVi8RYh6brWL9uvJiwat86GTASae08CHmo9arjPMjkpJ/pXnLrlTuD5p2BgHDdJP3 jsl3UtS9gN+f043U+rrqVWCGa1nae6mIKSTCvl2LJADemD1mO4f1s+pPgFglRP2/meb7 YtUQ== X-Gm-Message-State: ACgBeo1S1qILbEyVQDg321JSDjiKNAsEd4odClRydboTWBzmc3S6zvxR PYnkP5Jxs5aiMI7xghwteadJeU000l00rQ== X-Google-Smtp-Source: AA6agR64OTRowFEEQiJq+RkPdonWDJt2dHlsdc1HJ6QoVU7PLo2+LwM2+6AyeaXMWto4pa1Iom1Udg== X-Received: by 2002:a5d:620b:0:b0:21e:5b97:c826 with SMTP id y11-20020a5d620b000000b0021e5b97c826mr1547714wru.600.1659622096807; Thu, 04 Aug 2022 07:08:16 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id d14-20020adfe84e000000b0021badf3cb26sm1576473wrn.63.2022.08.04.07.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Aug 2022 07:08:15 -0700 (PDT) Message-ID: <9440a3c533026a5c9ba4b29430d9fcc8c6e2d1e7.camel@debian.org> Subject: Re: [PATCH v2] gold: add --package-metadata From: Luca Boccassi To: Binutils Date: Thu, 04 Aug 2022 15:08:14 +0100 In-Reply-To: References: <20220726192216.1751042-1-luca.boccassi@gmail.com> <20220729222956.79836-1-luca.boccassi@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-/MkcWV5sTGEm1AsTRcUg" User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2022 14:08:20 -0000 --=-/MkcWV5sTGEm1AsTRcUg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2022-08-02 at 11:50 +0100, Luca Boccassi wrote: > On Fri, 29 Jul 2022 at 23:29, wrote: > >=20 > > From: Luca Boccassi > >=20 > > Following the same format as the implementation in ld: > > 9e2bb0cb5e74aed4158f08495534922d7108f928 > >=20 > > Generate a .note.package FDO package metadata ELF note, following > > the spec: https://systemd.io/ELF_PACKAGE_METADATA/ > >=20 > > If the jansson library is available at build time (and it is explicitly > > enabled), link ld to it, and use it to validate that the input is > > correct JSON, to avoid writing garbage to the file. The > > configure option --enable-jansson has to be used to explicitly enable > > it (error out when not found). This allows bootstrappers (or others who > > are not interested) to seamlessly skip it without issues. > > --- > > v2: apply fixes from review >=20 > Hello Cary, >=20 > Anything else you'd like me to change here? Thanks! CC'ing Ian on suggestion from Nick. Would be great if a maintainer could have a look and let me know if we need more changes. Meanwhile, Fedora has backported this patch: https://src.fedoraproject.org/rpms/binutils/c/9ee9ffc894cc632b54d862d6213e2= d8fcb8db829?branch=3Drawhide --=20 Kind regards, Luca Boccassi --=-/MkcWV5sTGEm1AsTRcUg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmLr0s4ACgkQKGv37813 JB4LMxAAor1HYneb0sRE/bOl97pduUO5TiYQtKkD6dZQMtHxbv7GW5b9mBvt8aiO kyifd3ewTNZJH5opyGwoc2P57jos3GkDYoNA5mYDL4/KGJQSR/d4zDofAXSnZQKF Zg4y5zLzRA2OHu6tLdgysn4byUlRuYFrdoA1Tr4DWCSkqpR/hOAV7obKegA18TaZ a/m2NVccj8/OmhiGlCX545pO6APICt1TFQdgCgaPEwNmAUcd+Sz4rka0tlGkZH2D i0DwOTDoNvvQO379S7iB2h86CHtGBnp6uaOyHnPOL03llgl2CVwoFhPe1Nbi3o+l NfHDZRKSYLNPlIGcpFVqVhwmGT64TyMSoWZdhBLySAtTfimUhMeyE1iq3lQyvml8 nRQxMP0zmiE2/AJxR12bMovlYiJu1ZMG1QXlo8pN9cR5+KoO6me/yj9CznlBHfxS 4Ncg1xuYgx87/G7whjRuaFf3vbDb23H1KbGMjmeWANWxkareY+y5s+Q4YRXW0r2G 0TL26F0ELvCFYuFKWfe1ST0eJ/T0iymOPx6t42mVxIlIe0mG5hDYUK53OpsWi0Mj HjTYLz3R6S25hstZIFv3zZQybeOOs7UmOLloros0Kktli4B0H30m25t/DKiaQqNp tyxEX3fTyAShgy/4Kw6bN6StZwcVjwXES9kCHyH4kHn+rNNgPQQ= =a7+I -----END PGP SIGNATURE----- --=-/MkcWV5sTGEm1AsTRcUg--