From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A5E693858402 for ; Fri, 5 Jan 2024 10:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5E693858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A5E693858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704452259; cv=none; b=Ss1u14GDimZG7lZOxcC70r/IXmiitPvaUCtG88bQCLOmfG6ZgLmuE9PyLYO0GnqjxIyLMlX+L+Uj58Zxlymd9+BHbcSuIkQFzBFPQjUqIb3JT6gECbDtFwudWE9RzcfXFmPlFwuAsNq/HNeMSt3fI/3KGrwPc4uD+uTk+ToDFzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704452259; c=relaxed/simple; bh=my6CDPkn4r64VXcs8xnxo+1o8BJXkfPD6ohGM0Qua9o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=CGwwBVCq/bEcc+k03dm75+dAJzcQNey0F9DRgqibwHmmE67YEo/SrVlI3De+/l+Wx6pJj7+In9mHsgWsoUTBno4XVGLzRpZI4JUQFGUtuA9Tfb3fm52Hmc7JZ/3djTBNgJWuUHvqq4PfrCE43Nqcbvmu99yKO3UrkB4fJYojZw8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704452257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GP/bBlpqfdsqaYAz3fx5nBOzWLUoYEy8sD2e52E9eEY=; b=cApLBzE/71nDNWFz5Kk2tE3SZPDOHT0wnY8AQnRzw3PIFAPGPIVWIk7Ucsdjm3ei4zz0w+ KFivHWP5fC1uyvEMh72U5nP4DFAUAoUS36c1A35j1mafbuNpVAnfnY4o2Sl1hPMFCtculw cBHn6phvzu/ra7NLkTqO4Zb3N9T9rlA= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-5VDLk-VLOfSbqD2Zfrb2NQ-1; Fri, 05 Jan 2024 05:57:31 -0500 X-MC-Unique: 5VDLk-VLOfSbqD2Zfrb2NQ-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4279625273cso16849591cf.1 for ; Fri, 05 Jan 2024 02:57:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704452250; x=1705057050; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GP/bBlpqfdsqaYAz3fx5nBOzWLUoYEy8sD2e52E9eEY=; b=ukkkUShLZ8DbWyPtk3WTvmzHkbOAF4HhCkEUwHPWfH8VISWk4I+FVNCVxl03gjqJIo HW21jBPpABMah8OB16wanPWtqKO0aQfhHkyAz2YOo3IC2GGUvWVO/kB38hW0I/UjzS1L p/BAME6huF22zdRYTs5BvpmKtNSnRGm5mR3CNKe3fDoODU2ikhQEmkrHr3uoaenRJcMS emQ19SYmHH7GFjXqXHnB9K/KH8zEa6eyUHt+oJwI5oR2qV/ogp33rYiD7Xnh+XAfN0i6 SfWhxFETqGAI8aiE1wHSq08SUeRRfOw1bT3I3EJrR4OkPSDpGFvWGt+5cPQIwaFB2aCW lDaA== X-Gm-Message-State: AOJu0YxQamsRbPR+X3m7eZFwaaNC3Tg5psyca3FI65EplmDldxkwsTR8 f4Dirspix/3NL0sIHouz0XJ0imjwBypskG6aUC30O+EvJYFMGveAIhj8XZdDLN0JAo5rVOMftzf EI3osdpBsEiL5FFXmsEhM+Y8nTCboxSTe2w== X-Received: by 2002:a05:622a:104c:b0:428:2404:c658 with SMTP id f12-20020a05622a104c00b004282404c658mr2318391qte.119.1704452249828; Fri, 05 Jan 2024 02:57:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIYIlAgPgDohm+Jt0MoZI6T5kExYPGmswMIp3hnHPszNeSOHg6IjuHd6n4dlVzqzWbMnVakw== X-Received: by 2002:a05:622a:104c:b0:428:2404:c658 with SMTP id f12-20020a05622a104c00b004282404c658mr2318387qte.119.1704452249590; Fri, 05 Jan 2024 02:57:29 -0800 (PST) Received: from [192.168.1.11] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id ca26-20020a05622a1f1a00b004260b65b4f7sm611834qtb.97.2024.01.05.02.57.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 02:57:29 -0800 (PST) Message-ID: <94d17c8e-3ba9-4a74-8c02-f499ca2d871d@redhat.com> Date: Fri, 5 Jan 2024 10:57:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [BFD, LD] aarch64: Add support for GCS in AArch64 linker. To: Srinath Parvathaneni , binutils@sourceware.org Cc: Richard Earnshaw References: From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Srinath, > This patch will not be committed to development branch until the Kernel GCS > ABI changes are approved and committed. > > Ok to commit this patch to Arm vendor branch based on binutils-master ? Yes. (Since the branch is ARM specific, you do not really need to check with us first, but the thought is appreciated). Looking over the patch I did see one thing which niggled: + else if (strncmp (optarg, "experimental-gcs-report", 23) == 0) + { + if (strlen (optarg) == 23 || strcmp (optarg + 23, "=none") == 0) + gcs_report = GCS_NONE; + else if (strcmp (optarg + 23, "=warning") == 0) + gcs_report = GCS_WARN; + else if (strcmp (optarg + 23, "=error") == 0) + gcs_report = GCS_ERROR; + else + einfo (_("%P: error: unrecognized: `%s'\''\n"), optarg); + } + else if (strncmp (optarg, "experimental-gcs", 16) == 0) + { + if (strlen (optarg) == 16 || strcmp (optarg + 16, "=always") == 0) + gcs_type = GCS_ALWAYS; + else if (strcmp (optarg + 16, "=never") == 0) + gcs_type = GCS_NEVER; + else if (strcmp (optarg + 16, "=implicit") == 0) + gcs_type = GCS_IMPLICIT; + else + einfo (_("%P: error: unrecognized: `%s'\''\n"), optarg); + } I do not like the use of magic numbers (23 and 16 in the fragment above). Whilst it is fairly obvious where they come from, it is entirely possible that a future coder might change one of the strings and not change (all of) the places where the string's length is used. So instead I would suggest using constants instead, eg: static const char * egr = "experimental-gcs-report"; const int egr_len = strlen (egr); else if (strncmp (optarg, egr, egr_len) == 0) { if (strlen (optarg) == egr_len || strcmp (optarg + egr_len, "=none") == 0) gcs_report = GCS_NONE; else if (strcmp (optarg + egr_len, "=warning") == 0) gcs_report = GCS_WARN; else if (strcmp (optarg + egr_len, "=error") == 0) gcs_report = GCS_ERROR; else einfo (_("%P: error: unrecognized: `%s'\''\n"), optarg); } Cheers Nick