From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7B2623858C66 for ; Wed, 19 Jul 2023 10:53:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B2623858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689764019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AgTAK1mlMlTDuE4ETdx9+ucJakbB+RHgQasifSZyc5M=; b=ac45WnxB8us6ykjkNkTM2FNF07SiNsPkM7tnl4wLTXnmQm99fo6UtAdKLdWSKRQlo1ZJbY 347wJK3e5Dkt3RgYyFuxck1P3GzW99FM8pIsTBZQzBLYfUy5874CfGXUms+GqZnse8w3mO Pxu0mQVmqLC83oWSK1NDyyiXxNX+m0M= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-FmR8GyCYOou-Pzxcz_w7mA-1; Wed, 19 Jul 2023 06:53:38 -0400 X-MC-Unique: FmR8GyCYOou-Pzxcz_w7mA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-635ed44d2afso49536396d6.2 for ; Wed, 19 Jul 2023 03:53:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689764017; x=1690368817; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AgTAK1mlMlTDuE4ETdx9+ucJakbB+RHgQasifSZyc5M=; b=OPtZZwM6gdraLVI3zfDhqHh1wQmvhbEJ/ZkPMjOj1TXzdp/KCwNVBC5TgpbuR4zCxJ 3Dc97zhfXZrf7DkvqyKaA1zUkmvLc7N0BFSGFMeSCCB4XnBjIr7dEj6T92w8MUXbcJ8D fqvOYKNLKdLbror5XzaTdBWnorejYIu6wHtloa4HXVZIkJXXIlcJjSdwwJEYboyL7Ulb aYe7p/s+83ZQz6xaLI8J516y5YSaR1JBjtbeQ7688oC3ovjBxHXw15F13D3SwbPu/JXK pQiKcH3eyKdSO280RR9FCz9wqUTY3fqK5Nxjd7bfe4xJZFK3ZAbO8y/h4NUGgViIhf9R Ql8A== X-Gm-Message-State: ABy/qLa6xDZ5aDk5KDE8dU+Kx1WBdmV1UrMXItkC7uycvqsxqou59Pyj HM2Gm3TLxCGFr2ad3hUkK12zINQO0TADHDudf7ZstaPqcLFWa2QBSfSjLSwyiV2sVAE1j0X4ocG bBJL/vQQIrpQd+LjIx0SWapqfrA== X-Received: by 2002:a0c:cc84:0:b0:634:f124:e5fe with SMTP id f4-20020a0ccc84000000b00634f124e5femr14312385qvl.52.1689764017531; Wed, 19 Jul 2023 03:53:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlHHlIQFvWTUB5cl4IYWlglmaFExb9tBuw3/TKDydXWp2+I44/KznOWu2gVh/3ldOB9zEPvjMA== X-Received: by 2002:a0c:cc84:0:b0:634:f124:e5fe with SMTP id f4-20020a0ccc84000000b00634f124e5femr14312379qvl.52.1689764017289; Wed, 19 Jul 2023 03:53:37 -0700 (PDT) Received: from [192.168.1.7] (adsl-2-solo-172-78.claranet.co.uk. [80.168.172.78]) by smtp.gmail.com with ESMTPSA id c3-20020ae9e203000000b00767cf270628sm1162541qkc.131.2023.07.19.03.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 03:53:36 -0700 (PDT) Message-ID: <9519f902-a406-7b1b-76b6-20800f16af7d@redhat.com> Date: Wed, 19 Jul 2023 11:53:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Julian Waters , binutils@sourceware.org References: From: Nick Clifton Subject: Re: [PATCH] SEH: Reimplement the .seh_scope directive In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Julian, > Anyone? Some reviews would help, maybe Nick or Alan? Sorry for the delay in reviewing your patch. Unfortunately there are a few problems: 0. Do you have an FSF Copyright assignment for contributions to the GNU Binutils project. Or are you willing to submit the patch under the terms of a Developer's Certificate of Origin ? 1. The patch does not compile: In file included from gas/config/obj-coff.c:57: gas/config/obj-coff-seh.c: In function 'obj_coff_seh_scope': gas/config/obj-coff-seh.c:406:29: error: comparison between pointer and integer [-Werror] 406 | if (*input_line_pointer == NULL || *input_line_pointer == '\n') { | ^^ 2. The code does not check to see if more than 4 arguments have been supplied to the .seh_scope directive. 3. There ought to be some description of the .seh_scope directive in the assembler's documentation. (Although it appears that none of the directives are documented, which is naughty). If your patch were to add some then this might encourage others to extend the coverage to the other directives. 4. There are various (minor) formatting issues that should be fixed such as the indentation, unnecessary blank lines, long lines and so on. Please have a look at the GNU Coding Standards for more information: https://www.gnu.org/prep/standards/ Cheers Nick