From: Jean-Philippe Bernardy <jeanphilippe.bernardy@gmail.com>
To: binutils@sources.redhat.com
Subject: Re: relocations in gas
Date: Fri, 21 Jan 2005 13:28:00 -0000 [thread overview]
Message-ID: <953e0d2505012105272a786fb5@mail.gmail.com> (raw)
In-Reply-To: <20050119052507.GB1434@bubble.modra.org>
Hello,
Still on the calmrisc16 port, I encountered the problem that gas
adjusted fixups in a mergeable section. This results in incorrect
relocations when merge occurs at link time.
In found this fix:
in write.c, replace
if ((symsec->flags & SEC_MERGE) != 0
&& (fixp->fx_offset != 0 || fixp->fx_subsy != NULL))
continue;
by
if ((symsec->flags & SEC_MERGE) != 0
&& (fixp->fx_offset != 0 || fixp->fx_subsy != NULL ||
fixp->fx_addsy != NULL))
continue;
Effectively taking in account the 'add symbol'. Maybe there is a
better way to handle this?
Cheers,
JP.
next prev parent reply other threads:[~2005-01-21 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 15:48 Jean-Philippe Bernardy
2005-01-19 5:25 ` Alan Modra
2005-01-19 13:28 ` Jean-Philippe Bernardy
2005-01-21 13:28 ` Jean-Philippe Bernardy [this message]
2005-01-21 22:48 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=953e0d2505012105272a786fb5@mail.gmail.com \
--to=jeanphilippe.bernardy@gmail.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).