From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2079.outbound.protection.outlook.com [40.107.20.79]) by sourceware.org (Postfix) with ESMTPS id 0E618385355A for ; Tue, 6 Sep 2022 11:54:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E618385355A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YB2Q92r66o3V4k+rjxUwExusqDPPVU+hpgXmrlpolg9aK3nwznzdvi0LLsA5iblBPcj3d6YVShjGbTedsCbqBZEXqskODeOxPH9xAywhP0tmwUyXM6wZwVqgLHQCG4k1XA9nQ/YxsiqmVj3et6AA56SMXlkFJGGPVIVlGhaq8+8LaLRtwwLBaSnGpciTJ4roPu0ejkbhupFko/N7ESxMNVForAJYg+mAxhMb+IgD1YIfe+WnfAyvtLZS/jvkLsvvOEdQiwlRNO5cMaLEw3YedQcEd4pReVNMZgGOJexatREMihoLPwf3Cy80q4zJOiWdmSv/BwgRxKHnjwFDoiBL5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTcK+NaXYF3mYw7bmDLcPlyIidYMgZ8T+rn/zJTA/JA=; b=GcDrQjP1wJvkEI6sPiAE65fAVhI/S6FPqzIzJiU/ZSZPHo0QMPID8vDKL62U61eGX2zTASUaz76xKGmNFH1hfhcccefsZT3ghCgQMzhzPPCEupwTqlFnXGjIZZiWFirPuQ92g1WYHigu18pgqy1BjZX1NxeL6dFGvjlfhrUr07QvkuzxUgsJk/99vaMm2jK9OsZNi/4IeXPljHCGocKfAJ8a/KPeSUD04KfLEPiSp+WcAi48AIRu1CMAh2gTDSeNCzR0P8gS/R7LHL5cl0nvs8/D6vq/rNEt9fgWQ3bbg6/qaicfCLUZjz9FS5Tl1qo3LEYqYFEuvN6kTEzgHR2mUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dTcK+NaXYF3mYw7bmDLcPlyIidYMgZ8T+rn/zJTA/JA=; b=YvFCNBe6BIYoLQAzegAveY9cyX26Of7ocZ+3PgyAYBVgn5x5BZGeoVJ2XkM2v1BWas3cS4o1LhddnX9ax5mPErU5nnIv8vIRoIi3keVP0SGgAR6dfsNdPPz4llaHUT4J9XeYR+iFgAmx6Sepv3wCHxZ63KH0QkEfkpSfpixS/Dc8ue9/fC/BYKqJUANwjjUHqTOaXdcIwiHw7LJG7wS5z4kgQgG54iTL7byReRCbtTEAFDfpp1Ih6TUMkMbyPddu/7UOigHQhkov2XTx/sIY1wP9OPX00YvfG/PR7sli5szSsrOIjJZRfLjafjJoXDf9iosGzTXUyuqGWhDn4X87aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4423.eurprd04.prod.outlook.com (2603:10a6:20b:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 11:54:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 11:54:11 +0000 Message-ID: <959c6306-60c5-41b7-d22c-18baf3b35ffc@suse.com> Date: Tue, 6 Sep 2022 13:54:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] ld: pe: Improve performance of object file exclude symbol directives Content-Language: en-US To: Nick Clifton Cc: binutils@sourceware.org, =?UTF-8?Q?Martin_Storsj=c3=b6?= References: <20220902105903.2249507-1-martin@martin.st> <174963e9-fa71-b70e-7659-0f534db073f8@redhat.com> <242a402a-57be-0738-d7b8-c19e1a631bb7@suse.com> <2568a388-02a9-4beb-f20b-e2493cda4a64@redhat.com> From: Jan Beulich In-Reply-To: <2568a388-02a9-4beb-f20b-e2493cda4a64@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0122.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ca3e1dd-4bc1-4b87-69eb-08da8ffe8302 X-MS-TrafficTypeDiagnostic: AM6PR04MB4423:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gIwSCeGDzVHKB0cGJZXjpepSdk6ByXgJ7wbWRkzjFfJvXSeR4r38Cf5+sLXOGPuYjL+gv2thKcskrC/yw5oo0+mJPsZk521O6os5c88nTby68tm7p9kca2rZeWJ6PgbzRJ0HKlMgwGz+Q+P4r5i5mzUjfmR8+gKPEu0lZZFKch4ADIKcPTZKy5ODjOLuy60XsqDwdnv9H15ZePoqj6xCTC95++x8/JJj8/lLS7i5gHnjK7xIyKYkDxO9gkiZODxA6O2ccyi73EcM7r1WIBW7nSvuIqJdQpsO5gsi/tzOiAFFiVUjhMLHKsPclaGBDHk2UbNlpVlYPqT+FkDFCHl4wdDrhV+NgCGYE2N7QKs8fH+t7Yd98KVjewo4a0VRaA6ZnfpstWyqu7y1I50/9K337GvWFVLekG8Zd7t8mJFmrjZ5dSYgV6sVr7ssaY3cwZubIOc6m6zHKLcZH/QiSxa4bYZR9wADTW450eJMgnqAJrCuGl4Bd676VnTZeWVooD8aH3U5g3oJu3cXb+9udmPUM4g1XMLqwCzBirhw96nygm9iUAoQdAIy14r6D928aC+/F4MV1YXIY/qP0s4lyvtEIlw6ygsElmprLP81eROL1/wYvIN2IY9zHxWOzcwrSCdXoWtpoX+C/WEcG3ljPHOAeEUkhmr3enZRCJBuS4DRolOF69SOFjcuO3gpAbWOsUy7fmnrNPmlrAYErNe4sMMLyQ4CcaKAcW+Uz6BZNFbrbWttSY+pC1T0yfatfOdP1jZJs+KzjUhwH84OT/2POvTINEavIVOIS4YwrPffOuk4oes= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(366004)(376002)(346002)(39860400002)(38100700002)(83380400001)(31686004)(36756003)(66946007)(6486002)(8676002)(66476007)(4326008)(316002)(66556008)(6916009)(478600001)(5660300002)(41300700001)(31696002)(2616005)(8936002)(186003)(26005)(86362001)(53546011)(2906002)(6506007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3NNTDBuNk1iMDF1N3lRaFlTbUVtSG9vdm9NbWlvYTdURkxSb3BzQ2JIRTNE?= =?utf-8?B?ckdiSms1N1dFaER1WWlRYzlRUGo1cXRwMSs3VVFEbitQRnFpc1g1eURDVjJ5?= =?utf-8?B?RHRWdUF5TG5pcDBlK05WWUdMaHJueGsvUnpNU2tPRStLa2EvakVpTE5maW55?= =?utf-8?B?Ky9UeXlicnV3UWl1K2NKeHMyYk9neVZQeWxJdzA3WXhrSmJIa3g3YVJnUHlS?= =?utf-8?B?Q01hMjAwd2g1cFpNRkY3TDJKWjE5Q016ajUwdEptc3M4OE9pTkkzeU5VNEt4?= =?utf-8?B?cU9EV3Q3c2hVK3AxVDF0N2h0c1p1TXlLK0xaMm9aN29nRDJUOXFBMkRCTzBX?= =?utf-8?B?M0Q3Tkd5dGFiM0M4L0NjN2FwZFhtZ3Y5aE9BRmpKZlVhdW1EQ01uNkl3MW1U?= =?utf-8?B?aU85b3BBVzBFZmV2MzRkbkZHTzEyczR6YTBjTlBYWHVtV2F6OExuYXF5elhk?= =?utf-8?B?RG9wZFQyREZXWmROQW1QWmprRTVhbTFheWhzSHNmR0ZBRXd5NmxEY1YyTHd1?= =?utf-8?B?TjFTQXlhTjhENHlKWTZwdjY5VGpWdG1ycjdpTDdxM3hJM2t6ajQzdmNPNGRp?= =?utf-8?B?M0EzL1ljM3RZNTQyeUlYNXllWUQ2cUVyZmpqYS9HeUVlRVplSTRhVy85eUNE?= =?utf-8?B?MFdKUHlYamJGc1lSYVV3bktsYlhobXNhdzN3QnJqU1FHUDZnbUVZcTAwdVZY?= =?utf-8?B?NWUzM1hqVXppc2pmR2V3UlhlOER4YVh2dTFueGdWRXZjeXlrUHpBNUxDbThh?= =?utf-8?B?OWFNdzh0eVJtUmwxYjI1Z2hWWDNoRUFhSjJSZWFzY0FuVlZXVzVOdWcxZk55?= =?utf-8?B?VUhyRWhUa0lhbjg5TGtmN2w1cjZoV01iWHVXWHZHYk9VOFdYOHJudjA1NnFn?= =?utf-8?B?ZXdWY0tZZlU1SWlpaGhEWTdlVld2d1FIbnJRYTdFaFc3TWdZK0xzcUJ6ckFT?= =?utf-8?B?QURSV3VHUHJUYXpHMWhzUFRvWXFrdXJMb0FUTmpYNm1tWWZ1YWN4NVd2ZU1n?= =?utf-8?B?MkVxRkpud05keWFmUU1XU0VEcjRzMUhHOVk0am9aTDBFdVY5cjVFWW5qZE1i?= =?utf-8?B?ZTRYNXNhTEVaalBuODVCYTBSU3BSL2crYklqbWZEMlRIOGVFTjBYbURqbUQ1?= =?utf-8?B?bnFxTk5ZaFNpYTBIVlg3UWtBT3ErUlo0SU1RRzdhRGhoSmkvdDZsdkZnR09z?= =?utf-8?B?Y1dHQisxV013bXprQ3h0R1NXekczNGJ1SnRxOVU1Y0tvWDlWU256UFAvaVVk?= =?utf-8?B?ZUd3ZlJSNW1lQ2VOWUFLU0pPV3VYOHZPWklhSTJtRWJvNy9nWXVzWHJRVGRB?= =?utf-8?B?ZklES3kyWHFpNnJkelIvcmRkTGI5OFIwRzNidFI4amZXZFg5YmpIREJmM1dt?= =?utf-8?B?UDFQTmNWbUJhMWQ5bVQya2J6aURSVFVCR0VKR1FTL2x0MGphZUd2dHJ6TGFU?= =?utf-8?B?OXorcGVvb3VZVmtGZDBmb1VFbG4xM01PNG5wMStTaEk1czgxaU1PbkZlY2p3?= =?utf-8?B?QkxXUSs2VWJMbzdoSzFCS0gyTVNYb3ptRlJoamlkMEdrUkdGVkxQWmJ3K3dO?= =?utf-8?B?aWNCUUIvTnNkekV6S3oya0pZR29vS1hnVmdCeDM3UWZkMW5mV0o5c29tYUhx?= =?utf-8?B?a25ITC9jR3VpUTdnSmpCL3NESDVLRHl5VmRVTEdnWG9qNkR3czdKVEZIQml2?= =?utf-8?B?eWV3a3J1Ym9kVHpsOTJGRCtHckYwUnpjdGg3d2RVLzdiTW1YV3lSdW9jbm9Z?= =?utf-8?B?Zm9zaDlJelZaQ3hpUVF2Y0Y3SkNSMW44U0RsaXRrVkYvMHJXSDZhS0c0alNh?= =?utf-8?B?LzdscmJKdVFYQnM1RkQ1ZUsycFNWUkcxTmxlOFBOd3RKY1JhcW9nejBFR2pU?= =?utf-8?B?OWpPaFpRM29ESVRvdjJ3dXBFS1hXaUlwcjEya1U1eVJrbHVGeFY1TlU2TDlL?= =?utf-8?B?Wk1rS1JpQnlEcHk0Tjh3VlN2dnVQcUJ5a0NySDRsMXgwclFpeVc4RE1ncDdU?= =?utf-8?B?S2oyQzNZQzdsR3V6OHdrWDNIVGRHUDdhMUwyc1pLYTRNbFpBTjR4Mk11ZlM1?= =?utf-8?B?WXpIYlRuRVJiSnBEQnpiUHNNSFJFNU1PbDB3aDJyaXZQdjQ3UnR5bVJmUmhl?= =?utf-8?Q?uRtSWv/VtrZwJfEnE4oY4VmfG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca3e1dd-4bc1-4b87-69eb-08da8ffe8302 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 11:54:11.0816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T/g54vBUeBHTrwBgBRb1nrF36L+3K6khWIzdDyWabUBslkFFYrdn/atRMKiFdCs6+ECfCbuNNvkBhAHr0l1F0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4423 X-Spam-Status: No, score=-3031.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.09.2022 13:42, Nick Clifton wrote: >> On 05.09.2022 14:54, Nick Clifton via Binutils wrote: >>>> + max_exclude_symbols = ROUND_UP(fdef->num_exclude_symbols + 1, 32); >>> >>> Given that the point of this patch is to improve performance when there >>> are a large number of excluded symbols, incrementing the array by 32 slots >>> at a time seems counter intuitive. I would suggest a bigger number, eg 1024 >>> or 10240. >> >> Perhaps double the value, thus not overly much impacting the case of there >> being a moderate number of excludes? > > To be honest I have no idea what a "large number of excludes" might look like. > So maybe 32 is actually a sensible increment. Doubling the increment every > time the limit is reached could lead to resource exhaustion issues in extreme > cases, but I doubt if that will ever happen in real life, so that works for me > too. Well, first I was thinking of a hybrid approach - double until reaching 1024, then increment further by 1024. But then this seemed to be going a little too far, so I suggested the simpler alternative. Thoughts? Jan