From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 524343858CDA for ; Wed, 6 Dec 2023 06:22:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 524343858CDA Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 524343858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701843774; cv=none; b=TDfZTOeOrwHD5O5Uzp08BqaiqfCO4L7oOLd46Nt8e0QOn52h7U0B02StbHKm6LrhhD5QRZA+W79gQECjtSjaSVWJDRoCLXh9iLMLMa2jEw26HhbKIpF6zACHjIclIwpry2ydX1cxiuP6yAem9ovwcvy4YdwZS9G2UV5Y2u7jUdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701843774; c=relaxed/simple; bh=4wCfb2Z671aIwXXAfqKEK9N7yPgSD2MwgPF6gKYsEk0=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=rDIKWyVFNR1PQfKZVzXGNRZEQPfCp1EMHj8bYHm2WSgnAqalH1BGZD7jD0ul7QXGowOWhlK6Lqm/vGOkutj90lnXuJig7pPRAwYshA79/cUDmnYWNX38o5UaDNlxlrdNR7u4MgRbR5INmjxDKsuyNKzJHGcoTyCevHlWm3JyuEc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1701843772; bh=4wCfb2Z671aIwXXAfqKEK9N7yPgSD2MwgPF6gKYsEk0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=A6p+pKfQjg1c4rj7guD/Ljda+mqliiqapwg8GIwj0/Gc4mz8kcps9OBmhS2GKSIbl xBEgyIlLMXGSzOOKMGZaNUqtVh1mQ9tQU07oZrhQ1dxAlJgWc7TFI5L1143ABAiJQb GWC4VErycHgQePjLR4s4bQZm8ORRSoyVKhZ++XCI= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384)) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 4E57966ED5; Wed, 6 Dec 2023 01:22:50 -0500 (EST) Message-ID: <961ba515dc02f67c776c1b63811a0b68574b68fb.camel@xry111.site> Subject: Re: [PATCH] LoongArch: Add support for b ".L1" and beq "$t0", "$t1", ".L1" From: Xi Ruoyao To: mengqinggang , WANG Xuerui , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, cailulu@loongson.cn, maskray@google.com Date: Wed, 06 Dec 2023 14:22:48 +0800 In-Reply-To: References: <20231206031724.2330403-1-mengqinggang@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2023-12-06 at 14:16 +0800, Xi Ruoyao wrote: > On Wed, 2023-12-06 at 14:07 +0800, mengqinggang wrote: > > This is a question discovered during the porting of RSEQ system call,= =20 > > and other architectures support this feature. >=20 > The other architectures support quoted symbols, but not quoted register > names. >=20 > On x86_64 if we write >=20 > =C2=A0=C2=A0 movq $1, "%rax" >=20 > It will be explained as "saving 1 into a symbol named %rax", instead of > "loading 1 into the register rax".=C2=A0 I. e. once it's quoted, it will = be > treated as a symbol name instead of register name. So we should just reject beq "$t0", $t1, .L1 because to be consistent with other architectures, this instruction should be explained as "if a symbol named $t0 contains the same value as the register $t1, then jump". But our beq instruction does not support a symbol name as the first operand. OTOH beq $t0, $t1, ".L1" should be accepted. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University