From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 1F0BD3857B89 for ; Wed, 17 Jan 2024 01:20:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F0BD3857B89 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F0BD3857B89 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705454423; cv=pass; b=ZsZmOmq4VUM+JvvaB++MZk9UWel0B4+if/aurWV0js678STs8NjxY9bvbi2fhdY4VWiSl7bNmeTY/utIYWVY8eYwqqJh59YBmYFwXKyS57dlmZIky9lHR7mQHfCGjhxR4y+1am+DAt/BxnK+ZQICAkQwYPEwMyU2qwGbQEZpbTo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705454423; c=relaxed/simple; bh=JwB2lkwhKseGru4a9P2efeHwBy5fMGaoA0/02Aa/ZD0=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=U48X0pf/rabmJvMEydaXkjE8D8EOUcIVyDXlFmhJkiaF3CuVefiIzl/A0Jza42McehU2MFbKyjcfJPKK7a66x53JjwUWqsSYGFwP1mN3NqXiXNFCuO4idqID7758IMzhuxw/Er9Za6VPM1W9XPhec99DzVc/LUIZomazXYG3+s8= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40H1EqHO021709; Wed, 17 Jan 2024 01:20:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=CnuWFiWzbNqhWAfLocnssmQFdz9Ll+btCDN85djCkcQ=; b=NwI7Fysq3p0iAPXIhOtybGEpahbXhU9kO79rUCaBw1YMpBGSZwZYw7h8nW6U2nYx2yv3 KZ2Ia0scxF10eCbuQgeJlGGbf6nLRO3z++N3uk/9JUYkrFodM0W+G+ocigAG5cS/H5DG dhyGDcyAGGoiZDYHZIIsryousMlAibRt0gmPz2KAe5FlDa07EoZ92+1/jH1xPZaQ3ReX dbXXHlauRj9WajbXHD+VxZp6qC6zW58k7PLnz1FZ0MgkbWZEdim+1Epp81sH5CZskdY4 SnYPYNevMFq0BzxkWb6JrQowoFUM9uNmQWRQe0TAb9/VUKFkFIHXCJh2TGmXY4D8ScOT 7g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vkk2u6g1j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jan 2024 01:20:19 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40GNhYDY023191; Wed, 17 Jan 2024 01:20:18 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2041.outbound.protection.outlook.com [104.47.56.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vkgy96r94-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jan 2024 01:20:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DbFa/bq7ykHfaIy6ivYW1zCJbb/yJwxCIj3NxLP4qJWTiosRYjTasghxo7CTC7RKU3REtbvwoK14Qp3OzvT28pKkx088avQhKpa70LEuWkzOWv80XzUtdwmNjzQVRy4S11w64pZCk2xn9US79UrZXYlE6+jfAqmPBmI/4IaRnX46dreF2v8hskNmawlU9q1w04rltLu+SX03K9AHFxh4hlk5A4UZsucVnfMbxqriPyae9gQ124Vv34QXoEHAsM2gh/iISJeXqnAaZcuFMvXYm+ywcSGZz8gTKV2myJeSB6LIeosdUManIJEhGgJUnAr7xt+Yl9Q4OyrMOguFoEGWXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CnuWFiWzbNqhWAfLocnssmQFdz9Ll+btCDN85djCkcQ=; b=kP5RC4kP288RhdiSiQBG5bnEZ7DzMJcggvuOgcryqmGyGezdBhnNFNQEGQCwX4TuoDpkiA3SC1AsHa1UohEOKvP1L9QKLwOlKufxnS82ZHx34+LH9jfhQdJ48t8padSD5XMo8dOFJt842YjDM62YMjhfjtomASK8aYjxuUFGtEBrGiTg4E56bWBbjZpjbYfBY3+ekfxxQV+klQHUjNwFZzjvVlaZn0P9ecqJL0pX2NxFBxO//IJ/7ZwVJd/QOIwUr7O06bUhF1a4UOVGQAD9WUg7PPnKrC4aBiCBujvyprzGuvcKTmv3JK1jPBnsmPXdGYpoPlXyGyYjBIQRlndaGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CnuWFiWzbNqhWAfLocnssmQFdz9Ll+btCDN85djCkcQ=; b=EOufJRtyig+yXgGT9KcqVZPco8/d9t3X49nK0urPQF0FpHNbdABXetafGcz2ku68EXuSx79BABcZWOxaXK3nuP8km/NAt33zCf3XSSQu92J+xusOyc7agHXNhNVTZRlinThPIEZfPTmEEGQFP7POk8sSF4vmRW2mDcBrP1vagk4= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BLAPR10MB5348.namprd10.prod.outlook.com (2603:10b6:208:324::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Wed, 17 Jan 2024 01:20:16 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7181.026; Wed, 17 Jan 2024 01:20:16 +0000 Message-ID: <962e43b8-5eea-4f71-9d36-4f95af6a043c@oracle.com> Date: Tue, 16 Jan 2024 17:20:14 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V4 10/14] gas: synthesize CFI for hand-written asm To: Jan Beulich Cc: binutils@sourceware.org References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103071526.3846985-11-indu.bhagat@oracle.com> <0ecd9240-0700-4072-91d4-ccf9bdb56071@suse.com> <055b92ae-b781-41e8-bd34-4ad68bdc5f6f@suse.com> <78b9f98f-2030-4675-af0a-8f47d195711b@oracle.com> <20b71f7f-7c8b-41fd-a85c-6887cc19e5ff@suse.com> Content-Language: en-US From: Indu Bhagat In-Reply-To: <20b71f7f-7c8b-41fd-a85c-6887cc19e5ff@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0240.namprd04.prod.outlook.com (2603:10b6:303:87::35) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BLAPR10MB5348:EE_ X-MS-Office365-Filtering-Correlation-Id: 12430cba-35ef-43af-1128-08dc16fa7616 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xTu0DGaoHR3+T9p8DOFMvZnQhfyxryLzjk5vbXl3hVvotq7ephNbDrQ5JfF9QMQbydXCC5aOxMIfocQdOK/ZPaTaU4isWrpFrrGAJ0KUfbQfKtgrERhbdxoztU/1hw56lifZ210M6iaV7YZSfpEMIKtpPBXCNiI46bKw1xY8nV2XWpZc/+ErITI9VyFL/F/oPg5Ipvhj4KxhOYa+Mg/6YD2rxWoRWxrKfWKozwKBgp/3Wz+FWaWSaEWBcWmAa/GWi/dKAe36MZgATvoAWsNQr2rzHlN6jldMdEaNpwN0fEbY+lQSqcmzrfnibjxgphse1bEfEvnEHx1y2SfcdhX1sdJXkMGDMCrMQnOoJLs2eY7Qjs4dQdPHZuu5Cizz2vu7lfWQpNGCm4G+LN+Mpb8jfMYsHnA50B8JOyVwcydxYxl1R7CRtuH5qX1tO9bmm8AyWzwyH/i9areWHpZAsjPN+cVR0jvUyKhivBzR8iWdzi2/MWnIPrVTZn5UdOqcF0FjDbDNCBE5xKxNmawTkoPNdQFwytYtqWJHZBuTvSa3TH5ozbHQrJgZUqahL+21O+HK6gsPApplpIweFSlsbuwsR/RXAmhUBWH2pJdvlcRuiko/iuSiEBlw2LdXypGXygZXPRjzrEYlmX8G55av8oOhmA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(39860400002)(366004)(136003)(396003)(346002)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(41300700001)(53546011)(6506007)(478600001)(2616005)(6512007)(38100700002)(66946007)(316002)(66476007)(6486002)(66556008)(6916009)(31696002)(86362001)(36756003)(83380400001)(44832011)(8676002)(8936002)(5660300002)(4326008)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUM0TFN6SDJjbENUMEpEako5K0tRSzRRMHgwMzYwSHVSTUxZTmxOQjdBM1JN?= =?utf-8?B?R1JSR3pPZmhDQ2hXOGZMU0psRHl4QlZOSlBOWEhzWFYrSm5XdEF6SnQ1ZW94?= =?utf-8?B?aUxvbldVUER6ZVFmeEsyNlJQRGl5WEpLRG9TaVNlZDFwTk0zVmZaQWhzNXdZ?= =?utf-8?B?RnAzK2xZcnJ2clhXVHhIbW5pTVcxcVpUa0h1TURpYWxOc0VxcWJ1UHh5RVAz?= =?utf-8?B?VVNDV2ovdG90c3lTUUtYU0hXeGw5YW93aVFwK3hKSUltN3MrSlczNUFuTWF0?= =?utf-8?B?VDA4aEFWV3RmNFBOeTQ4dHBVSEh1cnpIRkRUWGNUZ1JjdmhTNzltc0VZVGhz?= =?utf-8?B?ZWhPM0N1TXI2TmF3b1crOVdJaXZJWTI5MjZndDJ1eDVOTEpseHR6cjRNMnF0?= =?utf-8?B?UHVkVGZQbXJ2ZWgyaCtFZUVWalBsUjJkTzJRQWVvdWl5OUs3VW9BczBkY0pM?= =?utf-8?B?aEpmRlZ1UVNrZnpFQUUzYlhyeTkzeU4xa2t6TVROS21pQlZKWFRNYTFHNG5i?= =?utf-8?B?SGp3VHhrY05QdlB5SG1UQ3luM2V0RFBkT3gvc0IrQldvSVlYZUpLRnFaaWQ3?= =?utf-8?B?MXc2ZmhhcVFuUGJTVU8yc3JaUnlSazZJT2NiVWh6S0paQyswY2trL2ZXSkxn?= =?utf-8?B?L1BhbERQeUdDL3E4ck9oLy9odFBRb1F2TUZrWWF1aGR5eTBWM1B4OVEzQ1F3?= =?utf-8?B?Q2YvK1d4UEFrVE1kUkdaSHgvUFpGOTVPRFVRUWJSVjE2N3VQNXJmd215OHMv?= =?utf-8?B?N0hQVVpsS2h5YW53RXFNNC9CTXBXM2psKzYvOEdYUTVKQ2NMejBZQWYrMSt2?= =?utf-8?B?aVlnb0k4T0lJZys2cU9MZ2ZITUhPa3BJUmlQbGU0T05KazN1c3orOTFJK3FD?= =?utf-8?B?KzQ3UjBwaXZHRG45NUZzdkVZbStpb1VBQW9FNUlJc3o5S3pzQU1DbmkxRzkr?= =?utf-8?B?dUQwUm5ZWFlJQ3BFbjFDQlJjd2UzQXpRMXVUS2w0M09qQTZoNjZCcFlYWDB5?= =?utf-8?B?cXd2bER0WXhxdFAwdFlRZ2R0bk9NS0w2SXF6bzBncVRHRm5nS3FQdHd6NzZM?= =?utf-8?B?Nm9VNXBRNFpWL1JFdnpHaDdNcXkvT2VWRXNxNWJLY3J2VWdyVHRSeStTZUVx?= =?utf-8?B?NzdGcDliaFpCaDRUSTM2VHNLRkppZHdjVHIyNGFlYjArNk4zWUpDNFFwYjRO?= =?utf-8?B?ajNTZ2ZLenhVbmFJQ28zT2x2dERyc0psTk1saUlhc2lDL0ducjlXM29hcjNH?= =?utf-8?B?MzFEeFFFMllUaU9vT3B3cnR4VXRJbStubTZIZm5hUkRBU3ZBS3dmMEorNnc3?= =?utf-8?B?ZnU0cTRPcStLdmFaWGFYdkZ0V3ZlRGphUHMwUW1MUUU1bmJxaExEaE9scEpi?= =?utf-8?B?VHd2VFFsK1lXZDhKY25Md1VhMWY4QnlYeXlNdk5rTVNabGtwQ0FSZ20rbEh1?= =?utf-8?B?eFZMU1Z1cEc3NXJZNFYva2dmdG11Q2xZR2tuSVdyck5YbDRLdzNyRkR0NWFa?= =?utf-8?B?eGQrY3RPZTEzWU1qTU9Fa2gwV0Z2T3VTaFZFVVRPUnRobXRoMmF6NVNFMGhU?= =?utf-8?B?SC9rNFNSM3BLL0ZITHYxQ2xuMGgwS1FQWW5WSmNtakdrbGVwQkR4dGtqOGo5?= =?utf-8?B?dzZzdEhXcW9qREdTdjhXMlB0SVdiczdsQW9SRTFrbjdraGc1b3I2dU9OaWhz?= =?utf-8?B?ejU1NUZmWVgzSFpHc3BpV1ppNWM3cmN0QU1CQ0lKZmtBeHZaSkZwRjh2RmE2?= =?utf-8?B?YjJucjlMRXJKRGNFMHJKNHVXRVFhWUUyeExtbGhldmdGOEc3T0RtU1htS29i?= =?utf-8?B?MTdhcXF1YXIrazh3TzFMdUt5SGc0R3RnZmJpRTExbVY4OHllby9Qc1Q5Rkt2?= =?utf-8?B?QmhGUUdhZjhsYXRpYTBWTkFzMTExQU9uOXQrYzlzNDAxU0UzNm1NSVJtYW5z?= =?utf-8?B?U0JZK1dFaWpuQTFnVG5HdUZRcnV2eG8xdFdFNllLTFdkVFk2RGJCMkVHZ0R3?= =?utf-8?B?VkFvbWorZjF6SGZ4SmlBVys5K050ZTFnNUFxOS9LRkFBUStiWFN6VGlLRWVO?= =?utf-8?B?U1h3ZVIxNlc0Z1ArZDdDV1M5M1dwYXlTa1djbldBN3Qwc0FnVzJyTFJrTnZq?= =?utf-8?B?OFN2WXFKZ3JoT25mRmZ6T2tTQVNtaHJVYVZaaWpQTHJ4Qyt6WFNQTnlUNHFp?= =?utf-8?Q?TJAehtBK1hB8za6XOWQJmFk=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zyFoo1iPol597oYuQF8EvnQiFnnIfyrDTi5+9lu6HUdr/jkKVqusvAmNrLoTLdvnmCTXPr8H9esCsLBQECZWOlUH4twM88mG2U0DVKFysde01nMnI7tUVjZDim0ZuIehiOJ8u0U1/LRaMp5rktdAFMrmtuQuZ7xCeVBENERJFLfUrG4Vj4aZYhZ6JhxA/xIFtRE8tT9InvnhBAsg/ADECb1S5X1ktXgDsJBmZ7CvzliKC7EDO87V+7LPgadInl3cYnDcj6rvXJ//soI/2odzBXyahYQYpU4NgK0iu3OriH7vUIvjqi/YsMhKNbU3DNqjDa/Tmix2CkhnfZCwnkbZheZ9oHRgxtfA0/haVm1NW2KVMYH1X7pUHTrvi73GKbrsEQl2zBFD8YSYuyu3KcbvWM5VzM8L4jt1f3BrHJHundygwzOuEQrjw1L10zdB33X6rTVxq6T8VoTtBMlV1oEp/Q7tDSsVPDBwC4B7SLQ5oYQLe3t8PxG5cVXYsKCCJlCH7i8JugaeaVXrE+nows9xiwY2Bhjpn237pA2VSX8+EUpL2zXUswa19NNZSBHD+ZG+CNpF0ze/7O/15Q5tD0lzRBf2TQR+3qAJatW14SHP1r4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12430cba-35ef-43af-1128-08dc16fa7616 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 01:20:16.2257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GRNHaxLNEi1vnDoV97ceI+HYJUgHaxfn1HqXnwdUWBlS+OUoOXK5JklKhw+xHgPGO337Z/MlqnD4asxenUGhBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5348 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-16_14,2024-01-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 mlxlogscore=863 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401170006 X-Proofpoint-ORIG-GUID: PoMeNcc54qiMXuO-DD4mCijszBV3WC5D X-Proofpoint-GUID: PoMeNcc54qiMXuO-DD4mCijszBV3WC5D X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/10/24 01:44, Jan Beulich wrote: > On 10.01.2024 07:10, Indu Bhagat wrote: >> On 1/9/24 01:30, Jan Beulich wrote: >>> On 08.01.2024 20:33, Indu Bhagat wrote: >>>> On 1/5/24 05:58, Jan Beulich wrote: >>>>> On 03.01.2024 08:15, Indu Bhagat wrote: >>>>>> +/* Check whether a '66H' prefix accompanies the instruction. >>>>> With APX 16-bit operand size isn't necessarily represented by a 66h >>>>> prefix, but perhaps with an "embedded prefix" inside the EVEX one. >>>>> Therefore both the comment and even more so ... >>>>> >>>>>> + The current users of this API are in the handlers for PUSH, POP >>>>>> + instructions. These instructions affect the stack pointer implicitly: the >>>>>> + operand size (16, 32, or 64 bits) determines the amount by which the stack >>>>>> + pointer is decremented (2, 4 or 8). When '66H' prefix is present, the >>>>>> + instruction has a 16-bit operand. */ >>>>>> + >>>>>> +static bool >>>>>> +ginsn_prefix_66H_p (i386_insn insn) >>>>> ... the function name would better not allude to just the legacy >>>>> encoding. Maybe ginsn_opsize_prefix_p()? >>>>> >>>> Isnt 66H_p more readable and easier to follow because that's what the >>>> function is currently checking ? If more scenarios were being handled, >>>> ginsn_opsize_prefix_p () would fit better. >>> Well, as said - with APX you can't get away with just 0x66 prefix checking. >>> That prefix is simply illegal to use with EVEX-encoded insns. >>> >> I am using the following in ginsn_opsize_prefix_p (): >> >> !(i.prefix[REX_PREFIX] & REX_W) && i.prefix[DATA_PREFIX] == 0x66 > That addresses one half of my earlier remarks. Note however that elsewhere > we never check i.prefix[DATA_PREFIX] against being 0x66; we only ever check > for it being zero or non-zero. I'd like this to remain consistent. > > For EVEX-encoded APX insns this isn't going to be sufficient though. See > respective code in process_suffix(): > > /* The DATA PREFIX of EVEX promoted from legacy APX instructions > needs to be adjusted. */ > if (i.tm.opcode_space == SPACE_EVEXMAP4) > { > gas_assert (!i.tm.opcode_modifier.opcodeprefix); > i.tm.opcode_modifier.opcodeprefix = PREFIX_0X66; > } > else if (!add_prefix (prefix)) > return 0; > > So you'll need to also check for that combination, plus take care of > avoiding insns where PREFIX_0X66 alters operation, not operand size > (ADCX being an example). [V5 is now committed. I am continuing to work on some of the discussed pending items from V4.] Thanks. So looks like to correctly check for prefix 66H, one needs to check that: - !(i.prefix[REX_PREFIX] & REX_W) && i.prefix[DATA_PREFIX] - (i.tm.opcode_space == SPACE_EVEXMAP4 && i.tm.opcode_modifier.opcodeprefix == PREFIX_0X66); - selectively handle the specific ops where PREFIX_0x66 alters operation. I tried looking around but haven't found a targetted way to identify such ops. Is there a way ? Alternatively, since x86_ginsn_new () will be called after process_suffix (), I wonder if I can update the code to simply check for i.suffix to be 'w' for reliably detecting the 16-bit ops for all x86 insns. Is the check on suffix correct and reliable ?