From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 353993858D28 for ; Wed, 3 May 2023 17:38:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 353993858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 343Gx8aW017910; Wed, 3 May 2023 17:38:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=Ch1Gr3jPu1c4ACLlISWUw2JtSt1GueVBjAB/CvuPJuE=; b=hvRhfEMqof7/usAhmp+9eQOD6zaeY0iqeb6h/NEbXFmglO4gKOuUtMCo7VopwaOAgl+l u42Mzh9I0GSzm+1BM4aSJlPc5tKHfYr/nVuXMQZE13Q47mroL9QwicxLr2QmLCkIztQF BgP/qbBoLcAWBf8eNDjSE6vfYjObOk4OBBXEtkar1O+K7d+ZdCkq450AMh+326G9ppf4 IsADjRiGeUhdKepVe1gWwhlCyqfsIDzmUxdfISwECGIHD4kjWVU5Lg0PFZYvnoq3uI9c WUAO7d5KxbSHhBv97Rd2Tq/DrqV5KcEoB0YMxjc2k0wB5LXQxcdqakww/L1+d2+/guUR pg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3q8sne8043-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 May 2023 17:38:21 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 343FvjEh020736; Wed, 3 May 2023 17:38:20 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3q8sp7e5bs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 May 2023 17:38:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OP8+QxlGjPgbjHJymWqqLe8soLslr4qWlzjn1NFTrvAofIMFgO/nQ9RbeIDFPN+fOboMIfqepZmYPg+l/fXJ6MZywWgTJN9hIZXWa9UhIrOEI2020YgqEbn3TqfW+Ap6ALmXBIAqj1c/CwWHVS+u1D+zSgfWJnCLgCFhoJ6ilCCqKuH8SQy6GV6kVVqQn5oEAOAAHXewZ6qo27J+1iqCfOLdVhz1Ij0cx11BT9BaUP862UCI6Cn6XLQ7596igJ9CLNrAxgyKgBbFlPjeA0Wf9LleNsKldnR0Op/Ents2fyRIg6LxQ9XZ7XipxyyN4RiCGFrLuow2eW88VzDeQ31aIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ch1Gr3jPu1c4ACLlISWUw2JtSt1GueVBjAB/CvuPJuE=; b=TgGcA+wmKBu0zDub10bY3SFEKdtuty97d0ecx/XI1zromRI6GU9EEQZwRpBeBvpYTQqp2HBojRr1IqDyBC6QJKsA7g4aCK1y5uOXIVUqCP532fO9tvTLiRcpRX0oTJ4jdCS1WmMFqfyeOJXPqI6Ri3Qb//VH9+rWGNyUspmKp7Z8E49zRgDX3c/ZXYWg2ug41C5Wzt+4IvHMGT8B2Bx3lxhhJXZpwDyAq/XON+3Jqt4c+cSichMv4B8fZ4Q206H7zp4NH1e97PjZN1vpHgPAjKMATzl4lL3M13MqJC53AJf6QSeA9zgLVXOIhdtXTLGEswWx0ohsmp40VJhOmTYDgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ch1Gr3jPu1c4ACLlISWUw2JtSt1GueVBjAB/CvuPJuE=; b=Qzc1JRtVRD2GK8aEVEUbFN7DwSaP74LAZphCkYzix/HpGIFnoYpa1EFb5r2sWSuUq/vff2taWXMyfqFO/Oh6vLwLwa8SWtEUzl5iHD+RENkkFCauUlCW9rOGFkSGgQdudndMbVkSuybY9aZQg+VcKPco2zW9R3g4ZZgj//ApXsA= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ2PR10MB7654.namprd10.prod.outlook.com (2603:10b6:a03:53b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 17:37:55 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ff1c:f1fb:8db9:22e2]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ff1c:f1fb:8db9:22e2%6]) with mapi id 15.20.6340.030; Wed, 3 May 2023 17:37:55 +0000 Subject: Re: Missing alignment in SFrame spec To: Florian Weimer Cc: binutils@sourceware.org References: <87ildgbf9g.fsf@oldenburg.str.redhat.com> <2485551a-9608-e4ff-8d4c-bd7974c6c695@oracle.com> <87ildbuv6a.fsf@oldenburg.str.redhat.com> From: Indu Bhagat Message-ID: <971f6491-9d8e-deac-286f-58bf1c9f40e9@oracle.com> Date: Wed, 3 May 2023 10:37:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <87ildbuv6a.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0202.namprd13.prod.outlook.com (2603:10b6:a03:2c3::27) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ2PR10MB7654:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fe2cd08-3b15-476e-f033-08db4bfd20bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oQYFhF9sVr9069TpddAWCswT+BfA0IabHomSwQwCZVdVyPJEiTPLDwecPG3FPrsaoWj1+w8TDvQvwTFLAcFQnxPlQDw4ewrhZespM/6usbH5sGAHoJoP5jR6B7AAbloJxk8BEsIEreUAgNP+Xt5nzc0U6hPyshrCBpg8YTDlsjCIHgkNmIjjfpe1/wj7MLrQsD7hQhLWp7VL4uCt5sNduBU9yDbOdT/7oSwnzUBQZw0x0U9vAqRBAoui049TCzeRlM8eQN0ECNaCgxTg+covAHD6nT6DyX15/kGD/Yx8XlCD9d3nuU/2XahdNDNKny87Qs8k6HmmbiEzSZteIP3OLC+fPjNfXlPn73xI54LdlecvUcTpL4VX3rzSB1seVmsMc0Y9Hm5cCsA97XNwtDzvBb+BDWJ6KVWZRPLHq44+5EOpU9BHncvuu/cfGmKzmsonuJN18ruP3iebimVpG9najDNcM2ZHriy3ZqTIR46DKeKmE3GrhnucsSWLjjtj1PRn8otlKyrt0OIwe2j8W+QJOOW/GmCq9S1UKSFdKCQlyjP/Bme+qzvI9mnZzVatI74bSZq93UVuDX4w8tgClZLyNEETVEWt4oqQKExWs/U5MavPkk3DnNFjw5l93a09LNNxqT/VZTrRnB7Y5CMC+NuAZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(396003)(39860400002)(366004)(376002)(451199021)(8936002)(36756003)(6512007)(6506007)(8676002)(2616005)(53546011)(5660300002)(186003)(316002)(66946007)(66556008)(66476007)(4326008)(6666004)(6486002)(41300700001)(6916009)(478600001)(38100700002)(31696002)(86362001)(83380400001)(44832011)(2906002)(4744005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmlwblVlUUdxdUxQZXFYZ1gvN0tGS0xmTDFMSXdIZExrbE04T1lTYTI1VlB5?= =?utf-8?B?SmhRL3lidmtmNERsdTVjRzd2RmMxQnN2YVRKcW9rYU95eWtjTjZpV203L1pR?= =?utf-8?B?UzRLV2MvU3locmI1VVFLQndjRjNnME1vQjBtdEkybnN2UThSWWhnV0ZwcjIv?= =?utf-8?B?NEIwb0VlRldFVDRoRnl5RzJzNCtLQ09rTWhGYW9tazFJUktSQlZmM1haM3VH?= =?utf-8?B?dXNQdml4NCtEN1lyTFZrdnUzOSt1U09hSWw3VU10emJwVXkwdythRnJyVHJI?= =?utf-8?B?WlJoa1lsT3JNTHE1RFMzcXYrZUpTUWZuTTk0SHpRR1BjT2lEdmx0V3NpdGEy?= =?utf-8?B?Z3V4MVVlSEtGbzEvUGI1RUEzMlhLU09ZNWY2OUR4eXVhVzlYMXp2YjZyZSsv?= =?utf-8?B?dVhTdDN2eVFqd0ttRTdEVEtjYUpIZXZmd1BHQ3djYk5Ja3BtNWdvYkxnZzc2?= =?utf-8?B?TE5UbUVsUDV4MWZmNG1JQmJJbmdsTnVvNEN5Vit6NVNjdWxzNVZ0OXAzZFhC?= =?utf-8?B?UnNWdmhhTWZGSndYWUpJRjFSUDlUZWJQRGV1MTFTMDhuajMxYmZEc2o5U2R1?= =?utf-8?B?SGpzMjhaZlNpVENIQWpRZmJIT3RTeHRUSFRhMm1oSkdwT2dlL1diRjJOVHF5?= =?utf-8?B?Tm9pV1BvaTZSRkdhL1hzV1B6Tk9kOTRCK1ZnVDJXMEt2eE1RUXI4c3p0a1ky?= =?utf-8?B?dzlWN0MwYlVFc3QxeTFITEJkK0FseWlWV0JvM2NRQzVuUFN4WVU4MHhGWUda?= =?utf-8?B?TW13ZW5CdHRHem5XdGVSSmsyR1Zic0g5dE9wek1aejJ2ZjNGb2NKcmF6R01l?= =?utf-8?B?M0ttWWJuL2hrSnRkMFl5aHdJeHlhYXNFaWVUZkdrMzFhZ20vUzBJNDlGaDlr?= =?utf-8?B?NDV6VklsV0ZEUFRvTHFNQ2IyOFNmZWNYN2FDOGYva055UUJIZENGWXpRZlc2?= =?utf-8?B?ZHUrR0x0UWRHTE1PazhKNTMvYXBHRlFyMTVuTmJmbFQveFN3blhtaVN2YStw?= =?utf-8?B?NlI4d2ovcTM4MG1RM21ZZXhoN3R6MTR1UU9QbnBXMFAwdUp1WjY1WlBZRjl1?= =?utf-8?B?NGk3R05sVnRmdUJqc3lmWVVxSlNJSXRvajlXek5TaTR2V2RKcHFzaVlLby94?= =?utf-8?B?OFZxSisrUytyVjh1V2orTUFneGY4a2g5UWZXVDhwU3hjc3AvQXl3dWgyM3Zp?= =?utf-8?B?cDMvRkhuc3RFdXFCZDR0ekhxN2hIaXJCWWdYK1dEaXo4anRBL3R5ZmVMRXVx?= =?utf-8?B?UHUxRFZlYU1hRTVaMFV3UFBlcmxMRXJudzh0WCtJOW9wdXR5UWNDUnNhaG9P?= =?utf-8?B?U2czL2J6WjRYamxRTWpFSDJ6RUZkTE5oNVVDcElyZkxpUXljZm1KS2dsNXBQ?= =?utf-8?B?MlBxY2dqUm9PL3g1dTc2cTNRTjhFVVplQlB3dEVISFhyVnlQR090ejhpWDJN?= =?utf-8?B?R0R3L3E4V3pMRjc3dmQrRktKSE1IMFMyWGpCQXRhcWRsTGxzRDlnVStRVU85?= =?utf-8?B?ZDlHUVloRjFrKzZpZ01XZDZvUlV2NFM4VEQ5ZDhyYXJlNkFzczlXNkVBT040?= =?utf-8?B?VTBqclJqeUN3SnIzeFYzU0M2d2lJMFMzdXB5dTl0YmJrakViaFhSTXAva1FL?= =?utf-8?B?OFk4TEswMWxlOTR4RUdKT0daaCtINFd3UTZuNElrdGlIaFJ6cm1JZzZmMTRR?= =?utf-8?B?bVA2RDZyMEZhQjJEVXBkQUEralhJZDQxaXI0OFNHYUgxZk1OWForRk1pdDRa?= =?utf-8?B?ckJCSklubzZUZUpzemJudkhwK3ZqbTgvOXh6QnFXdWxDc2NJaDJabm11T3hP?= =?utf-8?B?MXZWNkJSNkZGdkpEdzVLUWp5a2V1aEkrYVZUcjhlZjZTZDhvOGxnbTB0Q0ho?= =?utf-8?B?eXBFeFAxNjNHRHliM2oxclQ1cFVYdkhUQm1uaGFZK1VKMjNjZFY4b3k2Y0gw?= =?utf-8?B?YlZ4alBZZkNzN0FXMmNwcHdxcDl5SHFCcVN0THIwSUJvemhKZm9NanhMMEwx?= =?utf-8?B?aC9sVjMvZHNoblowSmNkS0RiL2FGMDg1YThKaDR6NkxkWExVam9zbC93UDZy?= =?utf-8?B?UmhJMHBuSzNCOHdsNllQTTVrdXZIbzNVNEhTcjdrc1RSd3VyYmFoQkJJWk1q?= =?utf-8?B?N1lMc2h4TzhDbW8zV2dvbE14OCszbGVjM3RqQktSRCtxUktXOHMzVzY5Y1ZW?= =?utf-8?B?Qmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pFBmUcrOI90QNUAZy5kSxNCNaOnUMoro764tdSQCP7KeOr0G3+CcjNK/XNM9Ds7OVfZchaQFRaen8QOIsT6Ru6oXix7VsbpCD+Hp2+zIOY/i2V3TzkDypr3yXmjVouH4l4uBQDmhsm3hUUi7IDNhiieQNSh6CL10aLlFSmmcK4SUkQOdBqh8l02VnTJOVfme9uZOfImM9ORWNvZ2zCJ7mdu+1B8HFvU81M+IHjMLws4Dbog2uUzqa4fc1MFFw8HtkpaBN/veaeaIleBL+pDduxGlBnlyRLR+7viuLR96aafTfySEa48z4vl2LmNz0XkuDZPr1sNq6/gbBXq6iThFStvxdHX+Pbpb+V0mUZ251SoVubysuUYFmhA0Q1rMf169g7PfloAV/fHmYR2csvH4ft9bWSqp2CFRYLECxhv5LW1GItz774SvULy0gkE7aGnxkeh9HeB36DtFCX35X2jxzdVluBxaf2dXrSafsFTkulppjzZr+IQmk6nV8ezdNbiurC0XC0Yv/S+ZsnfbB6UaRUKQrSKrgcky+kiM0rw69P7B7Ctb3WwKYMHValyk15V74hrLScCfYOkAyMx6vkq6fF1c7NUetgrMXF3iAv06yXO99vd9wizNM3vRUVUUdNY/976hIosqwgADg1CLFQQCAbqrYUV+GcO/nkcjZAIBnGEFHLlH1C1WnQ8mbB+uyA50/gPebLvEp9eNeG/Z7gAhSVo/VNgRECwpd3NUWkkuiL4Uw7WEe7CitwiWbJXF9UKoK4xbu6XIm/8uBTJ8gxxMg51ymjOwKCXRChzR9Qb0YRE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fe2cd08-3b15-476e-f033-08db4bfd20bd X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 17:37:55.3746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: plfZHprcRxOs5Sq3nb6Wiqh4zA9PzsKySittLji49so4G1lxDjABMDiUMQvUss1toIpNMo/ChOojr5Aqbo5Wbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7654 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-03_12,2023-05-03_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305030151 X-Proofpoint-GUID: RpsombMIw5v9FRAgDrv_qoFiQvBlG_uv X-Proofpoint-ORIG-GUID: RpsombMIw5v9FRAgDrv_qoFiQvBlG_uv X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/1/23 11:03 PM, Florian Weimer via Binutils wrote: > * Indu Bhagat: > >> On 4/28/23 01:08, Florian Weimer wrote: >>> The SFrame specification does not say anything explict about alignment. >>> It uses ATTRIBUTE_PACKED, which strongly suggests alignment 1, but >>> looking at the structures themselves, I think what you actually want is >>> 4-byte alignment. >>> Thanks, >>> Florian >>> >> >> Hi Florian, >> >> SFrame stack trace format is an unaligned on-disk format. IIUC, you >> suggest 4 byte alignment for all structs in SFrame format? >> >> Yes, current SFrame FDE and SFrame FRE are 1-byte aligned. >> >> I had reasoned about unaligned accesses previously when a bug showed up. > > Well, GAS seems to generate 8-byte-aligned .sframe sections (at least in > the 2.40-7.fc39 Fedora package). So all this is a bit inconsistent. > I will work on making the spec clear about alignment expectations for the .sframe section and the various definitions in the format. > Thanks, > Florian >