From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id AA0413858C50 for ; Mon, 22 Jan 2024 08:27:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA0413858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA0413858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705912038; cv=none; b=WQfPqfwgJ2Jfei4gh6GAFGenluZ+YCjaNgTEJLg4Ef4UEAmKcL0u3IN6zS9WwtTQBqr5A6l8Hw+YMRZK+99Kx7TQS2JqlJrGK3xZde1v8+0WEPTKS2bmVykxmAjm7EOoqMke//ElM5oivH4GiAYtRL+gp0EtlGpgs6qfKM7RLDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705912038; c=relaxed/simple; bh=jZHN0QSGcPHk1PGeREFtj63C+5dxZx3Av2LmwU/WBVo=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=we9AcSp4Y82N5oXeyO1p2MqdurM32V/TIj9vQTa9NOQtn5Wv/XETzJm1KJd+QT7YjAUrfiEIiigb3TPnm9VGhG9yrSuu4g8qFcTvKo4wmibrAB0rPMRDDDnbQoTX0/P8QNNGKiXRNIQtSPDVqx1tymXzH34dlYKtVQiyAwyUpuA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8DxWPDfJq5lAXYDAA--.14161S3; Mon, 22 Jan 2024 16:27:12 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxRMzeJq5lnDYRAA--.5188S3; Mon, 22 Jan 2024 16:27:10 +0800 (CST) Subject: Re: [PATCH] LoongArch: Do not add DF_STATIC_TLS for TLS LE To: Tatsuyuki Ishi Cc: binutils@sourceware.org, Lulu Cai , chenglulu@loongson.cn, hejinyang@loongson.cn, i.swmail@xen0n.name, liuzhensong@loongson.cn, luweining@loongson.cn, Fangrui Song , nickc@redhat.com, wanglei@loongson.cn, xry111@xry111.site, xuchenghua@loongson.cn References: <20231228145802.74719-1-ishitatsuyuki@gmail.com> From: mengqinggang Message-ID: <97672660-4314-0526-ccf6-5ddfbddbf891@loongson.cn> Date: Mon, 22 Jan 2024 16:27:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxRMzeJq5lnDYRAA--.5188S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7ur1fCry5Cry3Kr48uryfGrX_yoW8WFW7p3 ySyF1rG3Z5Cw1fua4vqw1UZF98JayfCFW29asxKrykZ39xJ3WvgF4rtrW8uF1UXan7CFW2 qFW0qryrZFs5AagCm3ZEXasCq-sJn29KB7ZKAUJUUUUx529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUPIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2kKe7AKxVWUAVWUtwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07 AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWU AVWUtwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI4 8JMxk0xIA0c2IEe2xFo4CEbIxvr21lc7CjxVAaw2AFwI0_JF0_Jw1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_JF0_Jw1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jjQ6JUUU UU= X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thank you very much, I will apply this patch soon. For the last patch, I think we can add new comments while retaining the original ones. The original comments describe another implementation method and can be compared with the existing ones. If I wants to allocate GOT entry separately for IE/GD  in the future, I can refer to these comments. 在 2024/1/22 下午1:45, Tatsuyuki Ishi 写道: >> On Dec 28, 2023, at 23:58, Tatsuyuki Ishi wrote: >> >> TLS LE is exclusively for executables, while DF_STATIC_TLS is for DLLs. >> DF_STATIC_TLS should only be set for TLS IE (and when it's DLL), not LE. >> --- >> bfd/elfnn-loongarch.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c >> index bd448cda453..64c34e99261 100644 >> --- a/bfd/elfnn-loongarch.c >> +++ b/bfd/elfnn-loongarch.c >> @@ -862,8 +862,6 @@ loongarch_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, >> if (!bfd_link_executable (info)) >> return false; >> >> - info->flags |= DF_STATIC_TLS; >> - >> if (!loongarch_elf_record_tls_and_got_reference (abfd, info, h, >> r_symndx, >> GOT_TLS_LE)) >> -- >> 2.40.1 >> >> > Any interest in reviewing / merging this and the other two patches sent together? > The DF_STATIC_TLS change is pretty short, the formatting patch is trivial. > As for the last patch introducing a comment change, I’m not sure what Mengqing’s stance is, but my intention for the comment change is to provide a better context for the reader rather than comparing to a solution that is not currently implemented in the codebase. > > Tatsuyuki.