From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2080.outbound.protection.outlook.com [40.107.13.80]) by sourceware.org (Postfix) with ESMTPS id 97DAC3858401 for ; Tue, 18 Jul 2023 09:03:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97DAC3858401 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkWw4+L/Q+WINgJtVCfSnO1lg91Ehcd74tSYH1YrF781kuQq0iSbTJFcWh488mbjiDLWp6DOCbMgFr6GfuUcAdt2dYrQ+Pr46nMkz7oWLC8n3oZkDz9HnIO/zpZ20V9c82QKLtHrYdu5dAjkxG9HDQOhcqLvIzoIlanDP3pi9GuX+wUjB5H5egV5AVwbrZDL3+H1Q5MR3nJhKhMYzjH0Nyp0WscYxitcXtiBhOJ8bOHN3PaeR0RYUHbmIpLhbWKUVhwWrYLzeGdnxq/IlcxnU7NG+WlzD+iNqbhVyNX5nV4HuXEAIzsbXa2G2+bKWs9AVtefh8UhlVOXD1J/ICSiqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V2MS8/7rUOvHH+Brk3Bt8T95ggvtZKvmwGNPBd+p+Kc=; b=nugGUDlTqabBqNmnt6AlrLtZ3k4NhArbxKDjp0L1JyL6qzqSmln818kCjJ7a0UQlRN6Y0jK5ISTD1lZrRH0eUqcuDRVRNZjDQBUSFfIIfdy9mmbs8sXZCmBcGcTXwuDx10jNVWyELC2DwdltX5QgvgFADDMlnLLordJSZ1+OVjG8uXwMylPLmkdaj1PTxL/AvovwuitWKOF4gYwDRUQnGhBvIdcawgMDzfvsLK7w+qnSeGMk45+T3KLzdFOd64cli7/+hghrpncUdz0PxLd4j1YxD+jMruCAuM7uPsqXwB6tiaycYPAb+Zq39C0JDVfWWuH/LaFU+UEXmkhf20dv1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2MS8/7rUOvHH+Brk3Bt8T95ggvtZKvmwGNPBd+p+Kc=; b=JHhfeJ5nGPKEG4x8W0IlGqPneK1O7HIY0phGWkmXzT5hXC+H6+NtwkgDzzda15kKH/1HqDXmEI6Ce0jr7kdpq5xla5yFzYZiil6qMESJ8c7p4hBa6yBR6LO67V7uHWLRPJQz1kfbb9aeOORoQjG2dSyy0HhbwqNDHMwCT0/jCKybEQmWHGhOdGnndyu+7j6adKNHgayXxqG0+g2Vy9Y7w73S4JIq8WyoP2CFY9ASV5pjKKPFjB2NH7jX/tNqGQNpxfHVHgdoJvrgh6GwSdgx0oQvAbxuYyz3v6w+kkbcuNYnUu8gHAyZhCAfYAjOG+niywrXyjaVvppTAWWpIA+c1A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8783.eurprd04.prod.outlook.com (2603:10a6:102:20e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Tue, 18 Jul 2023 09:03:13 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 09:03:13 +0000 Message-ID: <9773ab6d-5aec-f7f0-9d88-47ceacbbaa63@suse.com> Date: Tue, 18 Jul 2023 11:03:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] Support Intel SM3 Content-Language: en-US To: Haochen Jiang Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <9c5c9603-3820-aef3-6f7a-56f01f5e0e6b@suse.com> <20230718080915.1391780-1-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: <20230718080915.1391780-1-haochen.jiang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0204.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8783:EE_ X-MS-Office365-Filtering-Correlation-Id: 806ebeb8-8dcb-41ca-2bfe-08db876dd0f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DSDxH0HdNeP+Zn/fLQTwiBaJqt4ftjslaP5OLteC9v3UijrQxeqr5FkxrU4FknQnz9Tk87wGWfnoHrEoUg5+vVvIMnFoztENlVgDl1I7HZV/7GpDZh272fGT76RhUQaP15bLSgH6B8X0EoOGiCmI/bbmBAqXbTOYGmRLIJjlM89mMgmpt5MflRnj4qNPEXyI1Rjxh8xDzSyYBTDtvIvUceAipRTPS47HWFofY8qxeclQHTX7EA2LQfsZWKYVhG/TMCqJPewNCqWT2u8lqBHF/an9mTsJJx8baX1rUC9Ka/BlAfcSOWVeFIyeV4ERx7LNtDAbxYnah7cdszOgXRNVEy96OtAXgayLSDyIO0erj96ydd9hHdwTt4qfhrFyJ1SbS3246L/MGkLibsDtZh/HXCDaOKwTT3Z3DV6IBlbcr8kMsES6ILUwKVNEh7ZRekdw49qnPwVTGVDsnsPNeTKSfNUeIXRQ7zzs49NQjO14BgMZRJvIypffgCARZ0XHc3hB/ZUbvsIeUyhPMPbBhJ5MXuAWfpnr+QqYGoguBfZj0Uz0bxVG5a+rUomxibHoPlAzSfvo+0FAfGmW7Wi4AEDaPy0xo9EMT22TT0CUusNiroCVQ0RO9jDAuP2GFmsy99Q0BhG27vPLlpzPNICkDoQUlQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(39860400002)(136003)(346002)(366004)(451199021)(6512007)(6506007)(53546011)(26005)(66946007)(36756003)(66556008)(38100700002)(66476007)(31696002)(2906002)(5660300002)(316002)(8936002)(41300700001)(8676002)(4326008)(86362001)(6486002)(6916009)(478600001)(31686004)(2616005)(83380400001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUhxaVdxYUlFY0NRTUF5bTEwZ1hMbktzMzQ4VFFDb0h4Y2JZbWRJTm43UC9p?= =?utf-8?B?RHFqY1JITnRiUWxqZVpNenlMRUltQ0VsMm5BekpJb0VhKzBuQzNsTCtyQ3E1?= =?utf-8?B?bEhJdVR3Wk5pU2dtVkpuREdoeVl5dVV2cDVVZFg3b0hJdWlWRE1XVEN3ZnFx?= =?utf-8?B?UFhrOHB4L1dSaUdWdnBQdG1oTHBzcFFUcUVNWkxjbjU4Q3l1UDYyc01LZlF6?= =?utf-8?B?cVJDamhoRENGanIxUUo4WkRwSlhGRm5kTTQ4bWtUWHdTTTJZU2JQN1JvVDBa?= =?utf-8?B?M05QMXlRZUlmb1RXODYwMnJjWEZPclpWTlBTNmRNWnloUTl0aWRMbFFEOCtJ?= =?utf-8?B?aWJ5TDZJZGZMNCszMU1Delk3Rld6aGdSajBhaUhIMXdTU3BhcW5wQkp0MXpY?= =?utf-8?B?U2lOTnhWb0FzdFlwWFh1KzdHbSswZnpxdEJJZEF4WHozakhJZ1o3YmVEYnhu?= =?utf-8?B?UEVtWjM3M1ZZeFJPbXA3MXA1UHYyWHVrbHg5dnBUM2pNM3FLem8vcEVYS1Jt?= =?utf-8?B?VHBsMElTV2pCOTEreE5abGhhTVlzRTR4SEY5dmdHZEdFeEJ3NERMQklpQzhv?= =?utf-8?B?U29GQkVJV0w3WVpiQUZ4ODNlQlpFbGJQdDA2K0JhS3NOZHFnek5HWXJlUHdI?= =?utf-8?B?dEVVN0dqVE1BNE5TSDFiLzBBaStEUHZmdmZUZUVZa2E4MFpLUk1iS25JajF3?= =?utf-8?B?S3pvRGZEYkJ5aDYxVnppTzg2VkNyYnRZM2lFSkpzZmt5R0NuWWl1N1crNzQz?= =?utf-8?B?Y0ROMklidFlIaXM1b1dSNURiNUk3MTN2Y3REWllmTXJqYzdQZTFON0lVdUgz?= =?utf-8?B?VFpXVk1VNytjRjQ2S0wyaGxWVGtYL3pWNjhIOWQyR2h5UFJaVGRoTFVCZGor?= =?utf-8?B?LzNZZ2RzMk9Nd3RZWVhGUUpZRGZ5eHNELy9QQlBrN2RaWURMc3dKanE4UExx?= =?utf-8?B?WmhXNmxIbnVDRUplaTVlU0U1SzBLM2RUSkw2d0pCV3dGdkIwSU91RCt3RUVQ?= =?utf-8?B?Y1BlSWh0cUhXY3JQbGZxTi9vUXg2T1NXRm9oVWJkdkVyMUcrZTZaRW5IeFRR?= =?utf-8?B?b0pDK24zYWlSRVRmQzI1d0x1UzdmMTYrMWR0RUNWYWZSZXkvN2J1dyt4YnpQ?= =?utf-8?B?SzM1RnFHV21xMC9CNjRWK2pEYnRxQkpHZ2VFTUpVVjRTVUlpSndOVzN0MGhM?= =?utf-8?B?L29qYU0yQnd5YURMRUU5bFIyWU1paENhWWlaQkF6MU80L2YvN3IzbnkyQ1FS?= =?utf-8?B?R2d5VEhzVks2Z2pBRG05MlNTdVdXdVF5K0p4WlBYNzJBNUZvc0ZpNlcvODVp?= =?utf-8?B?T2VqaFJKOXpNWHFyZmQ1V280Z0lZQzczQmlkRE05K1lrUFdoR1NGcklhOFl6?= =?utf-8?B?NEhiNzFseWdLM0dCRVJLamN3OUNqcDNwWHU3TmRYUXNFb3BBVWcxR0NnYnNQ?= =?utf-8?B?RzZFZWFMbGI0L1VoTG9Yc2ErOGxtcDd0cjcySERMdjdiaFIyaGYrWmxKRktW?= =?utf-8?B?UDByWXFvaXg2UytQRkJ4OUNNd3F6VW10RVV1SjQ1THQzWDFnOEZyYnU2USs5?= =?utf-8?B?TEZFZ2dXcWJFSUxSR3RKOTlyYzhUOStqNW1aanNGVi9FUTRjZ2ZFRlZGWEI0?= =?utf-8?B?d2lzUU9hakpGS3ZJMHBTQmMrY2JIRnY1bmZERGQ4aElsaDJpdldyKzJMT3dj?= =?utf-8?B?QkM5ZUJWMXVYTnUrVXJnb0tSTlBFc0xMMXZRWkR0eHNRR1c3UFBZRjdYWXJR?= =?utf-8?B?dlc4eXg1eXMwVHRXYnY3ODMwRkR0V2hWbzVTSzZuWWI1TmU5SXdPMVYvQVZo?= =?utf-8?B?VXArN2pFWHI1R0o2Tkd5SWlpbldzdFNGeko3Q0N3NDBSb3JZVG05VXEyTDlD?= =?utf-8?B?cGZOcnkzUGJaMXJTakFvNlhYTlI1UThFNzVXcWpmS1RNNXlMR0xYZEZVNisx?= =?utf-8?B?NlVmNUEzWXZ2eUNBNWthbGZEdWI2SzdlNm1kSWg4Z3czOUNaQ3BoT015NnpD?= =?utf-8?B?ZExQbGExMWRKd2NiR1RhOUdoWUJyMDlCby9NU2V3MW00aWNRUktGRHJaOVU4?= =?utf-8?B?TEVyNU1VUWM5eU9wS09mS3VjVEo4V2FMUk1qTUZLRlp6WTNrZXRtV0lHWkJ4?= =?utf-8?Q?Dz0PqmNQgaYwTxBRVV3tb0gX1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 806ebeb8-8dcb-41ca-2bfe-08db876dd0f3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 09:03:13.1128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: REhaKbZHTzhTuZkAIvLQFw3rXi4sY0v+zb8WIqENIguHjvss9ljGXnlszZ39IGmwd2KBdNgGA7uYOu26ZEP7Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8783 X-Spam-Status: No, score=-3027.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.07.2023 10:09, Haochen Jiang wrote: > --- /dev/null > +++ b/gas/testsuite/gas/i386/sm3.s > @@ -0,0 +1,37 @@ > +# Check 32bit SM3 instructions > + > + .allow_index_reg > + .text > +_start: > + vsm3msg1 %xmm4, %xmm5, %xmm6 #SM3 > + vsm3msg1 0x10000000(%esp, %esi, 8), %xmm5, %xmm6 #SM3 > + vsm3msg1 (%ecx), %xmm5, %xmm6 #SM3 > + vsm3msg1 2032(%ecx), %xmm5, %xmm6 #SM3 Disp32(f0070000) > + vsm3msg1 -2048(%edx), %xmm5, %xmm6 #SM3 Disp32(00f8ffff) The numbers in parentheses are odd. I'd prefer if they were omitted, but I'd also be okay of you flipped their byte order so they properly correspond (as numbers) to the displacements used. That said, I'm not sure about their usefulness: The two specific displacement values chosen are apparently AVX512-inherited, where they would correspond to the largest/smallest displacements still compressible. Since these are VEX, not EVEX, encodings, I don't think these values are of particular interest, and you have memory forms of the insn earlier. So my suggestion (without insisting) would be to simply drop these (and similar) lines altogether, or if at all use forms which in fact use Disp8 encoding. Other testcase related comments given for the SHA512 patch apply here as well. Okay with all of these taken care of. Jan