From: "Martin Liška" <mliska@suse.cz>
To: binutils@sourceware.org
Cc: Nick Clifton <nickc@redhat.com>
Subject: [PATCH][PUSHED] readelf: Do not require EI_OSABI for IFUNC.
Date: Thu, 24 Nov 2022 13:18:33 +0100 [thread overview]
Message-ID: <9790982d-5a3d-f711-b588-184edd41a0dd@suse.cz> (raw)
Pushed as it's pre-approved by Nick.
Cheers,
Martin
PR29718
binutils/ChangeLog:
* readelf.c (get_symbol_type): Consider STT_GNU_IFUNC as
reserved name.
---
binutils/readelf.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/binutils/readelf.c b/binutils/readelf.c
index 1bd6df9448a..365c1ede0a1 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -12724,6 +12724,9 @@ get_symbol_type (Filedata * filedata, unsigned int type)
case STT_TLS: return "TLS";
case STT_RELC: return "RELC";
case STT_SRELC: return "SRELC";
+ case STT_GNU_IFUNC: return "IFUNC"; /* As mentioned in PR29718, do not
+ require EI_OSABI as IFUNC is
+ a reseved name. */
default:
if (type >= STT_LOPROC && type <= STT_HIPROC)
{
@@ -12748,11 +12751,6 @@ get_symbol_type (Filedata * filedata, unsigned int type)
return "HP_STUB";
}
- if (type == STT_GNU_IFUNC
- && (filedata->file_header.e_ident[EI_OSABI] == ELFOSABI_GNU
- || filedata->file_header.e_ident[EI_OSABI] == ELFOSABI_FREEBSD))
- return "IFUNC";
-
snprintf (buff, sizeof (buff), _("<OS specific>: %d"), type);
}
else
--
2.38.1
next reply other threads:[~2022-11-24 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 12:18 Martin Liška [this message]
2022-11-24 12:27 ` Richard Earnshaw
2022-11-24 12:45 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9790982d-5a3d-f711-b588-184edd41a0dd@suse.cz \
--to=mliska@suse.cz \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).