Re: [PATCH, V2] gas: scfi: fix failing test on Solaris2

[Indu Bhagat <indu.bhagat@oracle.com>]

On 2/8/24 00:09, Jan Beulich wrote:
> On 08.02.2024 08:10, Indu Bhagat wrote:
>> [Change from V1]
>>    - Include a check for --32 as well.
>> [End of changes from V1]
>>
>> It has been observed that the run of scfi-unsupported-1 test with --x32
>> arg on a Solaris2 x86_64 system fails:
>>
>> Executing on host: sh -c {../as-new  --x32 --scfi=experimental <...>/scfi-unsupported-1.s 2>&1}  /dev/null dump.out (timeout = 300)
>> spawn [open ...]
>> Assembler messages:
>> Fatal error: no compiled in support for 32bit x86_64
>> regexp_diff match failure
>> regexp "^Fatal error: SCFI is not supported for this ABI$"
>> line   "Fatal error: no compiled in support for 32bit x86_64"
>> FAIL: x86_64 scfi-unsupported-1
>>
>> Fix the above by adding a check for --x32 support before running the
>> test.  While at it, also include a similar check for --32 support.
> 
> Okay.
> 

This is committed now.
Thanks

> One further observation (not for this patch, but still related):
> 
>> @@ -40,8 +56,12 @@ if  { ([istarget "x86_64-*-*"] && ![istarget "x86_64-*-linux*-gnux32"]) } then {
> 
> The condition visible here makes it so that on ix86 targets, no matter
> whether they're capable of also producing 64-bit objects (via use of
> --64) these tests aren't run, despite scfi being usable there.
> 

OK. I'll look into this one soon.