From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2047.outbound.protection.outlook.com [40.107.22.47]) by sourceware.org (Postfix) with ESMTPS id C1BCD3858D37 for ; Mon, 27 Mar 2023 08:38:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1BCD3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGhzpweLUAGPijJe9zmoHcblQanJ/wtmv0eVRlMs4avskIWAsnwJHqV1KhbefjTFnaAZrG2QwpKRDmu+yPlUcTmZRnRxmnUPWL2v6+Dqfx0U+4qX8eSv5G4rvygMc6pqLofV8LrE63lBH1vzGAhrmH7ySs44cZXjE9unfIOxnOZmKgSd+pSrTgOh+dHl34z4prIGFz8lr6azXgJC72NH9OBQcYD39uneTl/ox6NJmTCY9VMl5TdP2+cLCovgD2o1+SEXcYDHsi08RM4SLC7V5XHsrRn7BK5iP2jJOt9+paRBX7UwxW6gdSWZz7MDJPrdaN7aerMbUpPNOrJ8Fi8HYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k3eAUS1h4TIPfQ0kzJtqEpKgbveuEkMg3PgCGU1oaT8=; b=Vc7EhKOx05TN41RufhSitcjWW2rKNZTNHUTYgjX7Rq9r7K9aUEcKPRcPnENbtQ9qEahqBMC+xtKy1wDv3taZq9PtaoehKR3Jh/3iqRU8WdxjWoSo1iT6/3ljrUKv8DSus0ySEbCYIOshY26RjodzGelzrBvvI4sKa5ystUkaym7t9hTzboAAzPEAvJRcisf/UIFRfVznNRMhOyLRSUg2Gxn9e+4uNE7mcexEwVef8+LQkM0hRaF426Nw5mmmiKVoFcPKQK7XIBo7qRiYtGiu4yhTUBwBN7ZT+Era4oUGfiuY2ZZmIoxuyAyDxcj0QRdtxFWx/ffABjKG5POzG3Oa/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3eAUS1h4TIPfQ0kzJtqEpKgbveuEkMg3PgCGU1oaT8=; b=Ez6lx9Ht3BYRH0q0yH+XA5DWYVRsiPdZpE1obnqomC6TeyvOQcz2VBgszXkbZUiNMtQa6vKUUWX+l1v6MDlR4elRFc1TNvbSIillFCGkLq2txyv8WakdhKJvfeFbDzAE+sKYYwJnmVwAZsytFIcegZ/Pgge7PxkXgPf8p7Lnp+iuO5xyROES0BFFVIge0O2spG0skseOf0kQhpf+bUWt2+9kBVqriogCkrFr2zfev661ma6usoMnT31+i+Eq7FJVKT5LZsliZ/zEYb0hm1sRKEFASGDGwXVwu+ZCrfJ5JhbLwJiaNa+Kq5twcchSiZGjsO9krq5ETb8C9FZcdQ+VhA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7546.eurprd04.prod.outlook.com (2603:10a6:10:1f7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.30; Mon, 27 Mar 2023 08:38:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.029; Mon, 27 Mar 2023 08:38:23 +0000 Message-ID: <981c0ad5-3e84-d2f3-c14a-4c7bb70749a9@suse.com> Date: Mon, 27 Mar 2023 10:38:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH v2 2/2] RISC-V: Add support for the Zfa extension Content-Language: en-US To: Christoph Muellner References: <20230327080107.3266866-1-christoph.muellner@vrull.eu> <20230327080107.3266866-3-christoph.muellner@vrull.eu> Cc: binutils@sourceware.org, Nelson Chu , Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich , Jeff Law , Tsukasa OI From: Jan Beulich In-Reply-To: <20230327080107.3266866-3-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7546:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b5e6d9b-987b-4bb7-bf1c-08db2e9ea016 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +S7MnGCVbLcfcvmZlmxDjgYpT/3bvh2jItqmH3kAIWuX5+llLFC1IIoQ8KqqZbxo/wSNw+qcICw0QVhrMoUyp+3P/T6UFSsa7rGhmUkixc+2qE2f9KD5dHSTmZDWlKRC31C7bn1HEkywZbCtBzC8YkRypuPhmCdzIZyU4BDbRwOla91ekUbXK8gbMiZX8PRI2frmUIe0/G27gA9mXCdEcvlCc3ixpEjHGf7MxiyrBIsKSmHjbx0k02X6XL3+AHxcG3OiunNZ6qwIpP/+bAXEcektae3TwB+xXNRysyVKbQfQ2lXXEJD0eDQGnJCe2R28S9ctuGGEWK340TE2JADt9VRJdZZm5q0FuRNWEJ3hKa5Hq2yQCa0lxmpAByUcCGEocMCsZYpryxQuatmqTy8PSKPDdKj8ZYqL4p2Z+jcIgRqYBZnQS0HjU3cfAtvtqr7r0fs3jlduiZKjoSyqKNvSNDi59btfToN+IzXLvvU1XQIUzsukAqZEZrazOCh05Z3sAdHCxFfMfssqgiwnYOKHU/6xP/6l9P58VRwLxD2jODz4pCA6IuRqUbuWF2JK/nr7HVL/ZiKS//UUReBFe6tR/1KYaN5raylmF7aJPXYQJTNHDvZg4QoUWusKOaoE/MIh3sqlFW5XAYcqXMhq+aHoyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(366004)(39860400002)(396003)(376002)(451199021)(6512007)(6506007)(26005)(53546011)(41300700001)(186003)(6486002)(2616005)(31686004)(478600001)(54906003)(316002)(4326008)(38100700002)(2906002)(6916009)(8676002)(66476007)(66556008)(66946007)(36756003)(31696002)(86362001)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlZCcEZjZGx1OEFJMUdLbEd1MmpHVWkrRXh3T01jN2V4YThNWnJQS3A1dmtJ?= =?utf-8?B?aVZLbnBBRGJ3Sy9UTDZMcEJLUUZNcnJkaFJldVR0aDh4UlZNUkZyS3dDWHFk?= =?utf-8?B?SmNUNHF6T0l6T2tBT01CSlhiRXFIdm9DK283NytIdllSS0Y4VjJrcUxXcEZS?= =?utf-8?B?dysxbDJmMHRyNGcyRlZlcWFzS25KMFVOVTRxUElOSG5CZFNUTDJKV0V3OTdk?= =?utf-8?B?Z3p0OTlPUkdMZjA1ZXVmZGdrOVhRUE5jNm5uSitzNTE2SXEwdFdZSXBrM3hF?= =?utf-8?B?MU9sajFGc2x3MWE2SWVDQlhDZWhsYWJZYy8rdzh5SmwxRGdIdkJWYzF6OEhh?= =?utf-8?B?VGp0UjB0N0RMRGhpRDRsTHlsejdXTis0blhRMkZJNXEyVVBBbGdzT2JVVmRq?= =?utf-8?B?NXJRZndTZEk1MVFCNTJlY1NxZ2M3Uy9rWE5yYkh5RGlGYmswVFJxZUVXTGhL?= =?utf-8?B?eEpGMytBaVFUbXVyM2xOMzZPK0hDeWIwZjcvS0dBSHJ3VU9ob3ZGY2EzemtX?= =?utf-8?B?UHBRVm5iTkZUak5KMVRvNHBpMGpwTllqV1dabUpYTmlPMy9zajY2SWhTcGpU?= =?utf-8?B?b1BLQlQwekxTWnFHQTUvazlMdkxiazYzMi8xWEFKUjkwdm1pK2NmRkdmL2o3?= =?utf-8?B?ODZQODBZOHJnN2F1WHFUbnRvUW1EM2ZQeGx5NkRmQUpjR0sySVRUMi9wU3Zi?= =?utf-8?B?dGFwbCtEc1duS2tCZkRTYWJlcUQ0czdCYURLZkIrQzhoSytRK1l6N0Y5RVl2?= =?utf-8?B?eW43akxqQ013THBIV01YNWgyeFU1UFZDZWlzbFVIaklrNzFFYXFaZUhJdlFZ?= =?utf-8?B?U2szRzdhTjczT0hjOElHK3FFZ1A5eDZDVDBmVHRBbWFSSlEzL1A0QzBiQ0w5?= =?utf-8?B?MkpPYlJPcldYdGxRdyt3dVg1aDVtcnNRdEtIenpaU2Juays4YUlyZWRIRjRL?= =?utf-8?B?akRVR3E0V2t5T1p0a3BWckV6VnZ3RVRTNWxUQjNscDN0RHJhaUlsaFE2Q0Yx?= =?utf-8?B?UVJoVnlEdGsvcnljbXRLR3JxM1pRUDVLbExwaFQ0UGF1VFM0YWtoUnFBTXR5?= =?utf-8?B?Q1BiVWdUTUVtS3hRU3RMK2ljZHdmUC85ZWZWMlJ4c1ZDc1pKRjVpcHJZTEI3?= =?utf-8?B?bERjU2ZmVkdCc0FKOFAyS0hQWTl1QXkyR1Q0cUkyaHB0Y1czSTg2aGxaNmdC?= =?utf-8?B?VjFGcEU2M0ljZGpaeUJUS2RyUEtnc3lyYlphRXFHMWpOUEJRRmlpbFFzT0gw?= =?utf-8?B?NGNqQkdzblJ4NS9ZMUdnaC83a1dONnRQYjl3MTRCTlBRSWNqSVBsczQwaWVr?= =?utf-8?B?eVp5WmtxdGRQOTVzelduU2pkQ2duWERIalR4b2ZocmVGWmN4UzA0VXExSGlE?= =?utf-8?B?bHdkYkRlSDA2MXlpOFoxbCt6WnlXUkU5OTJHeG1PREpnbEJLQmIwclNaTFlw?= =?utf-8?B?RU05ZnJ5MEdLdDhOTXRqcGVlS29aNUtsaTJQU0NwOUhHbnZ1c2xPTjNXWUg3?= =?utf-8?B?WnJRR0RGMGlJcExOZ1VhR2dyZGtQeGxaT2tTeXk1bDZVV0ZJZUljVW1aWUJK?= =?utf-8?B?OXNMQytwR1ZsMWc4V21ndHAyQlFSbkwzS1dLaTlrak1LM0ZIMVIwZFpqazZC?= =?utf-8?B?bWY3Wlc1YVM1dmtHczdpd0F6OFVKT3c4MUVzS1pYSVZNZ2hpcm5OVDhGQ3Ir?= =?utf-8?B?d29wSTNzQ3BDVEwwWERwNmdVZjhEVDIxdDl5VDFBdTZqNEkwOW83UmRxNWNM?= =?utf-8?B?NGJuNkF2NjlTdTdqN3hvazNSdlpuc05zYXcxZktRdzY3U2NMODYxMHpORUZ4?= =?utf-8?B?dzQvaDgxM09oUTdobHUvUVp3QlBzTnJ5UmNqVFJ3eFQ5aVlJSDBGSFhMemRN?= =?utf-8?B?WkYyMzR6KzU1MmpOcngzK3hENXYvcmJRYXlwTGJZWmt5TnkwcG1wRUFmTVNP?= =?utf-8?B?bEp6SkdIOTc2VU5wVGFJRi9DNjhEMTZKNWdKaXJuWVBDMFhLYkZBM0JlT3ZP?= =?utf-8?B?d3hac21zTzVOR0VRMFBWb1djTDlxY1FSbldZUEQwYmRhMEsvaXgxUlpEdmta?= =?utf-8?B?UUYraFlUQ0FRenRyS1dWOHdmSjlEN3lhWW9UZkNsdStoc1g0dWNNeG9jNXlL?= =?utf-8?Q?hPaxPO8gLu0e+hLEvT+WvbY7s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b5e6d9b-987b-4bb7-bf1c-08db2e9ea016 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2023 08:38:23.0064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sslSigyLLKGYxEJ/DqKibTdc4wtwFDIElZfv7MIJmDhhB1C7HbMyGANKRRyn6kFycV73hZa3gQsuTGJehGmLdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7546 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.03.2023 10:01, Christoph Muellner wrote: > --- a/opcodes/riscv-opc.c > +++ b/opcodes/riscv-opc.c > @@ -110,6 +110,16 @@ const char * const riscv_vma[2] = > "mu", "ma" > }; > > +/* The FLI.[HSDQ] value constants. */ > +const char * const riscv_fli_value[32] = > +{ > + "-1.0", "min", "0.0000152587890625", "0.000030517578125", > + "0.00390625", "0.0078125", "0.0625", "0.125", > + "0.25", "0.3125", "0.375", "0.4375", "0.5", "0.625", "0.75", "0.875", > + "1.0", "1.25", "1.5", "1.75", "2.0", "2.5", "3.0", "4.0", > + "8.0", "16.0", "128.0", "256.0", "32768.0", "65536.0", "inf", "nan", > +}; Especially for values like 1.0x2^^-n (entries 2 and onwards) I question the spelled out numbers to be the most suitable ones usability wise. At least some alternative spelling (e.g. 2.e-16) ought to be recognized as well. But since there are meany reasonable spellings (leading 0 omitted in 0. or trailing zero omitted in .0), I guess I'd prefer if values were actually parsed as a floating point number (e.g. via ieee_md_atof()), and then matched against values stored in the table. One might further consider to also permit the 2nd form accepted elsewhere, see read.c:parse_one_float(). Jan