From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id C16113858436 for ; Thu, 10 Mar 2022 11:50:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C16113858436 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-36-Nd5q11jRPrGZybnqNAxydA-1; Thu, 10 Mar 2022 12:50:44 +0100 X-MC-Unique: Nd5q11jRPrGZybnqNAxydA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPKhy24jtdqyzMAqCrF79YPEtXhlMEwKr/1Xz5UbS+gUEXF4NQcvC6HhOfuttmOFJ1T+JJlFLN2jnkTwUsw7BjZ0nUERDcK6uIM3nWwEXGG1QgdyMtRFh1Im1po3jB3Kkt5kBnhUZ6Boy87dFoSRsCZBnU687gYjlU3+fbHf7/fpR+IsSDulli2jEkFd//wIGwlblNlTupiYC3GCmOmPkXBOr95jjOSkhlodjlO4phnND1pTKtutm1viD4irwTBpPvQ265mVOMYOV6zyZ2u+JvibzRKJP1gs+8JO4SFjBe7Jf6oImQDOFOtwfDltrZ8FS3II0erL91d/VaD8njjX4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XHu5lYuyyZfrElYz9yh/Ix6ilN/Z4zN9BY5+l6nHeGs=; b=azpubpGHdrNjwaG2NCo1IUnf+HspzHbcTTCo3ENGQhCG6ap4JHS2hEEVrMSd64ikCFKCiQ0gVEZxn0EKgiiTuiSsr6EfuRL3uFslsogEEiNg8PhjWE26uneMIL4gYir0hc4AiY4CI8oSZAwId7gsV/YI7AqbzUKIDZVTkstHighNyPUdnNcqhD878+yCRq0XAZRVtn117VOZJBdeGj3uKxi0OvMJpCAlhSq+gI6HO1JJ9exi0k9O7ozd62Y3Yyx2dXvsOlzKAM7DdzdbGnuWZrgQyOCdW6yBwhNMMK4G2H82TPJEJ+5WW3cCb/VDeYkWQXdS1Nwuy0DJo/GrZPIKOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) by AM8PR04MB7442.eurprd04.prod.outlook.com (2603:10a6:20b:1d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Thu, 10 Mar 2022 11:50:43 +0000 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::dd50:54e6:1f96:3b33]) by AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::dd50:54e6:1f96:3b33%3]) with mapi id 15.20.5061.022; Thu, 10 Mar 2022 11:50:43 +0000 Message-ID: <983f339f-aed8-7250-4e99-c9e77ea25b28@suse.com> Date: Thu, 10 Mar 2022 12:50:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH RESEND v2] Aarch64: Allow explicit size specifier for predicate operand of {sq, uq, }{incp, decp} Content-Language: en-US To: Shaokun Zhang Cc: Jingtao Cai , Bo Dong , binutils@sourceware.org References: <20220216005311.26184-1-zhangshaokun@hisilicon.com> <7435dbfd-5b5d-60d0-7376-83c209c77541@suse.com> <91de3faa-b7b5-07ae-37ef-0eb996bc340a@hisilicon.com> <99db07d9-ad39-86a7-727d-be0edce7ab19@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0110.eurprd04.prod.outlook.com (2603:10a6:20b:31e::25) To AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 98cf5b73-f744-4fd0-edc2-08da028c34dc X-MS-TrafficTypeDiagnostic: AM8PR04MB7442:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q13yKjc9dhlDHUX8Dc+w05yaxkivvolmUjAMzwJAtV0sEtly8sFoq9L6NVG+O4KHc0whqyFA1TpooMpwAgBhbdfpGtFl3pYNMGtMsx0OC5LV4WLYi5SJgGb2H+ki/rS6Gk2ZE/D2nucqnQCU02EIaPRchMVbUnCttQTLIclGEEiwKS6QKMSvmESOKmyp/ehE+TKXb3RWSZ/SJ2oWperM5pJxLk/fuaNEJLojWu84X26CIStqzPTy9WDH/OYCQe9lFsKmNWuub1SX76uu1mU5j4N6iuuhxm8Diy1AbWzmXZ42YXcqHKmSYw23lXT8ABLCUwDYBStC28suKgO75ztKeMZrE7nue8fAIdn1DysyAzRxBeCKqMf0EskOhKaKSUAMWuq5fq3YsjJUgN86QwbLkJJINNJhkeGzFuQi+tFzbp33Wv8MVMTyk8KwP4ZU0nJCqwjbmWsbUwMulkeZRsW0s9wJT33JaqDLcRxsCS2p3HV3Fdq/rPdAOsGAu+G7UOEfQuuLvHafZVs/7tl2nP2Ha0XwzNNAtyP74DtTgz/5Kxd1kt0VMaG3RXi8UZUDFCBLgEKjy+HNkNc/DXFdeJRpm19gf15cq4utiVc1Aefx28VUvAXgdDjyv84sgtperMsfaJxWac2TmhM6aq7j5E/4ZPcGxop5HGBeJYPuLmuQ//EvTkUuCiJ8Au+DW8MYUdRnQT0fsgpz8t5RVFT3tZ0IhjBOzZTrl+H2tiw2zbGyaf4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB5587.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(53546011)(508600001)(6916009)(54906003)(316002)(6512007)(2906002)(66946007)(36756003)(2616005)(66556008)(8676002)(5660300002)(6486002)(31686004)(66476007)(8936002)(4326008)(31696002)(26005)(186003)(86362001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDNSWWlkeE9JYjFFdWxlaWg2MTJkRVBrRC9UYVBDOElMVGJwSWxuVE54dUt0?= =?utf-8?B?akozc3RkTWlnUmNpNmZWQThyR2ExR3hNeWR6SWR3Wlh3VEFoendhMmRnMjVI?= =?utf-8?B?eUFNYlVRbTN2dmFlZ2dvaVVsVGZlcmRTdzVrZ2NyWEg3OE1HUnpCOUR1ZFJz?= =?utf-8?B?SjhzNWVZVXhiUXNnejRTU0VuWExXaWk4Q3oxMUpZWmIwU1ZOTUNWeFd3S2p2?= =?utf-8?B?Uk94TTFISmpuT2swWEtQbGJWWVFEbmtSdE5hVElndlhpR0NyK21XanllOUx1?= =?utf-8?B?T2FmNExnbjFrTFFGNmROWit1LytkOUdsTWFXbjAzTFVabldFaDNwSkJCajd0?= =?utf-8?B?Q3hxZkpGT1pZSTlNbG1tUG1hbVZpYVhueStlbXQxck15T0VqUFU0T3JCOFdR?= =?utf-8?B?QWNWcGRuRmhhQm1ENDUzcmovMGhFcUhNbzdFaEpBUlZvMUFmZE13WmQyTThv?= =?utf-8?B?MG8zSGUxSTRidzN0NFdtaDRkUGo4TXdvaUo0eU4yZjZpSXltK1BCcitIR0Uv?= =?utf-8?B?QjZGWmQ0Z0lRVVpWYTM4eko4NS8wRzFmekJ3YTRhRVZXeHFPSE5ETE95SG9S?= =?utf-8?B?d1JtT1FLQ29WQ0RxOGllUXllRW1mRmJ4bVE5OWVuSEpvRmRGL3FkaVV2dGRy?= =?utf-8?B?bmRWcVRVY1Jyb0VTVVpOa0ZqSnNxd3Q4OHBoY2FlbnFyVjZpb0Vma21lS2h5?= =?utf-8?B?K0NFTHhMNkNIRHhuTkV1YWJxbnY5dlRZdk1mclFmekgrYlBFSFA0S0lacUlE?= =?utf-8?B?Q1FjUVFobEZrUGpnTmd6VVVIZGtGdVVDNU5FUi8zdEJvSFJoS2hQVUJZOE1i?= =?utf-8?B?eW5LY1JJcXlSaEhlUS9zZ3kvVzJUYzBzU3h5RGc1QnR5Z3QvSVYrZWNwdkFO?= =?utf-8?B?UGJkWnNxdXZrR0FzeENDTy9SYzN5Sng4WkIvNHRqS1hVczY0K1JFRFlNWTFG?= =?utf-8?B?U0FvZlJJWlVBMStjbVdocFZKLzhEaGI1djk4VjNCcHhQVlREaTExamYxU2Fn?= =?utf-8?B?MkRFUkgwdk5yaXNSYkRFaTZCVDJubzdHVHp1VzVacmI4UnN5K09sK3hIY1JM?= =?utf-8?B?TDR3THJEOVNhVUpoWWRDazh0bDk4dTB0eFpkYjJFd21FTGpOM0VRR01GTmVr?= =?utf-8?B?MUhnYmhjTkhaL05EZmhzMDJzMERyYU1zTGc4NURMTnFEcktTMFd6a25MMHIz?= =?utf-8?B?NzZJQ2w5QkU1VmU1QTRSOGlsRDJXNEE2QzhkaythUGNCWlZRK1hYY3NiMnMv?= =?utf-8?B?K3dlK3lwajM2T3VnZlZibnJscDFnMlN1VVNvS2FHNzBlVnpHblZDdGlSYVdH?= =?utf-8?B?cGFPSnNweFVHQ010NUJOTTJEenZmL2VQOG9OS2NtVExLSCtxRWlybFVjTytK?= =?utf-8?B?QWVhWVgzb2R5a2lhc2loQ1ZTZUpETE5sdldXSm1FNWdmb1BGWEpMYzRtZjlv?= =?utf-8?B?SlpIVDhEVnRnZFZERWFKS241NHF4aW10a2lnbUMwamJnUlFzQ2tRQWQ4STFo?= =?utf-8?B?Q1dGdC9nd1RISEkwMXdjV2pHZWZNMlI4SDNIQXNjVS9DTGdFZmhqc202b1p3?= =?utf-8?B?dy9PaFB6N2FvSk96WUFmQTVIRW9OTFR1ejRqRUpCM0RqbHR6R2RoR01lL3BV?= =?utf-8?B?TEVBY1Z0UFd1cFlScEdDQmV0NFFWOHBXUDJHQ2JSUHB0ZktEdVF2RDdEVkFI?= =?utf-8?B?NGs5eWRaQmN3NVRXTDBlVzF5eWRoMk04R085dmVJNmozT1R0YjhqdVZ2dXV4?= =?utf-8?B?eGRzRkUza2NYZ2ZEVEg3OWV2OUFFQzZDU3dUdFozdDhHeVcxTTBUZDdTWHcr?= =?utf-8?B?N0FzdkR3N1VQZEJqUUVZaEordStEdis3eG9oM1VXZWRwSk10ZWI0cVBOU0ht?= =?utf-8?B?ekpWZWthV0NoRnQ1bjQ0T0RVM2pidlJlUVcvMm5ua3YrclF5a1VZbG5uVFBx?= =?utf-8?Q?lOCmNSkcoOCq+a35w1n3gqzRLioApM9T?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98cf5b73-f744-4fd0-edc2-08da028c34dc X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 11:50:43.3792 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tvEY0haM0nS+cgBsFnwidH+maP2wyKHDOVIAE+4/zoq/xKoBQ/Bf4ObcP2aR30V1eCyfDrrvgdECj5Kv2HShIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7442 X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 11:50:48 -0000 On 10.03.2022 12:33, Shaokun Zhang wrote: > On 2022/3/10 18:38, Jan Beulich wrote: >> On 10.03.2022 10:38, Shaokun Zhang wrote: >>> Hi Jan, >> >> Despite this, ... >> >>> On 2022/3/2 15:36, Shaokun Zhang wrote: >>>> On 2022/2/21 21:13, Jan Beulich wrote: >>>>> On 16.02.2022 01:53, Shaokun Zhang wrote: >>>>>> --- a/gas/testsuite/gas/aarch64/sve-movprfx_23.d >>>>>> +++ b/gas/testsuite/gas/aarch64/sve-movprfx_23.d >>>>>> @@ -9,29 +9,29 @@ Disassembly of section .*: >>>>>> >>>>>> 0+ <.*>: >>>>>> [^:]+: 04512461 movprfx z1.h, p1/m, z3.h >>>>>> -[^:]+: 256c8021 incp z1.h, p1 // note: merging predicate expected due to preceding `movprfx' at operand 2 >>>>>> +[^:]+: 256c8021 incp z1.h, p1.h // note: merging predicate expected due to preceding `movprfx' at operand 2 >>>>> >>>>> I have a more general question here: Couldn't the spec make optional the >>>>> use of all the same size specifiers when there are multiple, same element >>>>> size operands? One such suffix of course needs to be there to disambiguate >>>> >>>> We are not from ARM SPEC group and don't know the exact considerations for >>>> the forbidden omitting suffix. We guess people will have different answers from >>>> different points of view. >>>> >>>> >From our point of view, a suffix makes the assembly more consistent with the >>>> scalar versions of `incp`, e.g. `incp x1, p2.b`. And the predicate register acts more >>>> like a vector register within this instruction, with suffix, the addend for each element >>>> is clear once reading the assembly string. >>>> >>>> Not sure that anyone from ARM in the mail-list can give more hints or thoughts. >>>> >>> >>> No any more comments from Arm guys. >>> >>> Is it ok for trunk? >> >> ... I assume you understand that I'm not in the position to give you the >> wanted "okay"? > > Apologies that I don't follow it completely, do you mean that does it need > someone to agree and take it? Or we need more comments? Well, as for any patch a maintainer of the code needs to give you their okay. Jan