Re: [PATCH V4] gprofng: a new GNU profiler

[Vladimir Mezentsev <vladimir.mezentsev@oracle.com>]

On 12/13/21 07:13, Nick Clifton wrote:
> Hi Vladimir,
>
>>> To me this is a concern as the intention of the binutils project is to
>>> support as wide a range of architectures as possible.
>>>
>>> Is it simple to add other architectures ?  What work needs to be done ?
>>
>> We utilize disassembler() from libopcodes and several functions from 
>> libbfd which are already cross platform.
>> The rest of porting is stack unwinding and hardware counter profiling 
>> (It is in binutils-gdb.git/gprofng/libcollector).
>> We will start writing a few page porting guide.
>
> OK, well I do not want to hold up this work any longer, so the patch 
> series is approved.  Please apply.

   Hi Nick,
thank you for the approval.
After `git rebase master` and rerun tests, I found a regression.
I made an additional fix in opcodes/i386-dis.c in swap_operand() and in 
couple similar places.

For example:
swap_operand (void)
{
   mnemonicendp[0] = '.';
   mnemonicendp[1] = 's';
*->>     mnemonicendp[2] = '\0'; <<<<- this line was absent*
   mnemonicendp += 2;
}


  After new fixes, I updated the several filters in 
gas/testsuite/gas/i386/ directory.

I will send my fixes in opcodes/i386-dis.c and ingas/testsuite for 
review today.


Thank you,
-Vladimir

>
> Cheers
>   Nick
>
>