From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 89DC43855584 for ; Wed, 10 May 2023 11:20:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89DC43855584 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683717646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xiFc/gPo0xzl/6tJXdEBybNnOfQoORCSdoD9uvHAzug=; b=Uq3LR2uFADKYMydwDsoY6ItNXCDphH7ib6BRH3KSwz0YFjNRw5DPD6IDpDCjPwJIBit3G8 HBA2qiiKDJRkyQsjFZ0ki7gQelJ14O8og5s06SyDQ9TLPmxKrkHCRVBDFElD0LA2zrIe6k dKZzNO2dLxjqDNOa4oygGolr7J3oLqE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-y7iNxbW3O4GSuEay7Y1-NQ-1; Wed, 10 May 2023 07:20:45 -0400 X-MC-Unique: y7iNxbW3O4GSuEay7Y1-NQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f421cfb4beso16245905e9.0 for ; Wed, 10 May 2023 04:20:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683717643; x=1686309643; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xiFc/gPo0xzl/6tJXdEBybNnOfQoORCSdoD9uvHAzug=; b=gYuNd7TyknIJ+4pwKjcOEa//UY98Ln144HPsK7FuSVJDZxvS+00iEOdOwuwY1v8jQu 0Xm1TcRW0aKYWsnxS2e0dhdUDeqiIoelfysZQSlV/JnnbkqeDEModCQYPrmZBcn7rAF8 nRcUa6Q2kxw974ERHqfXnPBZXnW07H7cRa8wUw30uedCh8qmW95ejSuvpyLopCgfB/Xk S4sYABQ8mNcoqpV0qrGa4kUhF0WNf5atNrj9OarKyVV24UgoEhQDFbdCEdqQug4erPe7 mBBne5GpGMrutc8DAI9HqLr1kiJTfMnMrZRMdzGEEgTpBTXPIjFOkWO5fYO5gaJ5gbGi 3RVg== X-Gm-Message-State: AC+VfDzo8uLUxbQqXBosxo6NNgr0dgAAbVofmKoUWzGIGnWN58ExX+T5 xuuK639V9+VtufSqM2/46UQnRLLmRyVTjDWhYznsB/xDDqAhZJfGfk5KVN3cm0WRnqfLKlotjLD +4H4Cw/FL/6b747Hka47nqwRJJg== X-Received: by 2002:a05:600c:22c1:b0:3f4:2d75:72e8 with SMTP id 1-20020a05600c22c100b003f42d7572e8mr2559140wmg.28.1683717643754; Wed, 10 May 2023 04:20:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5h2n3kt3+GCVYC5aAv0MOkqr3J1zLnqQ4IZZ0M1DbQOz2iX7cIRkYGH6ouY4prUPI49YfjlQ== X-Received: by 2002:a05:600c:22c1:b0:3f4:2d75:72e8 with SMTP id 1-20020a05600c22c100b003f42d7572e8mr2559128wmg.28.1683717643495; Wed, 10 May 2023 04:20:43 -0700 (PDT) Received: from [192.168.1.7] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id l2-20020a1c7902000000b003f195d540d9sm22261127wme.14.2023.05.10.04.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 04:20:43 -0700 (PDT) Message-ID: <993188ec-0507-1f4d-0adc-cffe3dc7119f@redhat.com> Date: Wed, 10 May 2023 12:20:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Vladimir Mezentsev , "binutils@sourceware.org" References: <3b4cae18-3c42-d8e1-517d-09463c270d4d@oracle.com> From: Nick Clifton Subject: Re: gprofng testing In-Reply-To: <3b4cae18-3c42-d8e1-517d-09463c270d4d@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Vladimir, > I want to add more tests for gprofng. That would be most appreciated. > These tests use pre-existing experiments and binaries. > Each test has a golden file which we compare against the new gprofng output. > > We never rebuilt the experiments and binaries. But sometimes we changed the golden file. > The size of experiments can be big. > The size of gold files is usually small. > > How to make such tests public? With difficulty. The size of the experiment files will be an obstacle I expect. Is it possible to instead provide a source file and have the test compile it first instead ? Assuming that the answer to that question is no, then is it possible to create smaller test cases, or to compress the test files files and then decompress them when they are being used ? My best suggestion would be to create lots of small tests rather than several large tests. If that is possible. > PS. > I see that the old gprof doesn't have tests inside binutils-gdb.git. How do we test gprof? We don't. :-( Gprof is very old and was added to the binutils long ago. Long before testsuites were invented. OK, so that is not quite true, testsuites have been around for as along as code has been around, but the gprof sources were added to the binutils without a testsuite and noone has seen fit to create one since. Of course if you are volunteering, I will not say "no"... Cheers Nick