From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150045.outbound.protection.outlook.com [40.107.15.45]) by sourceware.org (Postfix) with ESMTPS id 7AAD93858D28 for ; Thu, 18 Aug 2022 06:24:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7AAD93858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PAfdXlVhsjJVvOvLKNVres3eizUaTR9X30pJK89uUgF1Qtrow4HbdHdzchXGumutPbpXgEgwBV2fjn7YeS2S91Xg6Jdit14MXJH4EBZ2J4psw/2viTIcZ6jN8j2+Ks7N8iL5Xq9Rw9Y4mCphl+A/bL0jqOTjdsdhSyvI7DAgI+B5dfcJDw3XpQB3+h/ZjqrmMSY5RHsXnhXSow1XMCuf/bXOv8I1jT7ZCkwSpf3Htts1PHm3vpFxGE8NDhBr+4KY0badMZElh9xuEdh3aXuIowowXZ0WrlgeJUFme/P69SXyDEoCiRMTqPKQ8gWMYO6usnpGUq3LtcNOihjXxz9Ajw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eaum5qf7iXbPIyqjlZsawK+ymI1vtFH0qonbc8HnmvI=; b=J+/uYMY9cRRYhbISMlmGpNlFi28pHF12uJGYz6mcrqGoqkjR5L1m3JRHT94wqIAvCPK6Vc9dmYCXZJ//HPWnTScWmvuLWJCPWHlqX6YsRAqhQm7Nx3ysWbeq37ZAVzM+kZq97kIgTQb9cpUOhHF6fPAwuPQn4Yi9wIhBanmdFnHIec32AReEvLBCXrzoGz2b2PzoBsbGLXpNmdjJiisOlmB6WTjaAjHuXn56FsMQ0X7elQyrsbhDGkQdiks5TsZ7D3pT0PKr+uJSlyfdQSwyQiHg6RNqkX9qyD8ExAW1Z/nzXknOfkW00y5SZW/KRghIawlVKyaWXbs6kvGiiM3phQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9656.eurprd04.prod.outlook.com (2603:10a6:20b:478::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.27; Thu, 18 Aug 2022 06:24:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Thu, 18 Aug 2022 06:24:31 +0000 Message-ID: <995353db-27f3-ea60-8e69-32bcc44dfd49@suse.com> Date: Thu, 18 Aug 2022 08:24:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 5/7] x86: re-work insn/suffix recognition Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a6f1d14-f878-4ade-ad4e-08da80e24fdf X-MS-TrafficTypeDiagnostic: AS1PR04MB9656:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g368+AGQhH0QY0alhK5WYZ0Y/Xhp0gZJlcfpkWz/+jO+ncUPe/qwGhwNZPMm8EgX35T2C6bkeSxpezHLceiNHnb0qZbhGNiWI5pnIQPiqMZvwbNcrdrq4DbShKKDrBnaMBR3cJ+BVKtON3T8AiimomiQKRykkzdlyHnh96xSSpEwXJb1AiCPYvAKyAe1CIfav2OId5NG+nmnuCzGPjo/6NlCmIgMJ0g/58z+j1NmlnpuXJ9LYpNqBUgp3rMhiKtmwfC2G24LEWVdIpWiJehjEWO+62mptQRNoRq1xUr4+zrR0WiLD0ifmf2Hqug0mYLhfCYN1xMZCE3+7c5ihZ6qrMn8/N6ZjAzkuUyZDcWkdmtd8ScAYQX7fl8oPWO5Xx1vTBACuJnLmhXkKA4dNsHKphZajGh5VX90P83m49mAmMA89Tn5dxEgN79BJrmqZWQRO5h+5vART363+pG0QkrAc1lhVtewSw9c2B4oTZoYzni6LKXK4CG9+no7U54xZcP6XViN99YbUUCiycY4x8Em3ZSu6PV37bvjq6DlHQsY0SJynyiVpXpGInuzAiHX7azmno4+TFWh1kijE80O1VCKZiitd6bpdyAV/if0LZfpbkd3g9Gl9NByyzsXVCn2JwfZQca8tzMxzKBmIzTIuplrn0BalxDP8ICc+KNJuYSy85jKKKq+JKJ+a/sCEjHGAlsGIeW5KGayj9bKkM4El3Bxz9IfiaOzDFNR5OImwnDThMGd6r+1AgxhmBz3RSt9k3uejouJJ0o22ujNw367E5tSeamPrCdmG5inBjKTWvvt3rk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(39860400002)(396003)(366004)(136003)(376002)(31686004)(478600001)(38100700002)(316002)(6916009)(36756003)(2616005)(6512007)(6506007)(53546011)(186003)(26005)(6486002)(41300700001)(5660300002)(66946007)(8676002)(2906002)(4326008)(8936002)(66476007)(66556008)(83380400001)(86362001)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzJ4V2dIVjRHcGVmMVlwQlR5cHBvYjFOYW51cWl0YWNidTFJZW1oMGdSWmd2?= =?utf-8?B?bFNKUnBWZVdyamdsMTA0a1RKSHNsUEpaQnE5bFIva05uSjBtMU10RERLYnps?= =?utf-8?B?ci9YVGowcnBRRjdybWIyVEpua053V3dpVGZlZE4zV1o1UUFvL0NEV04yWWJu?= =?utf-8?B?c2xwMysrOXdsaFFlckxXSit3YkQvSE90bVpzQ3RiT1JsczMvMEZYVURVK1Rx?= =?utf-8?B?WnJVYzd3ZUlsZVZ1aVhZdmZOZmdqaGJlTmYzaTJJcTZPd3N6ek5pb2M0dGVl?= =?utf-8?B?cmlZOGM2VW9lTVZEVVRJekZ3c054bmpUdDRJMVlRMWEyaXFJZURKNkFtVWNE?= =?utf-8?B?ckRVS1V4dS9Sd1Z3OU9lNjg3ZEhSUWVVSUdZY1V2M2RBQnpqdFI3eWJIRE1Z?= =?utf-8?B?RndiMThBb2FSclE0NW5aRGRRNHAzVWhrV09FTnltTzRXMmc5b01oVit1bjF1?= =?utf-8?B?WjFRQkt4U0FnOFhVRmNWeHo1Tk0vVys0TVpMbkdZc05oNllFWGs3cklLRnRm?= =?utf-8?B?YUFmc2V6OUdYTlVqcklrQkRWbTRiZmpHc1VXRjQ5L2JSZGR2cit3RVZ4YWtu?= =?utf-8?B?MUlsd2VVR2pyZUhXdVNRSlZPMllwOTRBN1Azc0RESlN4aEpoeTczdDhpNWJN?= =?utf-8?B?bVpLNW84Q3RyRHdxL1NVTC9GM2tvUzBXeDhjNHhsNHl1Wlp1ZTN5bXBsVFVl?= =?utf-8?B?bkNJekZpc2k5Z2RUUzd5dUhTYU5yQzFKeUpETmJ2L1JtczJrMTVSaGdFMHds?= =?utf-8?B?VVNjMU9QL3E4Q3FpZ0kwdUFLdTVKUmRvMWFHZVNCNzc4RHpNMXRVL00xdUs5?= =?utf-8?B?MGdmNzJKQUFZOEhQYmJwRTVMa2ZYT0VFaS9wWUpocW5ZdDV6SHlqdWdQS043?= =?utf-8?B?Zyt2a2Q1aXY4V0dSYVFvWFBRZmxUL0JRSkJHZWsvaklISU5PSWVqQytTdU5T?= =?utf-8?B?U1hFRzZJWWZnWjYxenBsRk9GWXVBaGxPczVsOForM0pPWSs0ZzlQQ3IxeWR6?= =?utf-8?B?SmxQQXVRZVlqRk42YUdvMjlydlF3YXh3ZEJGczlDUms2NlpCQ1FxSGZzWW9n?= =?utf-8?B?aXFTb0Z1SFpReHBJSXRSVzg0NUNYcE94TnQ5b283cGNVOGZpZWVZRHJSazVo?= =?utf-8?B?VGx2bVhuWlN2bjlqeEsxcHZPNUNUSElLVEVNS25GWm5LNzBnMDIwcnRrajVU?= =?utf-8?B?eWdBT0dxRFdVcG0xdGFGQUNhWEpoRktvWlNFTmpSR2hNczhOeEZKYkt5SUw5?= =?utf-8?B?T1NSZHd4YTZrcmlQYUI0OUpoMEQzMzJBTktRd0xFemJZbk9sOTJPcDZzYWZX?= =?utf-8?B?amRsVkc4cm5peEpZM3hBUWdBNTgrV3RXdDFJaGMyT25UWFFrSXdzZ1BTN3Vo?= =?utf-8?B?NW50Q1lFdk5sMm5YQVFRMXJLdUh0MGtkWXIyS2l6cFNVMEdLRXhmNnFFaEdx?= =?utf-8?B?Zk14ck5sTUFpU0dxdUhJbnNYUUd4Sjl0MDMzalplZFB1TEJpWWpXd3ZaMVBZ?= =?utf-8?B?TFArbXV3TFJXU2NkWHNOWHY1TGJsOHljMGxKbTByVk94VUwyVTNzVmtoQjVK?= =?utf-8?B?MFBRUkdqdVlDSUlNNVh1bUl4ZXk1bjkwQ0o3U0VRMDc5KzByTkZpbStuWnFz?= =?utf-8?B?ZHhtcmN0VEtrSTVNVVBJd29JVElUVHRES3crOVM3OElpUG03d045MUZqQUcx?= =?utf-8?B?ZEVieHpTZVkrWkpDdk9haDMwTUhWeDFTeXpHejFhYTYvWHQ4cTc1L2ZkcWJx?= =?utf-8?B?bEY5YzhlN2NOQ0toYlByMGZoVHdKYUQ2b2lXNFdreHJWaVpPT2YzMThpSytH?= =?utf-8?B?YVhpWHRLMWRaN0ViY1U1RVZWbVM0bmFJQmN1ZUZBNkJIOHNBVUN5TUcyZGdV?= =?utf-8?B?dCs1L3hOWHJWbVZTMUsrTWY3RWhNZkJoV1BYMjg4UHMrZ0tRRVAyTU9QZVdH?= =?utf-8?B?aXZnUWdnVWIyWW9PNC80b09MU3FicDY1VlVHRDVHWEgvOURtY3Zub3pxQXZE?= =?utf-8?B?TWFKN1RETXBLMTEwaTBudTVuTHZYMmJKV2RmQ3RMK2puSmt5N2prSktiL2kr?= =?utf-8?B?VzB5TitoQmJTUXlpWThPWXdTZXd3UlVYM3lxNG9pdEVremF0ZWx4TXhQSk5D?= =?utf-8?Q?r/oLE/lJM8d2b88xwI+x+vlvL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a6f1d14-f878-4ade-ad4e-08da80e24fdf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 06:24:31.8619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GTshWcnM2NIkVu6myDrxJ/O7IWAeC/tTjin8lNun0IQ+lQTAcQvO6yUeKWdeSffV3jycTxS9600CGYuPl+UWJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9656 X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 06:24:36 -0000 On 17.08.2022 22:29, H.J. Lu wrote: > On Tue, Aug 16, 2022 at 12:32 AM Jan Beulich wrote: >> >> x86: re-work insn/suffix recognition >> >> Having templates with a suffix explicitly present has always been >> quirky. Introduce a 2nd matching pass in case the 1st one couldn't find > > I don't like the second pass. What problem does it solve? It addresses the reasons we have various pretty odd (and confusing by their mere presence) insn templates which better would never have been there. If you have a better suggestion to eliminate those, I'm all ears. You can also easily see the issues this solves by looking at the testsuite changes. Among other things this once again is a matter of providing consistent and hence predictable behavior. Further this sets the stage for the subsequent two changes, which I don't think are easily possible without this 2nd pass. And finally you've likely spotted that this is actually a reduction in code size, first and foremost because the odd maybe_adjust_templates() can now go away. Plus I think you realize that the 2nd pass wouldn't be engaged in many cases - it requires a template match failure in the 1st pass, after all, which isn't going to happen very often. Jan