From: Eric Christopher <echristo@redhat.com>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Fix handling of R_MIPS_PC16 relocations
Date: Thu, 06 Sep 2001 21:45:00 -0000 [thread overview]
Message-ID: <999837908.1188.41.camel@ghostwheel.cygnus.com> (raw)
In-Reply-To: <20010907005955.K2210@rembrandt.csv.ica.uni-stuttgart.de>
>
>
> 2001-09-07 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /bfd/ChangeLog
> * elf32-mips.c (mips_elf_calculate_relocation): Fix overflow handling
> of R_MIPS_PC16.
>
> /gas/ChangeLog
> * config/tc-mips.c (append_insn): Handle BFD_RELOC_16_PCREL.
> (macro_build): Use BFD_RELOC_16_PCREL_S2 only for embedded
> PIC, BFD_RELOC_16_PCREL for the rest.
> (mips_ip): Likewise.
> (md_pcrel_from): return the right offset for the differently shifted
> pcrel relocs.
> (md_apply_fix): Handle BFD_RELOC_16_PCREL.
>
> /gas/testsuite/ChangeLog
> * gas/mips/beq.d: Check branches to external labels.
> * gas/mips/beq.s: Likewise.
> * gas/mips/bge.d: Likewise.
> * gas/mips/bge.s: Likewise.
> * gas/mips/bgeu.d: Likewise.
> * gas/mips/bgeu.s: Likewise.
> * gas/mips/blt.d: Likewise.
> * gas/mips/blt.s: Likewise.
> * gas/mips/bltu.d: Likewise.
> * gas/mips/bltu.s: Likewise.
> * gas/mips/elempic.d: Switch from R_MIPS_GNU_REL16_S2 to R_MIPS_PC16.
> * gas/mips/empic.d: Likewise.
> * gas/mips/empic.s: Likewise.
> * gas/mips/telempic.d: Likewise.
> * gas/mips/tempic.d: Likewise.
>
Looks right. Go ahead.
-eric
--
Look out behind you!
next prev parent reply other threads:[~2001-09-06 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-26 14:30 Thiemo Seufer
2001-09-06 16:00 ` Thiemo Seufer
2001-09-06 21:45 ` Eric Christopher [this message]
2001-09-12 8:40 ` Maciej W. Rozycki
2001-09-12 11:31 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=999837908.1188.41.camel@ghostwheel.cygnus.com \
--to=echristo@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).