From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] gprofng: 30889 can't compile without large file support
Date: Thu, 11 Jan 2024 00:09:47 -0800 [thread overview]
Message-ID: <99e8ced4-6acb-4100-a34b-3374b7024c94@oracle.com> (raw)
In-Reply-To: <ZZ-CRVVt53_Lpgw4@vapier>
On 1/10/24 21:53, Mike Frysinger wrote:
> On 10 Jan 2024 20:02, vladimir.mezentsev@oracle.com wrote:
>> gprofng/ChangeLog
>> 2024-01-10 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>
>> PR 30889
>> * src/DbeJarFile.cc (O_LARGEFILE): Define to 0, if not defined.
>> * src/Module.cc (O_LARGEFILE): Likewise.
>> * src/gp-display-src.cc (O_LARGEFILE): Likewise.
> can't you put this in a single header file (gprof.h?) instead of duplicating
> the boilerplate in a bunch of files ?
Mike, thank you for suggestion.
I will try this tomorrow.
Maybe this can be done in gprofng/configure.ac and
gprofng/common/config.h.in
-Vladimir
> -mike
next prev parent reply other threads:[~2024-01-11 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 4:02 vladimir.mezentsev
2024-01-11 5:53 ` Mike Frysinger
2024-01-11 8:09 ` Vladimir Mezentsev [this message]
2024-01-12 4:10 vladimir.mezentsev
2024-01-12 9:20 ` Andreas Schwab
2024-01-12 19:49 ` Vladimir Mezentsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99e8ced4-6acb-4100-a34b-3374b7024c94@oracle.com \
--to=vladimir.mezentsev@oracle.com \
--cc=binutils@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).