From: Tristan Gingold <gingold@adacore.com>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils Development <binutils@sourceware.org>
Subject: Re: Ping [Patch v2] bfd elfxx-ia64: share code between elf32 and elf64
Date: Tue, 24 May 2011 14:17:00 -0000 [thread overview]
Message-ID: <9C0F5E39-7514-4996-AA9B-26478EEAAD79@adacore.com> (raw)
In-Reply-To: <4DDBB7CD.40902@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2492 bytes --]
On May 24, 2011, at 3:51 PM, Nick Clifton wrote:
Hi,
>> Ping for:
>>> patch reworked. Much bigger but much cleaner too, so attached.
>>> No regressions on linux/ia64 and hpux/ia64.
>
> When I tried this I found some build errors for my all-64 target (configured with --enable-64bit-bfd --enable-targets=all):
>
> bfd/elfnn-ia64.c: In function 'elfNN_ia64_info_to_howto':
> bfd/elfnn-ia64.c:215:5: error: implicit declaration of function 'ELFNN_R_TYPE'
> bfd/elfnn-ia64.c: At top level:
> bfd/elfnn-ia64.c:278:1: error: no previous prototype for 'bfd_elfNN_ia64_after_parse'
>
> And so on. Please could you check this locally and assuming that it happens for you too, fix it ?
Argh, sorry. I added the wrong files to BFD64_BACKENDS. Thank you for catching that.
Attached is the corrected patch.
Tristan.
bfd/
2011-05-17 Tristan Gingold <gingold@adacore.com>
* configure.in (bfd_elf32_ia64_big_vec, bfd_elf32_ia64_hpux_big_vec)
(bfd_elf64_ia64_big_vec, bfd_elf64_ia64_hpux_big_vec)
(bfd_elf64_ia64_little_vec, bfd_elf64_ia64_vms_vec): Add elfxx-ia64.lo
* Makefile.am (BFD64_BACKENDS): Add elfxx-ia64.lo
(BFD64_BACKENDS_CFILES): Add elfxx-ia64.c
(elf32-ia64.c): Created from elfnn-ia64.c
(elf64-ia64.c): Likewise.
* elfxx-ia64.h: New file.
* elfxx-ia64.c: Split with elfnn-ia64.c. Keep only the following
functions.Includes elfxx-ia64.h.
(elfNN_ia64_reloc): Renames to ia64_elf_reloc. Adjust error message.
(IA64_HOWTO): Adjust.
(lookup_howto): Renames to ia64_elf_lookup_howto. Make it public.
(elfNN_ia64_reloc_type_lookup): Renames to
ia64_elf_reloc_type_lookup. Make it public. Adjust calls.
(elfNN_ia64_reloc_name_lookup): Renames to
ia64_elf_reloc_name_lookup. Make it public.
(elfNN_ia64_relax_br): Renames to ia64_elf_relax_br. Make it public.
(elfNN_ia64_relax_brl): Renames to ia64_elf_relax_brl. Make it
public.
(elfNN_ia64_relax_ldxmov): Renames to ia64_elf_relax_ldxmov.
Move it and make it public. Move prototype to elfxx-ia64.h
(elfNN_ia64_install_value): Renames to ia64_elf_install_value.
Move prototype to elfxx-ia64.h
* elfnn-ia64.c: New file, split from elfxx-ia64.c.
(elfNN_ia64_info_to_howto): Adjust calls.
(elfNN_ia64_relax_section): Adjust calls.
(count_dyn_reloc): Fix typo.
(elfNN_ia64_relocate_section): Adjust calls.
(elfNN_ia64_finish_dynamic_symbol): Likewise.
(bfd_elfNN_bfd_reloc_type_lookup)
(bfd_elfNN_bfd_reloc_name_lookup): Adjust macros.
[-- Attachment #2: ia64.diff.bz2 --]
[-- Type: application/x-bzip2, Size: 46421 bytes --]
next prev parent reply other threads:[~2011-05-24 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 12:56 [Patch] " Tristan Gingold
2011-05-17 13:04 ` H.J. Lu
2011-05-17 13:10 ` Tristan Gingold
2011-05-17 13:15 ` H.J. Lu
2011-05-17 15:12 ` [Patch v2] " Tristan Gingold
2011-05-23 8:00 ` Ping " Tristan Gingold
2011-05-24 13:50 ` Nick Clifton
2011-05-24 14:17 ` Tristan Gingold [this message]
2011-05-25 8:07 ` Nick Clifton
2011-05-25 12:03 ` Tristan Gingold
2011-07-05 19:06 ` Aurelien Jarno
2011-07-06 7:00 ` Tristan Gingold
2011-07-09 18:18 ` Aurelien Jarno
2011-07-10 11:53 ` Andreas Schwab
2011-07-11 16:20 ` H.J. Lu
2011-07-25 13:35 ` Tristan Gingold
2011-05-17 13:08 ` [Patch] " Andreas Schwab
2011-05-17 13:11 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9C0F5E39-7514-4996-AA9B-26478EEAAD79@adacore.com \
--to=gingold@adacore.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).