From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 6F6FE383CCCB for ; Wed, 31 Aug 2022 01:49:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F6FE383CCCB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x432.google.com with SMTP id z187so13047614pfb.12 for ; Tue, 30 Aug 2022 18:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=h9X+pyfRMf2Tpd5mN6AebgiqBIVaJ6H1uFOFS6Zv/oI=; b=PGk0jxUp7GyJW+XRz0HPu87NLtVyjP8jRfWEdR5CD/lqQNIaKC1ZZ2e6c6X+cvUm0s R+Yy3DlSNC3lOThhZgPdVlevu57LFvXioHqPKFzMmSMOfEs9fm47oUtgWtE6zTCcqqKx bMLzw2zKI3kBpaDmAcG/ZS1rTc4ppt+kMqqGVYU+Y92EyO6iDPZL8TyTA6OdcdpDdaq2 jqAYPnkn/oXR0j++EK9JFVsFZDFdKnK0wKupDlr/YNrDD86eFmvZ0KLGOHO1FT1m1UUe 9Gs9yoTmj47l+ma1Hh21rDjNoqStwbUuyBrt0dao+rPrF5fG49+9vYe13lGvms3tYrG0 iLjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=h9X+pyfRMf2Tpd5mN6AebgiqBIVaJ6H1uFOFS6Zv/oI=; b=M7JPn/YdPLjJ6NDjLo7eVq0o3OijRAd9pPis4d/yXqMZoTc+ZyMf+EhqjmMPcsmqzq 1qu1UzMAfIb1dqGBjz5O2fxVIwEtXBIIVMNNBi/5SPCmzJkys4rfi1B2B55D3XaMzw9k dLVUIYyRXBUTBVFu9w/g+FLrDkorHEZtsj6ws4xbIKBW/tXYvQ2SnZoWEsdAay/whdbF 1EUeJS37xdn4dLgUgGmamLP55b8Hyz0xQSdzW04KAEFH9yWY9QFCHryegOOxgzKlPMEf BrYhW5+/ZwQNX3Ld+I7qGxeyAzdNwt8jqwcq0EgeRFaL6aWbXojEFrbCacpLOcwSjyk1 KFNA== X-Gm-Message-State: ACgBeo35+/9O5MAQI8Z1wdY023uJJh949308vUx5oiV6CoyfiZI+75Nt BG/rZyVMWPUSclWOovsGHCyjSvAkYjbMRg== X-Google-Smtp-Source: AA6agR7Ph/aNAiDM21bvJ5pFpUUJ2BgfFj/0520NsgMxzFD1nByHeSbtAmD5TaFlYY9myy+8f2HloQ== X-Received: by 2002:a63:6b02:0:b0:422:7cf8:4bf with SMTP id g2-20020a636b02000000b004227cf804bfmr20742392pgc.92.1661910572441; Tue, 30 Aug 2022 18:49:32 -0700 (PDT) Received: from ?IPV6:2408:8409:1850:2735:4c0d:d896:9d6f:af6e? ([2408:8409:1850:2735:4c0d:d896:9d6f:af6e]) by smtp.gmail.com with ESMTPSA id t20-20020a62d154000000b0052dbad1ea2esm9949153pfl.6.2022.08.30.18.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 18:49:32 -0700 (PDT) Message-ID: <9a19e936-a692-8996-93c7-cb872dc0f76c@gmail.com> Date: Wed, 31 Aug 2022 09:49:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] opcodes/loongarch: correct parse_loongarch_dis_option Content-Language: en-US To: liuzhensong , binutils@sourceware.org References: <852eda61-962e-5ef0-eb1c-304d23ad7f33@gmail.com> From: Iru Cai In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: parse_loongarch_dis_option() should return 0 when parsing a valid option, which makes parse_loongarch_dis_options() continue parsing and free the xmalloc'd memory. ---  opcodes/loongarch-dis.c | 5 ++++-  1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/opcodes/loongarch-dis.c b/opcodes/loongarch-dis.c index 9dcf989d0df..51c1f64edb5 100644 --- a/opcodes/loongarch-dis.c +++ b/opcodes/loongarch-dis.c @@ -92,7 +92,10 @@ parse_loongarch_dis_option (const char *option)        loongarch_r_disname = loongarch_r_normal_name;        loongarch_f_disname = loongarch_f_normal_name;      } -  return -1; +  else +    return -1; + +  return 0;  }  static int -- 2.37.2 On 2022/8/30 15:15, liuzhensong wrote: > > The format of this patch seems not a unified diff output, can not be > patched directly. Do you mind remake? >