From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2074.outbound.protection.outlook.com [40.107.249.74]) by sourceware.org (Postfix) with ESMTPS id A2F56385383D for ; Fri, 14 Oct 2022 13:53:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2F56385383D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/B/d2JVTZWVPKtG2eQ7wUgid2l+ph5UiqE9+WSy2CeYeItyDRLE+xYK60AnlGJqsIsYWibo8ZeRcDmDJEIerZQsbRh/sRtogEaHQuyZtiQ7CpLYISB42hSh/rHvDsHRfUNvCKwHxHQa7fwcdK6YWXup0nqOSCaLDvCHW6efViDGtX9oyQRk1nAjC/lDP9C9BhZ7ZH+ZTCaEhIqWMF5d9MdB+lXrNL8Q5a0LAlUzFMvwlZYltaJp/e2kKyYwZWInsaCSEKex8t+bHwnXrAyvKrMn+detayKIboAnrlg3KnR1kXPTSaiyMZg4lAbNy+gB77ZJ6nDp607T4Z9rzWqocQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=42Ol0Auku2ufGG+ZLabQxClJ0iiKtBQYPb5F+tonwPY=; b=JtFAc8THtUKYfXeltdPwz0ZfdsGxi76qtwbLAMZ2ZCxWuMm6YJ4nfx3GzhrDrF7GhqDcPaD5YWQT4yiuuV2qQJXbnZL5DSkXBs5AMSV8UFFVhOz819CS9ltzhaNs3xCSfIrHHyE+2HmOgY4l09f4cLyvtUUUjkRLoAB6wGI/TbPae5KVgo7dxHxGjax1nYBwmAdsUaelPgQQfUld/DuGMErrW/X7Hc+p/wXuM6xjbsShvlrC6OJR9Xj4s8OnlP3RoC2zpZ5FB8mueq1zptEglsWcPEID5bkqn5EaMSOm93OL0flUv39woYX1S36OUJvM7OFcqvgiHck6+dyXupkmMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=42Ol0Auku2ufGG+ZLabQxClJ0iiKtBQYPb5F+tonwPY=; b=VAtVHR7aeGhiF/r3dCpex6iqJ24Glqm6dAKPU4uXXWcZPgyXNXBAfmZDen+NvJbmh3Fgl4nX7BH8p9T0BhKIEuXR3zZ3BmaSx5m+O1OoPm73MUxIcX4VcW+6U+qriFHHat/h5V+x2wUOWFtuwcm0fD6MNbyVPxxYWyn+XTg+QElRkTfaViTVpoMdIBxVWv/khv8R7uaPKWYbIPh3YifsmXD0/Gv0gMEn9E7flvEpopA6OFGoOwvQDniVWtGrQLwA4UHfoRVdyzRjtBzWTiCDf9Sn973vRYX6Aa/ca/ptXIiZPXaYG+7UNLjWjfO5pX4rwwpWd9tR43pMXPg8snwNMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7733.eurprd04.prod.outlook.com (2603:10a6:20b:288::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 13:53:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 13:53:32 +0000 Message-ID: <9a7ccb18-082d-18ff-c91b-e9368bb9484f@suse.com> Date: Fri, 14 Oct 2022 15:53:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 05/10] Add handler for more i386_cpu_flags Content-Language: en-US To: Haochen Jiang Cc: hjl.tools@gmail.com, Kong Lingling , binutils@sourceware.org References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-6-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: <20221014091248.4920-6-haochen.jiang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7733:EE_ X-MS-Office365-Filtering-Correlation-Id: ea77c96c-4cda-43cc-84c6-08daadeb7b1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v+l52H9bQAGWzMYOo4Ixywa510jNW4xnjqcNWMK0dKzbfyy4Fs+4eX5sMxGyDsSodsiHYpFiCXGB9fqI+Lbo/A0hZnyg1n/EY3T5HzfpqkT9qemlFDQDR0W/8gBGuoO/iXAmsza7O3CXTRPEefiwNAFoRFWFI+3rsF2ECgC77bp86uL3XGuDpLiwrhZwle5tefBVH3V/20drzqqTumnq+JcQNqS1KGM3bpH1mdANOMFsiRsVuZ1egwf0Z45VNXsoEOOcLi5FbULcsAT3kZqQKVkocqVCREy/v2POdG0I0zqpTLmPb3+rwmMDyzbnjrRjvJh5FRuOS/QwoItJO3U3sMykMC6kgKTpNih6bVIDTCnju0fU+wb9ESNItwqCtuapBI3URofDj6c9qhHKhMI3eOqXALXwH0GAnBf6rpo1kep5HdTAnocgGSE9R09gBJfKD4Sjc1Ky8R6xdNLkYg1uDyAXgKdzbjLOlV/QbOj6azBmYSeNGquo+anyA9d1Vupvz0D2D+3cTAnu9zgw6r54eM0FpbQA+EIOY8XH0eCb5vezAU6CpsFc/FMt/elFvyGuFTBdN7tcy6Zr1YwyK5zaj70l7Bj0046AB2CqoF7q6TsB1jXBq43l9YfKsrm1qN3jd0xOIGvt7ts3LS273RfgsGGmBg5ix4Oa7MqRyy1eh8HyicAPGKO/aJHq+5eS2LhaZXZhE6U3z34/WqOUsOHKVACAHj1lREev8+h/OJMwLQJjFSi8vWnn/0Y2By95EH24an/+iVUgZ1M9vvjjTkBbUj4SPoVasBLTPCDVhWprQCw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(346002)(39860400002)(366004)(136003)(451199015)(6512007)(316002)(2616005)(4326008)(8676002)(2906002)(36756003)(41300700001)(26005)(53546011)(83380400001)(6916009)(6486002)(6506007)(8936002)(5660300002)(66946007)(31686004)(186003)(31696002)(66556008)(478600001)(38100700002)(66476007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkljZU5KQ3NPRFBONUg0UGgzV1VWL2xtNVowaENMbUpuMms1c2hzMlNyMlp4?= =?utf-8?B?Szhrci9aUVRsekFKMDBlVU9kUjdCQVpSUjZFVEtJVGJPbjFEN1UrU2krbjI2?= =?utf-8?B?OXRaVHpra0xUUnR3Skp4bnA2R21iandTT3BHWHVOYVhvZmw2NytQTHNwRzBM?= =?utf-8?B?a0NSdnhpS2JFWGZxMjdwRVI3MGM5Rk1BNVpCZ2QzYzE2cWl5ZmdobzBTSVE3?= =?utf-8?B?alBpcExERDFHUWxWYXl5V1k1R2VCR0pBenUzc0M1V0c4eXRlWndtNFhRT0Ev?= =?utf-8?B?bHFiVXd2QUtrZHVPamVRVzY3dFVwKzhNSUdZcGhoVDk0b2poT3ErcmQzajY2?= =?utf-8?B?djRNY0hVZWlXV1lIMjc3eW5RV3dWRlFlUmdOY2p0RDI3KzFZVVZaNGF3cTNT?= =?utf-8?B?U3h1cW1zanZIemx3N29qamFLM0hBTE43enhvWHhLMXc0UUxnOHpvdmEvTnow?= =?utf-8?B?M0xYM0lKVDN4TVcwbi9yclFkdGpERWdlZkxUVVJzS1RTbWY4M2Fydkt0aXhB?= =?utf-8?B?TXF2Q0NST1VreUdTNHk2RTVyQVRBRXR5ODgrc2RLUnd1VHpHSzBUZ0Q0U3Ey?= =?utf-8?B?RDNhRDE5dzY2cUExUml4T002dkorbkNlSkZnWVA1OTcwOFJBNTlHU1Z4S3k1?= =?utf-8?B?SldRZ095OTdjMzFkSGR2LzBSR0dRem9VVUZrWUpOSHVmMGYzdnYzVHRCTEkz?= =?utf-8?B?UytBTTBXTlo4UWgyQWhxQmtjTHZha2Fhb2N3c3F5dVdwTlVremI4TzBPZ1Nt?= =?utf-8?B?Tzdzb2pCMmFqMnhLN0YwR3FuN2d3cUhqK3JjZVV3SmlITVpuSlFuc1NDSEFr?= =?utf-8?B?akxaZytpeFdocUJXKzRTdjJ3MjF3ZldPUitYZjlGZXh3am0xNE00T3FtdStH?= =?utf-8?B?TzEzYlRoVEtLQTIvRmh5SUsvM2RWbFNvQW5zVS9FZVFSenBCZzFBc3JwUEJo?= =?utf-8?B?WHFJc29pakY5dndIYkRJa01pcVJhQjdpekRuMXFqdW1EVlpMdXFrVk4zZDNG?= =?utf-8?B?VXpXeWlqTm5nc0U0eWtxbjNNV0M3clRiT2FFS3V2QkpzUHJzMXo0ZG1hUENU?= =?utf-8?B?RjQrOGloWkllc2tqSThEcXNCQTVXakI2b2hPL2JZRzRzQmVGcUJVZ0ZWbm9O?= =?utf-8?B?dGx5cFdwZ0NXbnU2WGtQMGt3WW5oK1lEVHh0OHluTHpEeVdodExWaGVxZEtC?= =?utf-8?B?NVFJRmZFb3Z2NnBnYnptTVNUNXE3bDA0ZVNHWXEzQWQ5azNtb3hzbjVLTGFu?= =?utf-8?B?c01YRWUwdVVoZ0p2djkvVkp4ZTZJZTFPNWkvVS9iZElkYkxOVCtjamkzWjk2?= =?utf-8?B?SlhpYkd6NmlKWktYWldqQUo0bDJKZDIxemhVdC9BL2RxZWs2eWtqMkRqSjdz?= =?utf-8?B?YXpqN3A0QzU5dEZxaVdVYnVXL1VFNkFURWk4UStEaTZOUTI3WktQeU9RMXZr?= =?utf-8?B?b0RZUlZaUVpkSjFhVGw4RFhyMFBiNzVkdU1FWmRiLzdQREpVNFNrUlR5WnpO?= =?utf-8?B?K0Y2aUtraEpUaUpPUDZjTFIwbDYxUllzZjg0UWJHb3VsQnBRancwUkJaQldX?= =?utf-8?B?SS9EeHd3bUZpWTRudzBTYmtNSk9KM0twRXJRRXIrUHlDMk5xUFlBZUVhNVp5?= =?utf-8?B?ajYycnU4Ykh1Z0Zjc0NZbzF4MmtsYnRzdmF3VExHNGFqUkozYkE4YmNIcTBF?= =?utf-8?B?TGNVcEVFQTduOUhIc0hxRTgzTWxCVG8rOFVRbmsxSlhwTCtuS0pPT1V6d2h3?= =?utf-8?B?RUdlN0NmOGl4VFBMYnJZUHFOLzNjbFU4MFF3Zk81S0w4aUN6b2tBUnFNVkpm?= =?utf-8?B?bGlaS0R1M2krb2RkR1ROYzhhQmRNT0p2VjdKWktEeHJKWWxjT3BhMjlieHNI?= =?utf-8?B?OW1Qb2JUbloxVW5oWWUwb3VZUE5iYU9qWEdpdDkvNFZkRE10TzI4NzB4ekc3?= =?utf-8?B?RUZ2VmJoUVdhdExSRjM3OTBTZThoMU4xM3FmV1NVNmgyUklPdUlCMEhPZGhw?= =?utf-8?B?dnFDb2VjbXZ4RFJQZUZRQWlwRkQ3TlRCQndqUjJRWlpOS3RVR25mTnFyUW40?= =?utf-8?B?SXVTVHBzcUtDRmFkMHEzdFllTDhQZXlnOWdlQ2RVOHVGMGl4clRSbHJjNWpZ?= =?utf-8?Q?suJt6xRSqfoz9Th/lY6R/memr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea77c96c-4cda-43cc-84c6-08daadeb7b1b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 13:53:32.2073 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yoVw+BHlk0beWErIbPPkRLow1UDj/8t4zN8GMGcPuPx0Q2CDR4fcvbgo775h6W2MHTLinDP4tynPE1cD7lnbMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7733 X-Spam-Status: No, score=-3037.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.10.2022 11:12, Haochen Jiang wrote: > From: Kong Lingling > > gas/ChangeLog: > > * config/tc-i386.c (cpu_flags_all_zero): Add new ARRAY_SIZE handle. > (cpu_flags_equal): Ditto. > (cpu_flags_and): Ditto. > (cpu_flags_or): Ditto. > (cpu_flags_and_not): Ditto. > --- > gas/config/tc-i386.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c > index 0d161d60ef..7045e18cff 100644 > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -1618,6 +1618,10 @@ cpu_flags_all_zero (const union i386_cpu_flags *x) > { > switch (ARRAY_SIZE(x->array)) > { > + case 5: > + if (x->array[4]) > + return 0; > + /* Fall through. */ > case 4: > if (x->array[3]) > return 0; > @@ -1643,6 +1647,10 @@ cpu_flags_equal (const union i386_cpu_flags *x, > { > switch (ARRAY_SIZE(x->array)) > { > + case 5: > + if (x->array[4] != y->array[4]) > + return 0; > + /* Fall through. */ > case 4: > if (x->array[3] != y->array[3]) > return 0; > @@ -1675,6 +1683,9 @@ cpu_flags_and (i386_cpu_flags x, i386_cpu_flags y) > { > switch (ARRAY_SIZE (x.array)) > { > + case 5: > + x.array [4] &= y.array [4]; > + /* Fall through. */ > case 4: > x.array [3] &= y.array [3]; > /* Fall through. */ > @@ -1698,6 +1709,9 @@ cpu_flags_or (i386_cpu_flags x, i386_cpu_flags y) > { > switch (ARRAY_SIZE (x.array)) > { > + case 5: > + x.array [4] |= y.array [4]; > + /* Fall through. */ > case 4: > x.array [3] |= y.array [3]; > /* Fall through. */ > @@ -1721,6 +1735,9 @@ cpu_flags_and_not (i386_cpu_flags x, i386_cpu_flags y) > { > switch (ARRAY_SIZE (x.array)) > { > + case 5: > + x.array [4] &= ~y.array [4]; > + /* Fall through. */ > case 4: > x.array [3] &= ~y.array [3]; > /* Fall through. */ Not a request for action on your part, but it is high time for us to sort this requirement of widening the bitmap by one bit for each and every new ISA extension. I have some vague plan, but I need to find time to actually try it out. Jan