From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id B496C3858C53 for ; Thu, 4 Jan 2024 08:57:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B496C3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B496C3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704358652; cv=none; b=M1yIp98BS2L8RuiaXliIUHqlKgUzIKkdxvFlz7JMfVfdZ+youiVDqXRCHxEiLMr8NPDVjdJO78lKBcpGJSrXySbFx2ClEyDBIE1bM+MlYxtGPud9sK/1oRqGEZkzp253rOBG2RXvdPCI0o1bcsKQrKjbg6UxpogW/7EyPv40RXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704358652; c=relaxed/simple; bh=5lLGWDhEQRFZ2PDIiInkGqlQMMkOYob8HAYYbkahs6Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pgcba26z0rKIv8L+hbE90fZ6dSmYcZdFTDXF0ikw4SlA208itbtYGIxrdMUCJSu4tWMIAyUqUfUsyYjoc2nQDRf+410VVYpuGZmu9RXrccu5OEVG2A+FjinXF4xmXp4MyrFN29qRgsxQ0HFH+9SC0T+9UbeWAokycLYSR+5Q2Xo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2cc6b5a8364so3231881fa.2 for ; Thu, 04 Jan 2024 00:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704358644; x=1704963444; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aFAWeZRfqfzvu5MSF9dWm7q8FtG7YYSnAdS2ToQd028=; b=KaXAp5WcisKSjHBIHs109sGH2bLCNs4JGU8JpHlnnWDQnOsfPwvH5onn2C5mg9EXFr 5lLqbHOVvOVF/9PseigTJ1BpkCfmawr9nqT7RP1h4+/5nHV/gdUD2UmW1ZsPoUprpD+r UoOe0RZUUInESkfJ/4Zx3z7fYR4dxjmuzm61n8NqGqk4L+NokXQmR1k2zg7jnmh2RAjX 8UOfOZsYNh12Wr1neVFZgg/Gv8S8Jkt9vBP4FwMfalFWgPi56PCSYcSsGHW1K0UaO5GV /9iRDax7k+ynZ7FinB3Bd0lX9C55Q67FYmkW2sAJEZYYN/c13bTuhRCRJMgquNoM6+Z2 S0rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704358644; x=1704963444; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aFAWeZRfqfzvu5MSF9dWm7q8FtG7YYSnAdS2ToQd028=; b=Hzg3x+PWfG766pxSeVVTa1Gq7kZOKo84W16jnOfzIZWzuwikC9kj0oX25Otlexm/P0 yA6TZVKeHs7wlnAAYpplcKetMR6aVP5JILlRJb0KYN8esqnQav4eJEPgm2aMweeMp1Cg Aru3C65GgxpvkBZD4AkzGMBcHgGg3ncXqY/ZK6NnkqZGFUu7f39EzGOuWXRHO34nUIYc fOXi4lc6S11hq4vMckWD987Mt/6b4rUvJUv8qJ7iCzklUUCXDqEwTNRNZ+YhE9JLDOGg TtMd0s1Dkuxn/VbO5OtUVCqR+xdqr4rolTbuf+4Z5B3cTc9jHLQ9+fENPC0I0W22H7s+ 8FHw== X-Gm-Message-State: AOJu0Yy2HuRblhFfY6RxShrf6+zx9ZHZ75WHA54I17kIfoeeZdNQH5i3 tW8JgzSRkkzMwffndp6WdmOEuggFsaFw X-Google-Smtp-Source: AGHT+IEp+ytgwQov+6Hjv/wtGqegD/c7wuIFoXiqU0KPFIlBJTtWgiNL90nbd0EyZaeggT9ZygPB9g== X-Received: by 2002:a05:651c:1a28:b0:2cc:eae3:2bcb with SMTP id by40-20020a05651c1a2800b002cceae32bcbmr170369ljb.40.1704358644196; Thu, 04 Jan 2024 00:57:24 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ep24-20020a0566384e1800b0046696ea033dsm7828151jab.146.2024.01.04.00.57.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 00:57:23 -0800 (PST) Message-ID: <9abf49bf-7b17-4e63-86c2-cd7b248b6905@suse.com> Date: Thu, 4 Jan 2024 09:57:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] Support APX GPR32 with rex2 prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231219121218.974012-1-lili.cui@intel.com> <20231219121218.974012-2-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.12.2023 07:14, Cui, Lili wrote: >> On 19.12.2023 13:12, Cui, Lili wrote: >>> @@ -7005,6 +7082,43 @@ VEX_check_encoding (const insn_template *t) >>> return 0; >>> } >>> >>> +/* Check if Egprs operands are valid for the instruction. */ >>> + >>> +static int >>> +check_EgprOperands (const insn_template *t) >> >> Hmm, I thought I had asked before to make functions with boolean return >> values have a return type of bool, and then use "true" for success. An >> alternative would be to return the error indicator, rather than putting it in >> i.error here. >> >> Then again I realize this is in line with VEX_check_encoding() and >> check_VecOperands() (which I think would better be changed, but anyway). >> > > Changed it to bool. For the rest, it's a bit strange to only change check_EgprOperands. Can this place be left unchanged? Or should I submit a new patch and change the old one first? Leaving alone is okay; I'll see about cleaning that up at some later point. Jan