From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by sourceware.org (Postfix) with ESMTPS id 7E678385AE5E for ; Thu, 23 Jun 2022 16:08:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E678385AE5E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K08E9Yzh6bxXK4eUfveFLQBmKpLCUtL4zLnGSLuDocwb190kpwRJl/sFT62XKAe0yoh/OfM7Y/Tk6B4ABOAgPoTC1YnvOShEbZ5d/1K/XKLwGiEfo7/ej7a0AQKd4WE1UhNuS+Z/sJtrmEN9eucqxQ94VY7eNHUAcZEYQ3Fqr3UFA9W83ztH9q/FZcw1qY1sjq1+QleLUpAFJSD0xNMFYXIC68hEzliSAjo9uUC1x7eEiGNbDIcs9TUn5tS41FGbtvmewWa7AS0BEB2FHTw0eRAfFz572e9TTJ+07lnXj66OI2Mff7w3SVOKjKIr+Oroa5vkYxJw0JJxFGyANwl/1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9yJ4OJ3P2B+ifRh93jQfHvpAJSrzjmEjPEAO3bES4hg=; b=DmO9RD1EHDAoyLPyD7aiiouZmGNp9UxKCx3w01v2h/KAJE7CitgXc5+DWEFxExVUPpc9hbZfS++SLH4vvUdw80ioCYVP8yJB1GhTIiAPruNYdtzM3vCbxHddzaUu8GC0WNwlUTZV9nk8XARlhd3J8RMvRnPnHX68heRrYNyVOYvYbzK6IACKntt559m56RMLHcVDcXnZXRMYZXLP8gVwMnHK2F0i72ymmkBVvfr3jpG4C/17Wgmw8yqbChUwpMqbIDw+V8+IvGQuR0AnD0/1GvVgmM+fOS2COHsaH9tAO2s89Y1wgCzA4AYH5SKN/T4KdMAflDzBlDzdfpYFdQw7Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB3563.eurprd04.prod.outlook.com (2603:10a6:7:88::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Thu, 23 Jun 2022 16:07:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5353.022; Thu, 23 Jun 2022 16:07:48 +0000 Message-ID: <9b1a1333-792c-f520-4f78-e614a829b7a4@suse.com> Date: Thu, 23 Jun 2022 18:07:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] Correct cpu_flags for CPU_ANY_AVX512BW_FLAGS Content-Language: en-US To: "H.J. Lu" Cc: "binutils@sourceware.org" , "Cui, Lili" References: <20220623071404.15863-1-lili.cui@intel.com> <6cdbbd05-3305-9595-4aca-e547347c80da@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0018.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 534fa81f-da50-421e-9950-08da55328437 X-MS-TrafficTypeDiagnostic: HE1PR0402MB3563:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lxwAz8bUxLz1YLSi5xQOcjYOhqNnwW5hbKdtwjIcJxP6n92um9DrI5F+NQBDzhqIlpF2G+7F3ELjb2CjzywMEQ9xZczbv+ROgVO9cYeCPnE2d3r979NMzImuWZUfe5NGePFv57QnWeSSiUXWjIpzYFJyI0axh58JLpdcCS4kDOrHqLUVOvetFCye174iWFtGE891UPY2E7IHuz58RQLaX6TX7TK7UiFn8KjwwTXgFN83RrUfCkq+ahzuKBI+WRurWNgcI2B+D2G+wJIDk0388O7Tw4P3a4NuwOvfnop1td3GCWVVrs8GYf1IE6vdCOfFygCzIUkDzFSwUiD31TtHZp9GglXReCZWAmJLiqVTj6uE1QcfFg24NJMw/R72x76YnOjNVqITg4uHYIZx3EbbqEMiP/tIWH1GYMKwh7yFFkzasjRzJ71mRwGjtI0HM8E7r77pRokB4stIV+o40fQcp6lgK6U3YdQUvRU5vvGtM0suiRRUXdnypT97WOvwz+dsLMSKFvw0Exz+irsiSp7j9teenla2U6JWuQp6gkdwDPhDnXu+nxpS2O6HIj2dKQyYJUlmPNtbWfGS4hnf/kDYscERfVDA+7DapKnOCKODfBxGNqWQEr2Xme2koMJksoZpp8gUz7IzmmvY8Kv4sXhGvF+SqUAg5yH3MGWi2UeeNfET9CNh8iBk1yQ0wIe9xoEQzeU3j8Dhq+08jPSJvnjohxCBotSx9FanAG7tVm1rJ3vUgdBjVR+kksbW2/Efc4rzGZwHt65NSbRUhbp5P1yUi1ehDjThPAtqqC/RoUqZSNHSGuS7IlktTjYcWUiHbTaQf69PpGCYIZ3Et544mu9NiA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(366004)(396003)(136003)(376002)(6916009)(31696002)(54906003)(4326008)(6486002)(8676002)(8936002)(316002)(38100700002)(26005)(86362001)(5660300002)(53546011)(2906002)(186003)(478600001)(31686004)(36756003)(66946007)(6506007)(83380400001)(41300700001)(2616005)(6512007)(66556008)(66476007)(107886003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWc5ZVpTWGRLNWpncTI2a2tXNjQwbXRhb3lKSGVQV0I4Y20vL1VIamhzbms1?= =?utf-8?B?Z2gzVHhrS3Z4b3A1TWhSVFBjeUNqY2FCeDEzbVBXY0RQQnJ1WEhrZWlhSXFW?= =?utf-8?B?WktBejVvVUMxbDk4dm56T202K3QwVHh5Sko4bkdndndBTEI0NDVSUlh4ZEpo?= =?utf-8?B?L3N0bGordzJ3bFlTckVPYzRpQkRQU3p1RFlORWZNSzRhNUxHZHNEM0M0TjRE?= =?utf-8?B?UFY3QmNPNDdLRjN0SEc4QXNLN3Z0QTdzbUVLWHdmNkF6OTFDaWtVSWdEVXdz?= =?utf-8?B?eGdBalJwaVl3b3RFV3NJK3RzMWhjNDV5L0loMWV4eHF2RXJpMkVwSWRFbU5w?= =?utf-8?B?RHpSc0xoV0tNOVlLM20zYkdXd0h2bnp2ZjlOQ21HQWR6REFPdi9zYmlLNU15?= =?utf-8?B?bFBYaUZPcmRZbm1VOXVneVhnRmtYeVQzckJaK0NuUElFUlpnTWNrUnJUa2o5?= =?utf-8?B?TzhhZU0wZ3Y5Q0t3VzZvaEZZSVB4UHJCempqc29lL2lyUVV2MkppZW5mK1Nu?= =?utf-8?B?Vk8wWExWbFFoeVV6djFyUzBPd3UzNlptN2ViQlliUXVlVjNYNDZBdVVZcUNB?= =?utf-8?B?LzJwaWxlNE5vNXNyY29lNmFLWlBiWEZJTjR5dVNDOU9ucVpKcUdyNzNZMnRK?= =?utf-8?B?eGc3ZncyamFTN0R4ZlVPVytHUDRCWS9NVHhkN0pOWnNUclYvRGV5RWJkLzNW?= =?utf-8?B?NTdwMWxTUmE5YlJhdmlnQ2lsZEkySTBkRHRZa1U1UUE0cGtsUXB3TG5SRit6?= =?utf-8?B?L1BWS3dZR1cyRmJsZmR6emtFMWpyK2wvT1c3bG5JMC9RbkRtUU1vcTViQUZR?= =?utf-8?B?NllVb2hXNWJGakZPaTBWYkhxV2luWUpHU1c2S1pteTYzSEl6OVdhMkgrUGdD?= =?utf-8?B?V3loejgvRVdWMWJ0aE96WmIyYUZUOGxTT2R6L0dkNzgvUFd6QUsvRkxpc09h?= =?utf-8?B?ZDdhQ1JpN0tLb3BTN1I1Nzl4SG9PczRmRWdTQnhtMzZ2a0NnQUREQTlsZi9Q?= =?utf-8?B?bmpoK2xjeEVFM1h0cDZobDVucEJqb1NiWnNYR3hRcTVCd3hEa3ZlVFFiemNM?= =?utf-8?B?b20rSTh6N2NNMzFGRXRqdHBTdEd1d2VZN2Fza2IvWjgwRFd0Z2d3U2tEWEJ5?= =?utf-8?B?aEV1WjRlT3dnWFNqRWhUaGo3OGdLeWtjNThzUStveU43dGhsZHlJcjBGd3U3?= =?utf-8?B?NDdPL0pIa2RJZElyNm9jY2xUWUtLcW02c01hdlZwcC8ybytJMnQ5TGJWRzNI?= =?utf-8?B?ZTBOWmpFSG9aVUpiSUlZZ0NMM3dndHg3cWM4ZXJPaWVXM1liM3Y1N3VobDh3?= =?utf-8?B?UTVUNnVsaVZNeDI5R0dsWVdXWWFxWFZQSVJ4RkpCZ0s3ODF3Ti94NnVIaFRE?= =?utf-8?B?KzI4cDlZMGFmcER3NDVKQ1laVUtuVUg1MGFIRlYwRUlOZEVJSlBzclZ1M0ZS?= =?utf-8?B?elR6Z1dVU3RXbmpFUFdtMElKZVpTMmw0azVobll0VkRvK1g0WkVVQ3JveGFk?= =?utf-8?B?cDhrL0hLRWNIcExFdStxVkNSSjdzL3BvQS9rSzhHbkQ1UFB0dzVRYy94aGNW?= =?utf-8?B?R1ZUYm9WTDlMN1M4eWxRa2Mrd3FydW82L3AxLzdGNWdYNUhxS0E1dTBXQTBN?= =?utf-8?B?NHhjdFBKc1VGQnUxUVpVNExCa28wT3VtTDFyRmgwQVdJdzEwUzRMb2xoQ3V4?= =?utf-8?B?WXB5NVVqRGhzc1NZNnlQRG1DUGxSQzNpYXJzSjhXUW1TUHVhVVNTQy9VeVFl?= =?utf-8?B?aTJob24vbDAwU3h0K2dURHhrM2FiRmhVSmhHZFk4Y054M1lEVGcxQzVuVGQx?= =?utf-8?B?QXlEMjVjZTFVaU9wS0xLaUdrT0VWVVlieDdmR2RZU2U4WFI3L01haXpiVndP?= =?utf-8?B?WFV6MWxLSzBRQUFxanlHWEk4Y3F5Q2xTc3RGRnMzL0dXdHFTY05SRFdwSVVx?= =?utf-8?B?VGtiY3JXT2xxZTc3SlhQVU8rMUJrK1JWN3VqYzdXNlFTMGRUUSs1QmFwN1ox?= =?utf-8?B?cWkzOWpNMEIwWE8rUmozTUZKbmxPdlZLRXJHSSs2OFdmOUVOeGJZZ3Y2cFg5?= =?utf-8?B?b3h5d3lmRkFiZ1Rzc0R1cFE0V0VoR281Z3BtYSszK2toVG00dnI3S1hDRVdS?= =?utf-8?Q?6ZMLS8V3ncOXnnhXSFdTvLXAs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 534fa81f-da50-421e-9950-08da55328437 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 16:07:48.2870 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wl2MWqTfcxpDZO+xTLS8zur0vcfCzcd9ZEflZxq/rmVD04bLRAUckDKdJIXZ7t2X3OfvvuboDgHxV6UrIVQeMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3563 X-Spam-Status: No, score=-3036.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 16:08:08 -0000 On 23.06.2022 18:04, H.J. Lu wrote: > On Thu, Jun 23, 2022 at 1:08 AM Cui, Lili wrote: >> >> >> >>> -----Original Message----- >>> From: Jan Beulich >>> Sent: Thursday, June 23, 2022 3:30 PM >>> To: Cui, Lili >>> Cc: binutils@sourceware.org; hjl.tools@gmail.com >>> Subject: Re: [PATCH] Correct cpu_flags for CPU_ANY_AVX512BW_FLAGS >>> >>> On 23.06.2022 09:14, Cui,Lili wrote: >>>> This patch is to correct cpu_flags for CPU_ANY_AVX512BW_FLAGS. >>>> Make check-gas is ok. >>>> Ok for master? >>>> >>>> Thanks, >>>> Lili. >>>> >>>> Change it from "CPU_ANY_AVX512_FP16_FLAGS" to "CpuAVX512_FP16" >>> >>> You don't say what's wrong with what there is right now. I for one think what >>> we have is correct: If one disables BW, _all_ its dependents should be >>> disabled as well, which transitively means all dependents of FP16. >>> >> Hi Jan, >> Agree with that " If one disables BW, _all_ its dependents should be disabled as well ". >> I saw the form of "CPU_ANY_AVX512F_FLAGS" today, and to be consistent with it, I thought "CPU_ANY_AVX512_FP16_FLAGS" was wrong at that time. But after reading your email, I found "CPU_ANY_AVX512F_FLAGS" to be the only one that uses cpu_flags instead of CPU_ANY* . >> >> { "CPU_ANY_AVX512F_FLAGS", >> "CpuAVX512F|CpuAVX512CD|CpuAVX512ER|CpuAVX512PF|CpuAVX512DQ|CPU_ANY_AVX512BW_FLAGS|CpuAVX512VL|CpuAVX512IFMA|CpuAVX512VBMI|CpuAVX512_4FMAPS|CpuAVX512_4VNNIW|CpuAVX512_VPOPCNTDQ|CpuAVX512_VBMI2|CpuAVX512_VNNI|CpuAVX512_BITALG|CpuAVX512_BF16|CpuAVX512_VP2INTERSECT" }, >> >> Regards, >> Lili. >> >>> Jan >>> >>>> opcodes/ >>>> >>>> * i386-gen.c (cpu_flag_init): Change cpu_flags of >>>> CPU_ANY_AVX512BW_FLAGS. >>>> --- >>>> opcodes/i386-gen.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c index >>>> d18a7d2754..5dc224efdb 100644 >>>> --- a/opcodes/i386-gen.c >>>> +++ b/opcodes/i386-gen.c >>>> @@ -382,7 +382,7 @@ static initializer cpu_flag_init[] = >>>> { "CPU_ANY_AVX512DQ_FLAGS", >>>> "CpuAVX512DQ" }, >>>> { "CPU_ANY_AVX512BW_FLAGS", >>>> - "CpuAVX512BW|CPU_ANY_AVX512_FP16_FLAGS" }, >>>> + "CpuAVX512BW|CpuAVX512_FP16" }, >>>> { "CPU_ANY_AVX512VL_FLAGS", >>>> "CpuAVX512VL" }, >>>> { "CPU_ANY_AVX512IFMA_FLAGS", >> > > Since CPU_ANY_AVX512_FP16_FLAGS is the same as CpuAVX512_FP16, > this change is nop. On the other hand, CPU_ANY shouldn't be used to define > another CPU_ANY. Why? Imo that's exactly how it should be, as long as the purpose of CPU_ANY_* is the use for processing of negative .arch directives. Jan