From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 9052A3857BA3 for ; Thu, 4 Jan 2024 09:16:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9052A3857BA3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9052A3857BA3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704359764; cv=none; b=Mjt8jDYOXli8pEAl64kFxKdo8CU0uX3h7jo93r/RZ0Escq+ChdaobjQTPBVfGQ8CCik6TGFNIBCZ4wBgmrq33pwdO+LdpFF+zkvxxnmWSb+Pf9/pwWlYjBh3oEY6y+ILQUkJJH6o1FqLSZDqeOeQ5oxbLZbEwdHdy7xPCBiIxGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704359764; c=relaxed/simple; bh=bqIwqUE1qq3I4W2XImZVlHsklq7q7U8rmjp0M2aCaeg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VPmUgwAHCC4K/XjYMLFBm+c74kDclb25pnUuwWqL1yU4bk+/0AnI/QjkqVGOSARm37yxv0gw2mljsoOkRYCPzAixkc0nHrMnBO3TCF0DCKiHDlVRFJR/lF/gPshF1RUoQeaK2qbTtCLLmWiuGBxIjR0kzDCPKlksOWPl9ZHg2tI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50e7dd8bce8so304597e87.1 for ; Thu, 04 Jan 2024 01:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704359759; x=1704964559; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O8HCd2gQKAnect7tq3nP9vRMtaDdww65Wo4zTOA9VgI=; b=BfRRLW05rpV9unC7UJqe8JgiBbbovxWNIHvYwZpnldQx33bnZWzQPrB4dS5XL6H4Ys rAW5XDwmDpCdxt2FFcaAZKGmGbhVjR7q4Acd3WwHRZ1K/MHgDRLlQPlNDEFgFYcA4yR/ BwMXSKVyxeHeV+OsKqdQtw9L4781ar8ONqYyxtwbJJD96dj64/wnaijhDW7cyWB3ii1C qdgv2c2rrogAN1vIvWpzXsYXB4lwrsWEBzc/ctd2Be8bCCp6Ha8gZ1CivNWBlkPxaUSw iLdNh0Wowv1d/lfdISJsMWPzYZ15feR1oPKS9y/bCpmreGx27UVFJYYAPKgFguzHJfEc g+mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704359759; x=1704964559; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O8HCd2gQKAnect7tq3nP9vRMtaDdww65Wo4zTOA9VgI=; b=mT+dG6ZSkxH7YfhtxQin81DAbPAH1WiTdSAkJSd4E7ZLm5FWtWPX8teEDcuFJVTKsr NFs6uNUjBVIqi1YRhiUUo9phcptnac5aihduvRemD1BntbpBYtS8CwstHYC18WLKFFTR fv6/XmspUAZSv8XlbA2q7OowN41XKXCQyuAZ53KzM+dLYp09bIjUhcZBFO6hnSPysPhT R+rvGAKIGIulv/RlauNFZ4fay3q3aYyAu5FDqIK5FySVCHpTWY6m1UTpv55dXu9i4bd+ QHw8zmFh8CjWI+BzwFRpcWK+Lwis4KN6SBR6oQOD7CHSzs63H7nIfP0nL6K5nfityEq+ A8Hg== X-Gm-Message-State: AOJu0Yx6mXAr167trx4BQ/B0zWcMcehB6sxPMlbrP5yAHuV3AE95UGTq lM727aYBbdGiniqnxivCGZiPfnX8MwPN X-Google-Smtp-Source: AGHT+IEb8glN2VARne14GMgblGDQANOfkgOGKzK/i9EUCy0R+3yfuc4dTKovmnbnxIGAXLq4xEVHpg== X-Received: by 2002:a05:6512:3ca7:b0:50e:53bc:3f9b with SMTP id h39-20020a0565123ca700b0050e53bc3f9bmr225764lfv.113.1704359758982; Thu, 04 Jan 2024 01:15:58 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id cs13-20020a056638470d00b0046dda6b83c1sm1029370jab.25.2024.01.04.01.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 01:15:58 -0800 (PST) Message-ID: <9c55e272-e775-4b7a-a379-fcef6b5c8388@suse.com> Date: Thu, 4 Jan 2024 10:16:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/9] Add tests for APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" , "Lu, Hongjiu" Cc: "binutils@sourceware.org" References: <20231219121218.974012-1-lili.cui@intel.com> <20231219121218.974012-5-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.12.2023 14:40, Cui, Lili wrote: >> On 19.12.2023 13:12, Cui, Lili wrote: >>> --- a/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s >>> +++ b/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s >>> @@ -16,3 +16,194 @@ >>> + vroundpd $1,(%r24),%xmm6 >>> + vroundps $2,(%r24),%xmm6 >>> + vroundsd $3,(%r24),%xmm6,%xmm3 >>> + vroundss $4,(%r24),%xmm6,%xmm3 >> >> These are still here, when they can be expressed. > > I think we should keep it until we complete a reasonably equivalent replacement. This replacement should have been introduced in this series, as asked for more than once. And, H.J., I think you shouldn't have approved this patch (and more generally any one) with unaddressed review comments. >>> --- /dev/null >>> +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s >>> @@ -0,0 +1,34 @@ >>> +# Check Illegal prefix for 64bit EVEX-promoted instructions >>> + >>> + .allow_index_reg >>> + .text >>> +_start: >>> + #movbe %r23w,%ax set EVEX.pp = f3 (illegal value). >>> + .insn EVEX.L0.f3.M12.W0 0x60, %di, %ax >>> + #movbe %r23w,%ax set EVEX.pp = f2 (illegal value). >>> + .insn EVEX.L0.f2.M12.W0 0x60, %di, %ax >>> + #VSIB vpgatherqq (%rbp,%zmm17,8),%zmm16{%k1} set EVEX.P[10] >> == 0 >>> + #(illegal value). >>> + .byte 0x62, 0xe2, 0xf9, 0x41, 0x91, 0x84, 0xcd >>> + .byte 0xff >> >> This one's still using .byte and still referencing P[10] in the comment. >> If that's really unavoidable, then - as elsewhere - the description of the patch >> could (and should) provide the reason. And there continue to be no >> separating blank lines, making it as hard as before to find ones way through all >> of this. >> > > Copied from the previous comments, > ------------------------------------------------------------------------ >>>> + #(illegal value). >>>> + .byte 0x62, 0xe2, 0xf9, 0x41, 0x91, 0x84, 0xcd, 0x7b, 0x00, 0x00, 0x00 >>>> + .byte 0xff >>> >>> For the purpose of this test (whatever P[10] again is) you don't need >>> a 32-bit displacement, do you? Shorter is (almost always) better in such tests. >>> >> >> P[10] is a fixed value, in normal EVEX format we don't use this bit. Dropped 0x7b. > ------------------------------------------------------------------------ This is not addressing my comment. Iirc all bit in the EVEX prefix have names now in SDM plus APX spec, and hence they should preferably be referred to by their names rather than their bit positions. Plus there's still no justification for using .byte instead of .insn. >>> + .insn EVEX.L0.66.M12.W0 0x60, %di, %ax{%k1} >>> + #EVEX_MAP4 movbe %r18w,%ax set EVEX.L'L == 0b01 (illegal value). >>> + .insn EVEX.L1.66.M12.W0 0x60, %di, %ax >>> + #EVEX_MAP4 movbe %r18w,%ax set EVEX.z == 0b1 (illegal value). >>> + .insn EVEX.L0.66.M12.W0 0x60, %di, %ax {%k7}{z} >>> + #EVEX from VEX bzhi %rax,(%rax,%rbx),%rcx EVEX.P[17:16](EVEX.aa) >> == 0b01 >>> + #(illegal value). >>> + .insn EVEX.L0.NP.0f38.W0 0xf5, %rax, (%rax,%rbx), %rcx{%k1} >>> + #EVEX from VEX bzhi %rax,(%rax,%rbx),%ecx EVEX.P[22:21](EVEX.L’L) >> == 0b01 >>> + #(illegal value). >>> + .insn EVEX.L1.NP.0f38.W0 0xf5, %rax, (%rax,%rbx), %rcx >>> + #EVEX from VEX bzhi %rax,(%rax,%rbx),%rcx EVEX.P[23](EVEX.z) == >> 0b1 >>> + #(illegal value). >>> + .insn EVEX.L0.NP.0f38.W0 0xf5, %rax, (%rax,%rbx), %rcx >>> +{%k7}{z} >> >> Isn't {%k7} alone rendering the encoding invalid, which was checked for above >> already? Also - bogus indentation again. >> > > That is for legacy, this is for vex. What is "that" here? And how can anything with operand mask applied be VEX? The more that .insn's operand says EVEX? Here you want to set _only_ EVEX.z, without EVEX.aaa being non-zero. Jan