From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 4E55C3951C10 for ; Mon, 14 Jun 2021 10:26:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E55C3951C10 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-31-UB0HFEpyO5-16HjqGXT61Q-1; Mon, 14 Jun 2021 12:26:03 +0200 X-MC-Unique: UB0HFEpyO5-16HjqGXT61Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OJttiU6Mk/HiUOG6hpeAbLMQONNw6xxPSNICQBIMfzwDnZGifKcIYe2IoH5p2atnUoPsDs9hphnk0cG/SIcpHb1PY4u7R+d7tv1/dIx25G50m55gflF7Wm/+xkm2ksIHDtFX+DOsr8JFON4QSU5nl4kxN9wT1l0BdmZrK4F/PlgzTjSc0yt5qialuwlK1S4eXDqU2MjP6Dvqfa9TSjRVfgxLVmHXYk4hamG1YWsGe16qWYi5ty9AD0VejReDYud5WpP9h8jmVdr12vT3TGD0+xajHNwkRkZvr5PStVaVkQh8dgNnqgr6huA1O04rHPsfs7siGvTe6/N9xDWT+j+INg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ihZUaAHJJAcfN7nbqAowWwKaEOD/TPXE2OJIG2VUV0=; b=R+P2se2ItZ1Orz6pE8czV9li6c+yo4C14tqALHysEHXTQ+KZOWcdfP58VOX7+cdNz4NGntYaj3b8WbYsM11R2Y/FkY8mhr75bqlc4/unqC/VoC+ujHtCEJZTk+ACh8CYwDMBLb9kT3ctC4p/poih5Tkbs/Dyw7MgO/TFw2gDtPmieGl+8+vitRgZyD0ZduUiNaN8cjKvpXLzPUyvhV9D4NOVR01U8Q8+6+u9jaHGRYeZnc0FvqgnU7ldDKYqxLXmRB96kwylE+5TxdUWCcWs/EpXOLJZReFlzUHMoh/1yb8worBRfjs6WmUXjAAQglxax7vcYz7CBTZqDsBFDN46FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Mon, 14 Jun 2021 10:26:02 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4219.025; Mon, 14 Jun 2021 10:26:02 +0000 Subject: [PATCH 4/6] x86: slightly simplify offset_in_range() To: Binutils References: <0babbec4-06ae-f980-18a9-20608046891b@suse.com> From: Jan Beulich Message-ID: <9cdbd052-04d7-4953-abc4-1215f9e489ea@suse.com> Date: Mon, 14 Jun 2021 12:26:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <0babbec4-06ae-f980-18a9-20608046891b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: AM0PR10CA0083.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::36) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.156.60.236] (37.24.206.209) by AM0PR10CA0083.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Mon, 14 Jun 2021 10:26:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb4de125-18c6-4bb6-a67c-08d92f1ecf38 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5BGqMihZa6avfiy5UgvqeTdX4/aIG8vNA1t/0uIR8cc/Q+0ll49Zg4Bg/722C6W5lU42bZMdC/Hqm//UZ7+iDWaFoP2BG/SMWWbSNfr6dNrfowLirF6isZQ/T11HkhgNcRyPikR+ACVSpo1dD/7zx9y1W48tt/5ebAcY4oCALWUlUTKUFHACkcysI3F61J5OUrNpaJa+B4hmmgJuIQiLHk03zPrgGuKKdGtoCgTo8ox1hn/gcHvxA4DmJ/+mEpRF9y9upE7X2KFIIfjkcjH5S5qApatFj/1K2gl4o5zzmwOuZlYx2ajxPCtJhehW6Wv9c5ejt+kSUYgf5tVpG2jnkpETJkYph7qJAvxk5bas5cn6U584R2rstKqBLWK6QyRvGNiD7ODhMIinRDgCI6CMpKfJqyAbwdiWCurONgt+9p55igisxdEhagwfU4LueEqWAQJB/zIbYoX71Gv1uk0CC4SsXVYF/XAiMxiuxbuVomsCrtuZ9HoPuVmIlVNomcisbqGxEGT61J+/9Cc/TtyVbdeR1mKLSgIhyzO8uum3dkIsKnyeuHdk/4jalCtNXE0ld9Zi2VTl4hvW8ibg0vb4zJdKZzB3Ex0OrsffmvErQaG7BRzu4r36Y5Vhi294JLr0P2Neibl+a8+6Bc8VKuT0mkpYMs1CU+mfEw/PASRbmmlSHIbFasbTk1pQwzewbecS X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(396003)(376002)(366004)(346002)(136003)(8676002)(316002)(66946007)(66476007)(186003)(36756003)(478600001)(16526019)(4744005)(16576012)(2906002)(956004)(2616005)(66556008)(31696002)(86362001)(5660300002)(6916009)(4326008)(26005)(38100700002)(31686004)(8936002)(6486002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnYxU2ZvVUx6eklFdDcrQ0xtRThRR0VBbkphM3pYYjJMamFZQjFad29sN3RR?= =?utf-8?B?WVRLNml5OUh3dTJQZGlNakRtVWprZnRFU2JBSG94ZWtyMmluSGsyb1Q4Qnl0?= =?utf-8?B?V3o5QXRhclUyYjY3QTV1aXhMUFRLcVlML2VGb0crNjlhTEJ2NnNKcUxjSkpJ?= =?utf-8?B?ZGtTd2J4STM0elBoSWh0SFdlN2dka2FVa2g3ZHhCK0dhTWUyMjlxc1lYaUxN?= =?utf-8?B?NzhuOHpkOXViUUFMVUo0SFFRWUhOR0Zmb1dhU2h4bHdXWEdidS8vWUxvKzFO?= =?utf-8?B?Y2gydUFOK01jZnluTGd2TlNWck5sUFJCakd6SFhDNC82ZkFGRk55ZFlsRklv?= =?utf-8?B?d3RaTnZjaGc0L1liMDYvNFNGUjZRUjdBWDAvdG9jOTh4MFo1Vks3alJiaXZr?= =?utf-8?B?bVY5cFpVUUR0OEZPV1pYMHZIcmdEQi9RbVIyWHJwZ1BjalBxS2Z3VEtlcjI0?= =?utf-8?B?TzEzdDNyWnc2RnhtVFBCS2VoY1dReXdIQUwrY01oaGZ3MVc0Z0JqVFBML2M5?= =?utf-8?B?dXFSZWQ2VWFKaHF2NjMrN3FBVFZRcnZVRXpzdzhlb0NHZ3VGelg1QW5Ia2N2?= =?utf-8?B?N1k0aVNSZEIzRjM5T2p5V3JZRk9yTVBwNGZFM0gvNVQvanRrUzBRbDdLa3M0?= =?utf-8?B?QnJQbkJQcjFld3AybmpXRWJBOS9XM0VOSFpyZDFMbDBzSUIwSFo4Z3lVamVu?= =?utf-8?B?QUFnMUl6TW9sV01vUzdXN2NGKzFvVW96bjZBajltMjNrSVYzMDNodzU5blFl?= =?utf-8?B?NjBSbmtHQmU4eDRjcmdKWWFIdUNxN1FZdSsrSWxYY2lkOW12NUZSd1F3Sm5V?= =?utf-8?B?a2paTzRnSFE4OEowTnNqK1R0OURxN1FrT0FRRXY0Q3dpZ1JZZkVlbnlvQXM2?= =?utf-8?B?UzBIQzBUalJ4N3BTRWJRZm56elNjYXYrRUVSZURCK2VFNUdWMEw1TzN6RG9X?= =?utf-8?B?a1dHOFpjbFZGR2hzSGkvb1J0VnU0dFhIZUJHY1Zzc1VIV1NTTGV1ekVwcnpM?= =?utf-8?B?OU1INWlSKzBiQTcvTEg2Q3ovMVkvK1Q4dGVZRmcvVzgwVG5tMUpNZU5YeVBM?= =?utf-8?B?UUxYTHh1QlVSU1VkcVlhNkpycWVHNGIvZUVMOE1YWDBkRzZsRmJGc3JraE95?= =?utf-8?B?ckk0WVQyWEdGVHlyaUhsWXo0akw1cUh1NitBMVgzKzR6aW9qaXhmTVBwYW42?= =?utf-8?B?NFpEN1NEcGg0b1lyMUV6b2E3M2hDL2tsK2E2ZmtvQ3NHVWlsRmhIZkZXczNa?= =?utf-8?B?VVduN2g0YlRBb0o4eW11SXRQQWk2L2xYcUs5MXhsb3Z5Qy9JK2dFMEhuWW1E?= =?utf-8?B?OVBQZ0FvbTJ4NEZwNDJnM3U5cXFQZGRCQTdmNzJ5cUMvMmpjSkFBNkhJcmMw?= =?utf-8?B?Z0FuVGRDZ0d0N3E1Rk5EUTJOM0RzcnhYdW5CZVQ4dGYzVXpSNnRGVHZIR1NX?= =?utf-8?B?NytVVCszZXpLVng3REdnNzY0UENwbW8ya0g1UmROUEpvRVVoQmgzMXN2M2VW?= =?utf-8?B?d2ZiMUtQVzNwaEo0U09XV0RYT2JnOGxPa3JROVNRSGI1VW81dm8ybmU3SVFZ?= =?utf-8?B?dmNQbWRycGtOekJ0aEoyVmNObGQ0S0tiK25RWEhOY1hJVGFqcHk4Um5BM1Y0?= =?utf-8?B?TUsxd1hDVjdoSlNKUDR2bERSR256Tnd0Y3pvc3ZxYnIzR0doNlJzQ2ZDMjl2?= =?utf-8?B?K1pSbmlNNHpMNEdIWEtZMmpjTzNSRjJUb1pxMDVYdnBZaC91SHlKRmc5a3po?= =?utf-8?Q?sumWZDfG85c28jvt/+PWtoY0mpuyrSQwP5E5Zxc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb4de125-18c6-4bb6-a67c-08d92f1ecf38 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2021 10:26:02.2875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fu3Qpmfc/H7GQYCimyTwM8mpxBEy5huT0T0vaDbi23gYDemzUawk9MWrIJs7RnYNFhv6I54HQa0+yvjgHIsElQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448 X-Spam-Status: No, score=-3126.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 10:26:06 -0000 Applying a mask with all bits set (or its inverse, with hence all bits clear) won't alter the result (or won't trigger the warning). Re-arrange the code to eliminate two more of the somewhat odd (2 << width_minus_1) constructs. gas/ 2021-06-XX Jan Beulich * config/tc-i386.c (offset_in_range): Bail early when mask would cover all bits anyway. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -2556,10 +2556,10 @@ offset_in_range (offsetT val, int size) { case 1: mask = ((addressT) 1 << 8) - 1; break; case 2: mask = ((addressT) 1 << 16) - 1; break; - case 4: mask = ((addressT) 2 << 31) - 1; break; #ifdef BFD64 - case 8: mask = ((addressT) 2 << 63) - 1; break; + case 4: mask = ((addressT) 1 << 32) - 1; break; #endif + case sizeof (val): return val; default: abort (); }