From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2087.outbound.protection.outlook.com [40.107.247.87]) by sourceware.org (Postfix) with ESMTPS id 15E333857005 for ; Fri, 5 May 2023 12:52:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15E333857005 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jfI3ywn83mffR9SSbx9V4dppBH1ik7q+ntH8XwH5kELjsfpcx0pQ+nbGxkTdWi9f0irFBcJIwbdxH+ip7QGl4exU9/RvTCKMOTYOOCI9BlK+/ctQso7kjKmiT5u7K+hUcQ5G1xqX5ZUKCjRZlB32YmbHLOvgUpnqKizGf+AlsaeJp7+uk4Afps8iUiMFw393geET2Hjmi04ITuecNJRrn71cJZ+BxiOBoY2HcyMvGNK3tvZ8bVxuwqleGIFrAnJ2kMYQL9rL2Xi0V5t/8HIud4x0ub7P+fLRvUnVlMxYDW844YGvRXmsBrKXAG5ApOohCFovVYEETgYvyGIh0rK6XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=191k5YFkJEz3SRma2DDM/rfJunjFN1nFUMfyjRecFso=; b=d8Y9Pw+m404Yl+xTuegiZwW1azzbS2bjC9Au9uxxJ7MbfyZ9SEIwnXY8sEAxesGJP6Ye2cdSsOXlReKx9A3YfrvvnG44cdUTiWT+6VItSU1fZGV9zfPM9u8oVRTx/jdEIAtJWx0Qy2ipVcxGUoIAoizd1L+Z15Du637jgo1Hm7cpsFPiTS5pTpCZ7vx3p+ZF1aXWCLF0/LG3QqIALvP8phrzIl7Or8nxS1fs6KB6F6SzTQngU73iJrj6SfObn9Av2ShxLwhnys/i3E21+L3lhkU3Q3rnbiJnXLe+/SoxnSiIDrW7Y+PsY0UjYqyzxsHhfQ34wJw9FwZHdFxvnNi08Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=191k5YFkJEz3SRma2DDM/rfJunjFN1nFUMfyjRecFso=; b=XLwNT9lzbkhbTAf7RYvuuMVFlEzMWudg+ft8e4M0368GUp4APsXCGsqyWrV9BCa72LrZ/gQ3IVc+AeNqL72k3CD6hzMsQMpTWK8dQXokaLUATnCop6b029o51SBuT8um/uqIL5H1MlnjH0LIKuux/XoQQJPuFgkbok7J2Qlptli3OwwkS6MkZMCEopKl1zzhARxlSU+aWo8A7pd6687gDzbaHlIRsqUxLJSOlU6fPD5OSdE09YrXiT4nTGmDsnT1QdbHprHZDXDFd3ywKvLM+FukHFtkwosEAvDYInBLn7ENlZ7sCktKYr7A5rEj94ybjW/XRYyEY+Pfunwcxe8QDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU0PR04MB9395.eurprd04.prod.outlook.com (2603:10a6:10:35a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 12:52:04 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 12:52:04 +0000 Message-ID: <9d0f914a-5668-a09b-5993-16a2270cf059@suse.com> Date: Fri, 5 May 2023 14:52:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH 2/2] x86/Intel: address quoted-symbol related FIXMEs Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::10) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DU0PR04MB9395:EE_ X-MS-Office365-Filtering-Correlation-Id: 1966f28a-9e88-493b-4db9-08db4d6786b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mj1egbDnqOxmtw14qaH3lbRaIpfoLvSgFcZUWPc37NCvtyFAAA7oW576GO2nSwWhlPU61gcqlWp8Frlnq7gyMWe50b0zO1Z8Gg9zesjCZaHfdMrvvs/1fpxYl2q0DdklHwmr1OjRW5IXTfIbpkPWLZ+P2zalCgFHobT6SeHpqwv+sR+5/DPiw0mMsurOsT610HNIu6HBjE6Bh+GWpiiToJB3EukBSMNZfIMg6AJWcSPLFpI41KpNEFh00dnwoKavZ8zp/UOb3R3Yc5iUfZO970/TbYMSUwHWA6GNTJUU0UptexbasOmQKSY720opmrj417+gAjo+Qh5R09F6rbILG3qNGcqDkSamwH8UM0CCjr3VdvO+CXt4sU1yyQN8Rh880b7RFjbNPFrIHBHjaAz6NwuL5GPiv6m+Li0IWESo9Ouf1HU7HNjhq3Hivl5KabqZi2aGbezzbv3Q9H7P0NUXUz6M4vY38z5uEmjIyGRo/LmZlepez/dez1BNAnj50bUTgHq5bIbN/RZj46ThOoSCpjktsxrCaIvshdLH5QkNm/bdkWwt4bZUHwoIRnrhyjkD8FhQANNZP5y7hzC/kvM1T2Zg6aDskGS9+MM0stkFvortWevTP8j4A/epoXgA7IFMGI43c0xC1UUxdnPWsvaCjg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(346002)(376002)(366004)(136003)(451199021)(2616005)(186003)(2906002)(38100700002)(36756003)(31696002)(86362001)(8936002)(8676002)(5660300002)(4326008)(6916009)(66556008)(66476007)(66946007)(41300700001)(6486002)(31686004)(316002)(478600001)(26005)(6506007)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVZWNW11QU03UWpXemd3VS9Ba1pmaSs5YTA2cms0Q2lHcnpMaS9jNUZteit5?= =?utf-8?B?WE9qTEpUenFlV3FTeUM4c3FrQnJPOHVkeE9tNzl3bGdlV2YrbEpFVTBQME5V?= =?utf-8?B?Nkk5dHpOeFh1Z2s1K0FOc3laKzV3ZVNzVFQwZ2g3bjNEcVlQL0tVaGtNdXlj?= =?utf-8?B?Rm1IaHcyUUFVakQzcm9xSEtKUjBIMm5LOHlNY1Iyb0tJdk5BUDUrVGJGeC93?= =?utf-8?B?ajRzOUJneEtmMGVodThvK1hLeVJUTUJ2MEp2RFBxdGsxTEZPZWgrbThpUTlQ?= =?utf-8?B?T2hKdy9DOTF5Y3JOTWd6SnZPR2hLNGxPcFgzcG9lTnFGME5GYk9jb1BPSWJ1?= =?utf-8?B?cTEzZnZQMVRQaUdteFBtWi9QZUc2MU0waEtyWTNXVm05Ymc0SnBXcnFsVERS?= =?utf-8?B?M1R3ZW1uUllBdURsaU5vOEJWYkx0SExkemE4eUdyNDdhRG5TK01lTkFIcUtM?= =?utf-8?B?QUNlcmZObXdrdjJUblIzUFFpZ0t6RnBsVnIwV2ZlR3Z6TFBzNkduMERrVW5U?= =?utf-8?B?enJ4MzNzNjBrZjBPQTZBYVMxMXN0czRTS2hxKzB6Z0dhWFhYcDR6ZkwvZGFF?= =?utf-8?B?TngraVBMZ3J3RTFMQWFKZmxvQlV1dHBTcFRMa3k2Y3ZzOFdsQkVGSWVycmc4?= =?utf-8?B?djBEb09UTjNST1pLN09XS3BlOVNlNktsd0xDR095N1NPQVBFNjRXYWNzR3R0?= =?utf-8?B?aW5CYmo5VVo4OTFKUzI4cU5lMVNQbXErYmdpTEZENmxFaWsvd3hpcDRSZ2Nm?= =?utf-8?B?d1RHMjFwdC9xNmxZeEs5SVdKMjZSdWUvTzR1UGI5eTVBbHZWMzMybFR4K1U4?= =?utf-8?B?QUVGdkJHU09UeXhNVnJoSDV3amFTOEg0NlNqZWMrL1Viai93WTlJV1RLdWt5?= =?utf-8?B?QStteFFjbmc4R2N3UG9sakxYcC95bVo3M0tTSUhFSG5XTEt6UUtKT1lPdGgz?= =?utf-8?B?UWJJdEpRZEV5dWNDV0RnVlJEcVUvbzlLUzkzaHQvdFMxNENjTXRXR1lqbVJz?= =?utf-8?B?eUxKT2QrUVdPTGdYY0wyeUQxTmkrTzVJeWlKWk5hUmY1VG5Kb05SNDZxZ0hK?= =?utf-8?B?Y0QxYmxFTHlma0tTbDJCSWJoSmFXQ3pYb29Mcitxd0pKd0U3ZW93M2g5ZGd2?= =?utf-8?B?RHhlZDduR09sdVlOd0gzdmJ0KzFaMlh2TEw0TFRwWFFjWS9hZXhuak40WFE4?= =?utf-8?B?L3lkNk1yNkdYRmNHOUx2L3FrbzRqT2tadHVSZmRSNTU2eHlWdXNLZzJFa0I2?= =?utf-8?B?NDcySFJhc21kNXB1S2xaNmp4K3ZOaDl5K09Vd2xaYU9UUTJvOEFhODhySWxX?= =?utf-8?B?MFQ1MlRSMjBxTU9HZ1Vzam9taVRBVE1zd3BDWU1YWGdxZ0NBdFBBb1BuU2tF?= =?utf-8?B?NGY0V0RWMjFyVmpVaEpub0tENDZyaUJMZmxwTzBvaGk5UkpFK0xzK2xoa3do?= =?utf-8?B?QWkwcEJhV3VYSW1RNk5hM1lSNEQ2N3FhMVJHaXRXblZ1RHpYNEFYMWxKb0VQ?= =?utf-8?B?RVU1d09hcVlEU2JnbDdiTGl5OUxobm1vZ2taZXc3TStqL1pjK1dqS0lDZjY3?= =?utf-8?B?aVVYbk5UaW5qQlErNFo1cEZTcFF1ck9lSXJPNjV2NTJ3ZjZZT2xFMG1UaWxE?= =?utf-8?B?WTB5QVZ5Z3NxdFR0T1U1NjZ6bGpOQW5NT0VSSlVuaGxGRlVnUHFkdmMwNVAv?= =?utf-8?B?Y3V0SXhTY1ByTVlQMGtqYlpEaCt2QThwM1BGMXhRM2ZVOHVPUFcxQk5tWUMx?= =?utf-8?B?RU9ZSUplemFXUG9jZVo2bklFSUdocloxT09QcUlxcnEvZVFCeTZvTWt5NVNy?= =?utf-8?B?VU82TzFNWW5XNHZrNHRBMGd1S2FodlEraUVRTTkvZFo3OElyMkIzN2NRSjY1?= =?utf-8?B?emFsU2l4ckpPTVNxeTJBSXlBbDRCQjIrT05UMTlnWk55TDV2Y2U0ZndoR1ly?= =?utf-8?B?TmtrZU1PaWQ4NjBqbUp2OTcya09vOS83Z3liVllYSUppQW1jbTVZR0xtSk1I?= =?utf-8?B?dHV1VFNXNFlUdlJubjNpOXZYTlVhdE1HdGtweXArOVk1UWFJNGlycHZSNm9J?= =?utf-8?B?YlNMWS9QTDJ0dVltQjdmeFArbmdtK2pYY1RoT0EvQzUyOHZpbFJyNjhkYmty?= =?utf-8?Q?09ZUabAWlIF9Io+QjmtJDshCA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1966f28a-9e88-493b-4db9-08db4d6786b3 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 12:52:04.1086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ntEnEA/Y5iBljwUpgE4vR5OjQcevwdO+x7WwaXJ4bABSNyMs2q31tFADARCDA9ToJClYuy2wppbLDZCLaIzO6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9395 X-Spam-Status: No, score=-3028.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: If in a "word ptr
" or alike construct the "ptr" part is double-quoted, it shouldn't be recognized as the specific keyword we're looking for (just like we don't recognize double-quoted operator or register names anymore). Be careful though to tell closing from opening double-quotes, as a quoted symbol may follow right afterwards. --- a/gas/config/tc-i386-intel.c +++ b/gas/config/tc-i386-intel.c @@ -188,15 +188,12 @@ operatorT i386_operator (const char *nam if (i386_types[j].name && *pc == ' ') { + const char *start = ++input_line_pointer; char *pname; - char c; + char c = get_symbol_name (&pname); - ++input_line_pointer; - c = get_symbol_name (&pname); - - if (strcasecmp (pname, "ptr") == 0) + if (strcasecmp (pname, "ptr") == 0 && (c != '"' || pname == start)) { - /* FIXME: What if c == '"' ? */ pname[-1] = *pc; *pc = c; if (intel_syntax > 0 || operands != 1) @@ -204,9 +201,8 @@ operatorT i386_operator (const char *nam return i386_types[j].op; } - if (strcasecmp (pname, "bcst") == 0) + if (strcasecmp (pname, "bcst") == 0 && (c != '"' || pname == start)) { - /* FIXME: Again, what if c == '"' ? */ pname[-1] = *pc; *pc = c; if (intel_syntax > 0 || operands != 1