From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by sourceware.org (Postfix) with ESMTPS id 25374384BC2B for ; Wed, 25 May 2022 13:42:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25374384BC2B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f47.google.com with SMTP id r6-20020a1c2b06000000b00396fee5ebc9so3384942wmr.1 for ; Wed, 25 May 2022 06:42:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=aJ9ruNHwOIyW8LieTketXpXS3yYULnBZWeMaeS8iqso=; b=cfR65IRkqGor0YeVSN6RWx/2vuX/pDP3pi9VpJ6rYrndRZLQjuTGoZFQl1O6TzougJ aLb+Wk44YWbjYuoQRoZRErMIR2pvGPsMYbx8aM8sRjcNa1Ho7VwDVu/aZF7Gheel3wBq xmIDaHknZp8Zlw9ZgtaRb8dUo+GOF/5eQcBPbuE3NZ55PRntmmKaZHt0npSuOKJO5vmN NMtSmvc3zgTiiWiojZWa0+FIbcVXBz7nutWQyZgMj6pdjhAcGKS82uBSstDe21wk/Qm7 knDJiQ6hvJUHzFBW0a3oW2E68KtJe1igBuhtpBDyXnW3h9SWAkCfTawi0OiKODpqJSFb Y3Xg== X-Gm-Message-State: AOAM531wiQFraaqueB04agDJHjTP1yQcoP5LX/BbzM2wgBdTx1dtNwIg IUEFb8r9+XBvCsCcrntNFdLBmt74iVQ= X-Google-Smtp-Source: ABdhPJxKw66eQX8orkQ76VbpSZNibQEOcpy73jU7K1aHSZAEjieh7+3Vej3Zrerik9p4fUDb+PmeYw== X-Received: by 2002:a05:600c:4e0a:b0:397:3ea8:8f6a with SMTP id b10-20020a05600c4e0a00b003973ea88f6amr8532381wmq.191.1653486175132; Wed, 25 May 2022 06:42:55 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id j20-20020a5d6e54000000b0020e5d8dbbb8sm2223095wrz.56.2022.05.25.06.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 06:42:54 -0700 (PDT) Message-ID: <9d4400a363f3019cc7e005abf39fb9c770982957.camel@debian.org> Subject: Re: [PATCH v2] ld: add --package-metadata From: Luca Boccassi To: Alan Modra Cc: binutils@sourceware.org Date: Wed, 25 May 2022 14:42:52 +0100 In-Reply-To: References: <20220515191846.114257-1-luca.boccassi@gmail.com> <20220524211507.177629-1-luca.boccassi@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0kNDj/Cm77pEjiBIK5xJ" User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, BODY_8BITS, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 13:42:57 -0000 --=-0kNDj/Cm77pEjiBIK5xJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2022-05-25 at 15:32 +0930, Alan Modra wrote: > On Wed, May 25, 2022 at 02:00:08PM +0930, Alan Modra wrote: > > On Tue, May 24, 2022 at 10:15:07PM +0100, luca.boccassi--- via Binutils= wrote: > > > v2: fix style issues > > > =C2=A0=C2=A0=C2=A0=C2=A0fix ASAN issue: note storage is rounded up, b= ut that size > > > =C2=A0=C2=A0=C2=A0=C2=A0was used to read the json input, which is fix= ed > > > =C2=A0=C2=A0=C2=A0=C2=A0add entry to NEWS > > > =C2=A0=C2=A0=C2=A0=C2=A0add note about json validation to docs > >=20 > > Looks OK to me > >=20 > > > + if (json_length > SIZE_MAX) > > > + { > > > + einfo (_("%P: warning: --package-metadata is too long, ignorin= g\n")); > > > + return false; > > > + } > >=20 > > except for the above dead code. OK with that removed. >=20 > And how having applied your patch locally and tested, please do look > into fixing > FAIL: bootstrap > FAIL: bootstrap with strip > FAIL: bootstrap with -Wl,--traditional-format > FAIL: bootstrap with -Wl,--no-keep-memory > FAIL: bootstrap with -Wl,--relax > FAIL: bootstrap with -Wl,--max-cache-size=3D-1 > seen with #define HAVE_JANSSON 1 >=20 > The errors are of course all due to undefined references to libjansson > symbols. Thanks for the review, I've fixed both issues in v3. --=20 Kind regards, Luca Boccassi --=-0kNDj/Cm77pEjiBIK5xJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmKOMlwACgkQKGv37813 JB5lxg//VmKbe9zE0otRwLxkv5hxhoQwHuZJIMjJ4UzyjxZO2B2xNHjNKctcjKYz MopqNda/YK6f1iEaszhKc+DVpml0KGWLyC2HXS7AP91BOgcdaPAPSnm1TpicL+52 pZa1UDxM1SfOr2i59vdrzFoJ4UgfJ8uDAUC8PXp+TVehgBjeSijlx6qqbzldIkk3 t0i4HCQNA9vh622DVJYm5L+70eovm05/7OusKf+ALI8tixkSvrYkIQXa132/3Qz1 mbvIj4ODyUvhfoSQa32dVV5qF8Coii51MQ3S57GfRvXO16hFHpY977Ll/9ArseNi mkHF2ok9vOyH56BOVSTlVQBiQYt57aLsJEGBTAYp/II8yrEFBUA+Tg5njab1aV9a 8kHQboWzIOb1cMe5blfsdoaWhtWcwtftzcXBgPIHTvJMYMMmcwxX6+ERin/0Kj3n 1hNDgHjuwG1vpvOIuKnAYcSNTcwNN56jkT1BrfRDB5Wk8U6z4lIuzaCC5mYdUD1q tCodAvDYySzsHajczvjCePvgDlQnRrD2HoR/C5enU3byM3g/M56gdXQ1ng9Ddiov gbYqQbKkSlMJXzpJZQvnkA0bKRUVPjkshM63p0Fcz8YoV5/tsi4EInwm45AcHWag ESDF7JppAXNPpLMaHVqZ2ZmdTX55ON/LnxirNKZ27F5s64G0Fps= =Xcl5 -----END PGP SIGNATURE----- --=-0kNDj/Cm77pEjiBIK5xJ--