public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH, binutils, ARM, 0/16] Add support for Armv8.1-M Mainline
Date: Fri, 12 Apr 2019 10:39:00 -0000	[thread overview]
Message-ID: <9d62b2e9-80fb-1b31-2271-79ad052f8a25@arm.com> (raw)
In-Reply-To: <bd31fdec-4529-8aa7-f7df-144c6f93fcce@redhat.com>

Hi Nick,

Thanks for that! Most of them were testisms.  Though there was an actual 
issue with big-endian and the LE instruction.  I replied to each 
relevant patch with an updated version.

Cheers,
Andre

On 11/04/2019 11:04, Nick Clifton wrote:
> Hi Andre,
> 
>> This is a patch series to implement support for Armv8.1-M Mainline. The specifications for the Armv8.1-M Mainline can be found in https://developer.arm.com/docs/ddi0553/latest
> 
> The patch series looks fine to me, apart from two small problems:
> 
> 1) It introduces some assembler testsuite failures for non-ELF based
> ARM toolchains:
> 
> Checking Binutils in: arm-wince-pe ...
>    GAS REGRESSION: Valid Armv8.1-M Mainline BF instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFCSEL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
>    GAS REGRESSION: Valid Armv8.1-M Mainline BF instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFCSEL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
>    GAS REGRESSION: Valid Armv8.1-M Mainline BF instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFCSEL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
>    GAS REGRESSION: Valid Armv8.1-M Mainline BF instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFCSEL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline BFL instruction
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
> 
> 2) It introduces some assembler and linker testsuite failures for
> big-endian ARM toolchains:
> 
> Checking Binutils in: armeb-eabi ...
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
>    GAS REGRESSION: Valid Armv8.1-M Mainline Low Overhead
>    LD REGRESSION: Armv8.1-M Mainline BF
>    LD REGRESSION: Armv8.1-M Mainline BFL
>    LD REGRESSION: Armv8.1-M Mainline BFCSEL
>    LD REGRESSION: Armv8.1-M Mainline BF
>    LD REGRESSION: Armv8.1-M Mainline BFL
>    LD REGRESSION: Armv8.1-M Mainline BFCSEL
>    LD REGRESSION: Armv8.1-M Mainline BF
>    LD REGRESSION: Armv8.1-M Mainline BFL
>    LD REGRESSION: Armv8.1-M Mainline BFCSEL
>    LD REGRESSION: Armv8.1-M Mainline BF
>    LD REGRESSION: Armv8.1-M Mainline BFL
>    LD REGRESSION: Armv8.1-M Mainline BFCSEL
> 
> Would you mind taking a look at these please ?
> 
> Cheers
>    Nick
> 
> PS.  This was from testing with the entire patch series applied.
> I have not narrowed down the specific patches that introduce the
> new failures, but I assume that it will be simple for you to do
> this yourself.
> 

  reply	other threads:[~2019-04-12 10:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 13:24 Andre Vieira (lists)
2019-04-04 13:28 ` [PATCH, GAS, ARM, 2/16] Add CLI extension " Andre Vieira (lists)
2019-04-04 13:28 ` [PATCH, binutils, ARM, 1/16] Add support for Armv8.1-M Mainline CLI Andre Vieira (lists)
2019-04-04 13:34 ` [PATCH, binutils, ARM, 3/16] BF insns infrastructure with new bfd_reloc_code_real for fallback branch Andre Vieira (lists)
2019-04-04 13:34 ` [PATCH, binutils, ARM, 4/16] BF insns infrastructure with array of relocs in struct arm_it Andre Vieira (lists)
2019-04-04 13:36 ` [PATCH, binutils, ARM, 5/16] BF insns infrastructure with new global reloc R_ARM_THM_BF16 Andre Vieira (lists)
2019-04-04 13:37 ` [PATCH, binutils, ARM, 6/16] New BF instruction for Armv8.1-M Mainline Andre Vieira (lists)
2019-04-12 10:41   ` Andre Vieira (lists)
2019-04-04 13:38 ` [PATCH, binutils, ARM, 7/16] New BFX and BFLX " Andre Vieira (lists)
2019-04-04 13:38 ` [PATCH, binutils, ARM, 8/16] BFL infrastructure with new global reloc R_ARM_THM_BF18 Andre Vieira (lists)
2019-04-04 13:39 ` [PATCH, binutils, ARM, 9/16] New BFL instruction for Armv8.1-M Mainline Andre Vieira (lists)
2019-04-12 10:40   ` Andre Vieira (lists)
2019-04-04 13:40 ` [PATCH, binutils, ARM, 10/16] BFCSEL infrastructure with new global reloc R_ARM_THM_BF12 Andre Vieira (lists)
2019-04-04 13:41 ` [PATCH, binutils, ARM, 12/16] Scalar Low Overhead loop instructions for Armv8.1-M Mainline Andre Vieira (lists)
2019-04-12 10:40   ` Andre Vieira (lists)
2019-04-04 13:41 ` [PATCH, binutils, ARM, 11/16] New BFCSEL instruction " Andre Vieira (lists)
2019-04-12 10:39   ` Andre Vieira (lists)
2019-04-04 13:42 ` [PATCH, binutils, ARM, 13/16] Add support for CLRM Andre Vieira (lists)
2019-04-04 13:43 ` [PATCH, opcodes, ARM, 14/16] Add mode availability to coprocessor table entries Andre Vieira (lists)
2019-04-04 13:44 ` [PATCH, binutils, ARM, 15/16] Add support for VSCCLRM Andre Vieira (lists)
2019-04-04 13:44 ` [PATCH, binutils, ARM, 16/16] Add support to VLDR and VSTR of system registers Andre Vieira (lists)
2019-04-11 10:04 ` [PATCH, binutils, ARM, 0/16] Add support for Armv8.1-M Mainline Nick Clifton
2019-04-12 10:39   ` Andre Vieira (lists) [this message]
2019-04-12 13:51     ` Nick Clifton
2019-04-15  9:41       ` Andre Simoes Dias Vieira
2019-04-16  1:58         ` Alan Modra
2019-04-16 11:52           ` Andre Simoes Dias Vieira
2019-04-16 12:36             ` Alan Modra
2019-05-01  9:32               ` Andre Vieira (lists)
2019-05-02  1:21                 ` Alan Modra
2019-05-15 15:34                   ` Andre Vieira (lists)
2019-05-20 10:31                     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d62b2e9-80fb-1b31-2271-79ad052f8a25@arm.com \
    --to=andre.simoesdiasvieira@arm.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).