From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2041.outbound.protection.outlook.com [40.107.104.41]) by sourceware.org (Postfix) with ESMTPS id D4F613858D1E for ; Fri, 20 Oct 2023 06:25:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4F613858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4F613858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.41 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697783139; cv=pass; b=U/C9RgXTmYfK9r2qq7quLZiSvIbnEgPoqjMbzDqq0KgwV3rqvugHzCFVHQzQxjmKHeYQ/6KxZBECvtana3bKcntsLcHltR0x4ZpTL+NEX+Fk4K7Vb0iOM+56vo91TZViqXNcom6JoEfYFRrfDK6dfQJ82s0Szxmu6KpXS6DCxAM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697783139; c=relaxed/simple; bh=HrPLx6/SLAKceId33L6bVZfA2hP6/c3Q/yeVq043XG0=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=aVAKqCEHSia3WvRtWz2R4CDCNMM/fERSI7hVeBwTnhqFVXYadWh9qgMkkIFjuXGPwUoLtwa/glteomv7lg1KeNhUg7BbFLf5Ubhfu4jcOBjWh+ifZ6dLz3C3PFhvZamxwNJHNLpf9qIzkigBIlnDh0kX5Jg2eJp0MRTfMwV30Lw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SqPJPiRQgpIcuiqbKwJevg7nZSwuFzrv6hgS57POJf+CwE1QOO/S8C+ISh2WODWCqGdaDJGu2p0ISICYMjL7QVsiVGy7SPrYjy69oJkbxaACHDkBCJRBEdmMRVwe1dP2A0Bqm5Qw76wQT5xf31ghRCvIUk9eSUrAFzKVfANggj9qwbIV9WGBrEkrjVCO1Cy/BeFsosTEDDwm5iMPx2WEmzMh64E/gl9Ym+UBOsmwa45IPqE5TJWQJogJ33GMAyNAN8RCHdAQ/MadqKLbF2iSh7nJ/9sGeJqMtykA3WNg2VHv/ohSY5Chp4ocoq8vEf8HLWWqiakSVWCNIhXgpLsqfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oVWYyB0xnGNT4LLWMyiCC0H16cjUq+VZDRjx4vMwkBM=; b=nfpUH5l10CvK5mqYcQeUDAvuYQ/lw/zLVKYsuMt3iyHeEEbiSg2U01eP1jxepxyS5xFYg8qU++JcY1c3aRrceQwTUl5t/yIvPM0Pfo25Ghv7vQaTxN/GPoGsX6rW9xb5fHMXw6itCNxNhPTpXy9mbBxYFiL9CBmwK+iKUyQVt6MC9OuMJvW0q/wTC6fNXkKykkmVTjqyPgXQGc9awugsWuu8EBCKi9ZA7maD6TBXx15r9pPm4j7Pah6EzAua23iTmep2fSbwOtQahjm7g5I0WVshJDDQtaQCrhLuSSZgZ2v3Wqw4OiFj5sHdnS2iWJNMczVlucWY92KKPjcWASNFtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oVWYyB0xnGNT4LLWMyiCC0H16cjUq+VZDRjx4vMwkBM=; b=XTBmyY+FIWsknkjkf537gD2S1sLh3fo3LBqqklADlRpcpguk26bmjg2oqP9EA3C5RBibmvameTMjDCz75jehpA5avvjSi1kjiKhvggmzvGwwuu7nVl+2UYYCquns4dvGAHRZpwpYHcJQ3NTz9BA95S5ze6rdyc35Mm9xc/tAmCa6DAKz8bQs05H+i1OciPAlfZ7p9yaX07m7PIvlZQIzGhUy3pJOuZzyDutpJE6uf+4uDmZyGWPEQUdoiH783iJDWBZQ27INRjOx6/Hr7das+oRn70T1RLh1+8Wb7g98edj52Jr2KEhsXd/ofVY1p4Sk7vnZiFqmtiHpTukntPtZQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7859.eurprd04.prod.outlook.com (2603:10a6:20b:24c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.8; Fri, 20 Oct 2023 06:25:35 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3%7]) with mapi id 15.20.6907.022; Fri, 20 Oct 2023 06:25:35 +0000 Message-ID: <9d65b188-1a3b-a303-72bb-3abc9d79afb2@suse.com> Date: Fri, 20 Oct 2023 08:25:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/8] Support APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-3-lili.cui@intel.com> <9c3a051e-d7f2-26a7-8013-9b0081a54023@suse.com> <176bf162-764b-e103-2985-f1d5ffe3d869@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7859:EE_ X-MS-Office365-Filtering-Correlation-Id: 71110b92-9601-4bef-a217-08dbd1355ed5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j2YS4eHRFGujtryglX9xp54oCjcYiYLHLv3dvMR8UTDeu3psB7fHMZuz2/ZVu5vSkSpyx3SUORGhDj2/PdExPSWu5njembbdtzxQ+GgIxtnUQJfM940sVZ3+NrLujq1g1NxQ3yrFKb2pZA1nifbTyEiPdMqVm1iCeRdO3cEzQWF3f1SmZwF9QA30IlsJ1dmiEkRsKIx6rbtupijRbNQQDJOlOpA9x24jLGfp5ULjplBZvsN5gfabCZiOLzvFK2rilspijbn43HnQL9aWg7kRRpZ8o1uH/tHkbEVYfh9kFBnt+cFxuTBWo83f59BmwjTVDjwRiq7xdLa9FH0jeUQHQdEPX1KdHJ2W5tlrd9r8cv1nWukGQhY8Gvz1XN0Mh07JvwHVGKeE+sb6a3j3wpQsdhHdncKpllqXWDJaVh4bq5lL4ksvoByTHEHTfBDb1L3GYXEHXadXvxSHrjQqSSk2Ue3jIhxWhvNOR0YOnj6UJwUi7CZBLz+GbGatrh7SJdKvjZ7bhW5gi6SQDuiSt1VWW23Wnbk9Z3GONQ2mI/lQdNAa0yZSxwdZFE+z2QwQWQ+8gi7yO6grfFLw7vJXrfub4cETCKkMGyXot3Q54N5yY0mpMK/ag1aopsQAnoKIVHuSQ7g3/zPvTJCjLVA15THtsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(346002)(366004)(39860400002)(376002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(2616005)(26005)(6506007)(4326008)(8936002)(66476007)(8676002)(66946007)(66556008)(54906003)(53546011)(6512007)(41300700001)(2906002)(316002)(6916009)(5660300002)(478600001)(6486002)(38100700002)(31696002)(86362001)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0Yxek1XYWh3LzFhL3dJTlQyZnYrbFUxN1ZxOWYwamFCbFVKMmVSSkpQeWY3?= =?utf-8?B?WkRCSFZWOG1RNEZScEhtcngxUFZoWHlqd25rS3NaVyt3TEcwWEZGcXcwQUs1?= =?utf-8?B?MGNKc3hnaWRVZEdKZTUvMFNBbVljajMxLzV2ZjA4M2tETDEyM0czbmNhRXdZ?= =?utf-8?B?UGFkZzBzUmlrNkNyUCtxam5KcDZNSHV3b2hTT09UUW12N09ndEw5RkFYVm9U?= =?utf-8?B?OWhoS1BNVkpkK2FvOWUxZFQzYmpyK3c3UkVlLzgrZ2kxWDFyOU80RDdIRnpp?= =?utf-8?B?d1QzUUtDNG9sb0UxMDFKQ3NpZUhORmlOdFNtL2NWK0lNMU9Qd2VvRWowNGMr?= =?utf-8?B?aUlHb2JtMkIvNjN6WEcvcFpGTnl5L0hEd1lPT0E4NXZGelJLVksrcjAyUi9y?= =?utf-8?B?U25pR3UwQ3BqVTNzYnlzaTRhRjZ2YktiYXM4U0pBNlU0ZFBOWVdJTklWZjN3?= =?utf-8?B?QlVpUW43aWdqY2E4RkNFbFgvdTZ0bzdNSEZaZHJTV3puYnB5dUNOUGhRY3lD?= =?utf-8?B?TVNNQ0R4dVdOdzRKdVp5MHFmeEM2NTh0dk53MlprQWt0K29CV2ZMUnhTY0ZZ?= =?utf-8?B?YjF4RndoZ0JJVTg3ZmRqOGlwdlhsT1RQSjhKNDVNSkttS1dWQkVRQlJRbmN5?= =?utf-8?B?dmNQZitMKzhNSDFub1BRbWZJdHdIdWNYaGRxRG9XMFFmblhQUCtvUnZPOVBL?= =?utf-8?B?emhkWWpqL2FpM25GVEtaR0FJbUUzZ0JsRDNwb3N5Y01hTWNoYnlQMmNJMHRB?= =?utf-8?B?RHVGQnNuVUJ3K2RneG1lNFRLa0xrZTdSQlpDa0dZS3VGSjlzREhqeHVESHBC?= =?utf-8?B?SjhoTitvMkx2N0E1ckdzV3BVckdYbDFlVGxuWHowRU42SU4xWlFoY2VrRTdi?= =?utf-8?B?V0lqNWk5TmlHMzhoUWZxMUIzRlhSUU9RZnhiUFZTRDc1YVdmNmZ3S25URXp5?= =?utf-8?B?akFST3ZmUkdYb2RSMytZQnl2T2szdUkwOUx5d001VGd0RmxHaGJuUWNYREg4?= =?utf-8?B?WkRIdnVVeWxYV2k1TC9HWEd6TWxxQ0w1NmZyUkN4UUZyWDdKRmd3WXNMVDZT?= =?utf-8?B?NGZseTV6VUxtRXpOUVE0dE9Vald0WnFhd1M5SWlqRndxU2UxRDVqeEtTeVpy?= =?utf-8?B?d3M3MDNIdjVRT216YVdBSXZhdjdTdVRIU0wrdmtsN2RFaUlTS2ZVcWVhQk4y?= =?utf-8?B?ckkzek94eStvU0RKWDh3dk1OUTBYU3E0TU92NUdkUEIrVVptbmY1OENRZlBv?= =?utf-8?B?RnRhREVLcTcrMjV5MTg5VWNQcm5QTHRQVk4ySlRBaVBYWmgxdkhDV2JzRjcw?= =?utf-8?B?V2tvdkxxMlRkRHptQXhIbDdwRWc2cHBGdlhGdk1zRUxhbGxWQnZDYkNVQnBq?= =?utf-8?B?QWcvRWNkRXhrZ2FGMVhjeXZZTDVQSjJhSUo0V2xSM3I0dEViSFJLakRZVjdF?= =?utf-8?B?dG1CZEU3UjNHYTlzZDRqRW1wcnFYVDZNRnEzR0JVd2tJb0VjZkUyWHZsWE1H?= =?utf-8?B?MDJyQm9DYWt1OURoYjQ4YldGMXpxUTRRVUhFY0pzczRsVWYxY2FoNTB6ejBT?= =?utf-8?B?VzM1SElFZGZybVBWbWJhaG8rRU8xRFVpRlIrYzFWbzFBaWxDU1hYb1RqR0pT?= =?utf-8?B?WFloazc0ZlY2MFJadkduZFdvQkNWd3l4Q0dLbElyd2JwT1JrOStIZVJEVXFo?= =?utf-8?B?ZEhrYTdVQkZMYnZrRHVlVjErcUY3Z3F4Y3pRMGo2ZjFUamk5NDJhNUlVeGZ4?= =?utf-8?B?dlp2b250M3dtT003aUhyb2Y3ODgrTXp5a096NGpnczA5d1pBVG1QdExjeFZl?= =?utf-8?B?ZVhQWm5mU1d6dyszQXBtNWllVHQ4RVFXbUYxM0JDRk9oOXRoYjBjZy9yUktw?= =?utf-8?B?N29tRTl1YTRKVzQyaWFMZTJ0QUVYOXg5MlllMzFJczFZZDl0V2VhN2pKZjNt?= =?utf-8?B?L2s0M0thRmJsbmxzY2hVQWVOVlQxYWx3VTBOMlk3MXFYMm9seDZjd3EyNlpG?= =?utf-8?B?WktVZVMyTC9rOTJXUTRpdjQ3bVBDNHY4VElWbVB1S1pQZFoyb09wbUM5MFRr?= =?utf-8?B?WExUaUpXdHo0b0ExRy8xQ092MDlCOWRKQ3JHS3lrbEozVXlyZDJwRUthQVI1?= =?utf-8?Q?V5gLFxHN9P1qAfu/tGzeI/gF9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71110b92-9601-4bef-a217-08dbd1355ed5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 06:25:35.8549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ITXNqv+pY32/yzah2t691ZNkpN57E6p5kF2n6/rDUMep+2UrfFDsmNxzlzRQ9FtiRlTNHx6HOp6TKQdg1CN4zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7859 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.10.2023 18:38, Cui, Lili wrote: >>> @@ -9063,6 +9066,22 @@ get_valid_dis386 (const struct dis386 *dp, >> instr_info *ins) >>> } >>> >>> ins->need_vex = 4; >>> + >>> + /* EVEX from legacy requrie EVEX.P[17:16] must be 0, EVEX.P[23:21] >> must >>> + be 0. >>> + EVEX from evex requrie EVEX.P[17:16] must be 0. EVEX.P[23:22] must >>> + be 0, EVEX.P[20] must be 0. */ >>> + if (ins->evex_type == evex_from_legacy || ins->evex_type == >> evex_from_vex) >>> + { >>> + if (!((*ins->codep & 0x3) == 0) >>> + || !((*ins->codep >> 6 & 0x3) == 0) >>> + || (ins->evex_type == evex_from_legacy >>> + && !((*ins->codep >> 5 & 0x1) == 0)) >>> + || (ins->evex_type == evex_from_vex >>> + && !ins->vex.b)) >>> + return &bad_opcode; >> >> I guess I'm confused here: So far we don't use EVEX.P[] as notation in >> comments. Can you please use the respective field names instead? Also can >> you please improve readability by converting !(a == b) into a != b? >> > > Changed it to: > > + /* EVEX from legacy instructions requrie vex.mask_register_specifier, vex.ll > + and vex.zeroing must be 0. > + EVEX from evex instrucions requrie vex.mask_register_specifier and vex.ll > + must be 0. */ > + if (ins->evex_type == evex_from_legacy || ins->evex_type == evex_from_vex) > + { > + if ((*ins->codep & 0x3) != 0 > + || (*ins->codep >> 6 & 0x3) != 0 > + || (ins->evex_type == evex_from_legacy > + && (*ins->codep >> 5 & 0x1) != 0) > + || (ins->evex_type == evex_from_vex > + && !ins->vex.b)) > + return &bad_opcode; > + } I guess my earlier response was ambiguous, I'm sorry: I didn't mean the disassembler's internal names, but the field names as per the SDM (e.g. EVEX.W). Also (nit) please avoid typo-ing "require" even twice. Jan