From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D13A23857714 for ; Mon, 9 Oct 2023 13:49:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D13A23857714 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696859354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S28lJcf6zELpMkpXohVO3eq+7UHcHVQkaH3w40YhomM=; b=HH5sz+3b/5t1DCVjl2kv6JgrnulyYFQjm2YltlNTEQOCi2GJkY5jcnJL6QwCULesqMoYpL jBz0prJWDu7fscnI+dEWEAU0gpbrrXWNN78vFmDbDahFIvffYeKLmfPIJRV6oG9lOP6uFB 8v5UlwOBeEEwhWy0K4txdS92x/+F2jA= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-jQ78XmD1N2OfzP73OjJD1w-1; Mon, 09 Oct 2023 09:49:13 -0400 X-MC-Unique: jQ78XmD1N2OfzP73OjJD1w-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-65b0d19bfd0so56579616d6.1 for ; Mon, 09 Oct 2023 06:49:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696859352; x=1697464152; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S28lJcf6zELpMkpXohVO3eq+7UHcHVQkaH3w40YhomM=; b=mIg9VP//i8B3JaZT6E69m9xiM1zsBlEqLMdfLQuyesuku7DJGoyXBjlMpdb2hjygnw 0WjTjSActgje/NjCFdPLJ3GIHbpn+vCbcAZ5p+anNCig0icx8dDV3abOX8YikbFoT+0V lVdyU14n13ZzojOtZQKXIUqYLA75xaTPiH42HgUcsRqHfVChfUdwvlC8xDLU3978wnxS fwQRKbUIPB7H5yNjlpVTwNVWhM8rJ6xHkWU2R7dp5Sr5FOHUeycApTJI8CLsRWDKIL+h pUiEjJ/xmy2XDANplqBk9xI/++JieJZ4l89kNDZYtw8GIzNI1hAPvsAPtLuIzgmPfxpO s72Q== X-Gm-Message-State: AOJu0YzEJl/VPnt7/qdWR9rl2Z29vTO1nXbAx0xXWOmILnRnSMmWgpxB 616sw5dximqWkUXYmmxxLJbvQ9OsmtHePP/Y1pHDkYDBBIFS5RmVVRyzLbpgCn9EOZbUIQdAvli StYU2J1tGrZDuY4BaAEvp7hlASQ== X-Received: by 2002:a0c:e78b:0:b0:64f:6199:a8e with SMTP id x11-20020a0ce78b000000b0064f61990a8emr16468361qvn.23.1696859352385; Mon, 09 Oct 2023 06:49:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyM4IZMYNaS7TRGMcmeLhI+BQGvENL3xneN2LGPwSuPYg1P4PvdFROcgmyHh73ncxuvzlhXg== X-Received: by 2002:a0c:e78b:0:b0:64f:6199:a8e with SMTP id x11-20020a0ce78b000000b0064f61990a8emr16468349qvn.23.1696859352165; Mon, 09 Oct 2023 06:49:12 -0700 (PDT) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id t10-20020a0ca68a000000b0065afcf19e23sm3832264qva.62.2023.10.09.06.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 06:49:11 -0700 (PDT) Message-ID: <9d938236-cf37-a3a2-a530-1905ff8d38a9@redhat.com> Date: Mon, 9 Oct 2023 14:49:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/2] [readelf] Handle .gdb_index section version 9 To: Tom de Vries , binutils@sourceware.org References: <20231006174942.27361-1-tdevries@suse.de> <20231006174942.27361-3-tdevries@suse.de> From: Nick Clifton In-Reply-To: <20231006174942.27361-3-tdevries@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, > Add the abilitity to print a v9 .gdb_index section. > > The v9 section contains an extra table, which is printed as follows: The patch looks good to me, except for one small issue: > + if (version > 9) > + { > + printf (_("\nShortcut table:\n")); > + [....] Shouldn't that test be for "version >= 9" ? Patch approved, possibly with a small change if the suggestion above is correct. Cheers Nick