From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v2 3/4] x86: break gas dependency on libopcodes
Date: Mon, 21 Nov 2022 17:32:16 +0100 [thread overview]
Message-ID: <9d95d33c-7f9a-a64b-7ac0-9ee96f0b99f5@suse.com> (raw)
In-Reply-To: <CAMe9rOpdseDUCEq-vJx=KfrUy9BzCh5Oc+P0NwPOqqyZ8aYhdQ@mail.gmail.com>
On 21.11.2022 17:26, H.J. Lu wrote:
> On Fri, Nov 18, 2022 at 1:13 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> gas doesn't use anything from libopcodes anymore - suppress linking in
>> that library.
>> ---
>> v2: New, split off from larger earlier patch.
>>
>> --- a/gas/configure
>> +++ b/gas/configure
>> @@ -12263,7 +12263,7 @@ _ACEOF
>>
>> # Do we need the opcodes library?
>> case ${cpu_type} in
>> - vax | tic30)
>> + vax | tic30 | i386)
>> ;;
>>
>> *)
>> --- a/gas/configure.ac
>> +++ b/gas/configure.ac
>> @@ -420,7 +420,7 @@ changequote([,])dnl
>>
>> # Do we need the opcodes library?
>> case ${cpu_type} in
>> - vax | tic30)
>> + vax | tic30 | i386)
>> ;;
>>
>> *)
>>
>
> We need to add some dependencies on i386-opc.tbl and i386-reg.tbl for
> --enable-maintainer-mode to check if i386-tbl.h and i386-init.h are up to
> date. It doesn't need to regenerate i386-tbl.h. An error message should be
> sufficient.
This isn't needed here, but in patch 2, where I'm already adjusting
existing dependencies. Since I'm not modifying any toplevel files, the
building of opcodes/ still ought to be happening before the building of
gas/, so I don't see why any further changes should be necessary. Please
clarify if you see any such reason.
Jan
next prev parent reply other threads:[~2022-11-21 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 9:10 [PATCH v2 0/4] " Jan Beulich
2022-11-18 9:12 ` [PATCH v2 1/4] x86: instantiate i386_{op,reg}tab[] in gas instead of in libopcodes Jan Beulich
2022-11-18 9:13 ` [PATCH v2 2/4] x86: remove i386-opc.c Jan Beulich
2022-11-18 9:13 ` [PATCH v2 3/4] x86: break gas dependency on libopcodes Jan Beulich
2022-11-21 16:26 ` H.J. Lu
2022-11-21 16:32 ` Jan Beulich [this message]
2022-11-21 16:43 ` H.J. Lu
2022-11-21 16:52 ` Jan Beulich
2022-11-21 17:04 ` H.J. Lu
2022-11-22 7:15 ` Jan Beulich
2022-11-22 16:38 ` H.J. Lu
2022-11-22 17:05 ` Jan Beulich
2022-11-22 18:21 ` H.J. Lu
2022-11-18 9:14 ` [PATCH v2 4/4] x86: drop sentinel from i386_optab[] Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d95d33c-7f9a-a64b-7ac0-9ee96f0b99f5@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).