From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 62E92385828D for ; Thu, 4 Jan 2024 08:02:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62E92385828D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62E92385828D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704355384; cv=none; b=NJB3FX4uaJRb16qt08zcS+YxZJFs5uqcSSoX/jBB1Uu+qdrMhPwnJL2/aErVsvcus6+q6otoFqcE8x5tYYH9ExAdeUHUgRJVvznc38VvwSu4JCod/3Qea0a5rcY3rKyK1BuM6hA2/ET0PiQY1S5aYAbSMr5OW2Rkcp5Mh7nts+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704355384; c=relaxed/simple; bh=KzUAX0BndIFuRj1KUJ+sVPbOmB5gtZZqd1sZuw1wrV4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FuOT/wbiua61knmi0nK/1xtsZ8F68oUG3m0XbG8D8ghD8Pvj4r8Mx+EIgxmOek3jv7GkwRCDxxheSGZi3vX0mxy4eGs7/arIPlu1+NSaG6xOtH+cKVIRIOALvcv7v/27BseIdaTzLXm9sjGnmfYU6eRWs8WPtmCVo227FKtPnc8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50e7d6565b5so244598e87.0 for ; Thu, 04 Jan 2024 00:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704355366; x=1704960166; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=LWhC4LfEdVIecTwDi2SIZYd0ndIvz2clEVQyb3mFMq4=; b=K6649MBUimge1AdaaiGGXvtqop7XERHHLzz7UYl7zYbxypjKqbdzm8MpdoM0xRNiYK 4YrLNv1UwTP3QAX9zpXcgVXTeyaC2MjQk7FbRdZSxNhmt3L7j0FLV+Rcn+usOqH+UoIX 4FnsrcY959ShB0idmkbTaiT6EMMlkAdjJ+aCSV5ZAR1JlMf+b8th/aSsweLxytiN2FFl li0EotR1yzz8wAEjoqKIVKPVi/MOvx2WDPlGqmNVszCnFYi6sVahRUFVbDQNxKxOjf8q 5vDpBCRG3AO4ATn36kh2JfjBvIqyrGWJQH/JzgfKWqC9yd0pWMoGwWxDbLyrqrSsDGYE AXYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704355366; x=1704960166; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LWhC4LfEdVIecTwDi2SIZYd0ndIvz2clEVQyb3mFMq4=; b=NzC1fL3i56p8sGF8p9MkmZZ+YBdl3Hp8m5z8nE6TlHgQTZFyBBQYNJlUWlUCUismES CJ7g+hW3gnXQPvpDyvvUryzEotBOX/SnKrkxShvuFJDgLnw/HPZYzM/MZcpr3oiDQwO3 40lBscUYievgHSuDpEOwgoRl09NJqUfNzucVskZZkwJzypQ8n8QpYUN21Y8sjklR4Ud8 KkEYkxnOkVwHpwfoll1YB/AtLCLuxyYUgRZq0is4t3nrbXIwTH2itdjBlucQKEwFVM5M rhRAPZopktgP+gT7zpY5+ApTMUSysCR6jV1YpaCDjdpJfAHNkVt+t7lWWuibOGlrGe46 mXYg== X-Gm-Message-State: AOJu0Yyn5MFIYn8XSHmc5pT3bpvffzF/CONVHwriIbgPXnDWHlsvTZaT 0akrIgKBavq6k2PGgB8EcSnZe4HT7l+cKrslodZB8h/6uQ== X-Google-Smtp-Source: AGHT+IFkIdVs+GqtNr8JpjZ0nDeNbvDbltdurCq3GC2kyoMqkH1bHNNocABZw9zkZA6LR1GPy+koKw== X-Received: by 2002:a05:6512:2381:b0:50e:a789:dd3b with SMTP id c1-20020a056512238100b0050ea789dd3bmr166557lfv.1.1704355365818; Thu, 04 Jan 2024 00:02:45 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ce13-20020a0566381a8d00b0046d9c8b1f2esm3588117jab.83.2024.01.04.00.02.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 00:02:45 -0800 (PST) Message-ID: <9d9ad3ee-1523-48da-925e-19bbc8f584de@suse.com> Date: Thu, 4 Jan 2024 09:02:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 1/9] Support APX GPR32 with rex2 prefix To: "H.J. Lu" , "Cui, Lili" Cc: binutils@sourceware.org, Nick Clifton References: <20231228012714.2989658-1-lili.cui@intel.com> <20231228012714.2989658-2-lili.cui@intel.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.12.2023 02:53, H.J. Lu wrote: > On Thu, Dec 28, 2023 at 01:27:06AM +0000, Cui, Lili wrote: >> APX uses the REX2 prefix to support EGPR for map0 and map1 of legacy >> instructions. We added the NoEgpr flag in i386-gen.c for instructions >> that do not support EGPR. >>[...] > > OK. I can't believe you approve a patch (apparently even a whole series) without any comment and without allowing me time to re-review it, when you _know_ that I put in a whole lot of effort to try to make this start out in good shape, rather than having to clean up afterwards. This isn't to say the patch still needs further adjustment - I simply didn't get to looking at the series again; before the holidays I didn't even manage to get through all of v4. Lili, along these lines, while formally it may be okay for you to commit with H.J.'s approval, imo common sense should have told you not to. Further, the bigger a patch, the more important it is that you trim context when replying. Every reader has to scroll through hundreds of lines just to find there are no other comments, just the "OK". Please be more considerate going forward, Jan