From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 693213858C54 for ; Wed, 8 Mar 2023 09:31:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 693213858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 905661F383; Wed, 8 Mar 2023 09:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678267888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K39nFuVl8/WFtlP/Oerr1tPHq06+061s9MjNMYkOL3c=; b=SDxYQJUjWNwOpwryIydT7H6E5B9crEEYHeXuY/tT9KAMYixIEc1gM+8FaontqN7lBh/d8X JngxCVOGZVTx/rq7q/GjMbUMl6bpISlxk/48xsc4CVbVOrBaVaq0x85AXOdVieQtnQUPVl NbWJRj1ZFUry56paD6bfczTc+l2kfEw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678267888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K39nFuVl8/WFtlP/Oerr1tPHq06+061s9MjNMYkOL3c=; b=SCQwk8Vxhh9dJ+ozPEGOtveiTlIUtbz5lwEBn6R3cwWZ1BGgY4aqndRfdklfsPS/g23UUC Gf5Keu5Ml4prvrBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 76F3E1391B; Wed, 8 Mar 2023 09:31:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9iHrG/BVCGRYPAAAMHmgww (envelope-from ); Wed, 08 Mar 2023 09:31:28 +0000 Message-ID: <9e098af0-2aec-8570-ee5c-439c39738284@suse.cz> Date: Wed, 8 Mar 2023 10:31:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v12 0/11 Add support for CRC64 generation in linker Content-Language: en-US To: Ulf Samuelsson , Nick Clifton , binutils@sourceware.org References: <20230306133158.91917-1-binutils@emagii.com> <22f15ceb-e5db-8fd8-94a2-57e87cea6574@emagii.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <22f15ceb-e5db-8fd8-94a2-57e87cea6574@emagii.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/7/23 19:08, Ulf Samuelsson via Binutils wrote: > > On 2023-03-07 14:59, Nick Clifton wrote: >> Hi Ulf, >> >>> Patchset XII >>> testsuite fixed to skip some tests. >> >> Thanks.  I have now applied your patch set. >> >> I made some small changes, mostly code formatting and correcting >> some of the error messages. >> >> Thank you very much for persisting with this patch contribution. >> > The Buildbot reports errors though! > > Best Regards > > Ulf Samuelsson > > >> Cheers >>   Nick >> >> Hi. I think this patch set caused the following build failure: [ 173s] gcc -DHAVE_CONFIG_H -I. -I../../ld -I. -I../../ld -I../bfd -I../../ld/../bfd -I../../ld/../include -fomit-frame-pointer -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -Wno-error -DLOCALEDIR="\"/usr/share/locale\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wstack-usage=262144 -Werror -DELF_LIST_OPTIONS=true -DELF_SHLIB_LIST_OPTIONS=false -DELF_PLT_UNWIND_LIST_OPTIONS=false -fomit-frame-pointer -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -Wno-error -MT ldcrc64.o -MD -MP -MF .deps/ldcrc64.Tpo -c -o ldcrc64.o ../../ld/ldcrc64.c [ 173s] ../../ld/ldcrc64.c:109:1: error: conflicting types for 'init_crc64_tab'; have 'uint64_t *(algorithm_desc_t *)' {aka 'long long unsigned int *(algorithm_desc_t *)'} [ 173s] 109 | init_crc64_tab (algorithm_desc_t * dsc) [ 173s] | ^~~~~~~~~~~~~~ [ 173s] In file included from ../../ld/ldcrc64.c:33: [ 173s] ../../ld/lddigest.h:166:17: note: previous declaration of 'init_crc64_tab' with type 'bfd_vma *(algorithm_desc_t *)' {aka 'long unsigned int *(algorithm_desc_t *)'} [ 173s] 166 | extern bfd_vma *init_crc64_tab (algorithm_desc_t * dsc); [ 173s] | ^~~~~~~~~~~~~~ [ 173s] ../../ld/ldcrc64.c:140:10: error: conflicting types for 'calc_crc64'; have 'uint64_t(algorithm_desc_t *, const unsigned char *, size_t)' {aka 'long long unsigned int(algorithm_desc_t *, const unsigned char *, unsigned int)'} [ 173s] 140 | uint64_t calc_crc64 [ 173s] | ^~~~~~~~~~ [ 173s] ../../ld/lddigest.h:167:16: note: previous declaration of 'calc_crc64' with type 'bfd_vma(algorithm_desc_t *, const unsigned char *, size_t)' {aka 'long unsigned int(algorithm_desc_t *, const unsigned char *, unsigned int)'} [ 173s] 167 | extern bfd_vma calc_crc64 [ 173s] | ^~~~~~~~~~ [ 173s] make[4]: *** [Makefile:1604: ldcrc64.o] Error 1 [ 173s] make[4]: Leaving directory '/home/abuild/rpmbuild/BUILD/binutils-2.40.50/build-dir/ld' that happens on i586-linux-gnu host if I configure with --target=avr Can you please take a look? Thanks, Martin