From: Matthew Malcomson <Matthew.Malcomson@arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>,
"nickc@redhat.com" <nickc@redhat.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>, nd <nd@arm.com>
Subject: Re: [Patch 00/16] [gas][aarch64] SVE2 binutils instructions for aarch64
Date: Thu, 09 May 2019 14:04:00 -0000 [thread overview]
Message-ID: <9e0b0076-2dc2-6e0d-1665-d04915af82d7@arm.com> (raw)
In-Reply-To: <CAKdteObEBKbvyDwSGFu5vJh3k3-RYvy_EQV4xaEdBWoFppftmA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]
On 09/05/19 14:30, Christophe Lyon wrote:
> On Wed, 8 May 2019 at 12:08, Nick Clifton <nickc@redhat.com> wrote:
>>
>> Hi Matthew,
>>
>>> Attached is a tar file of the patch series from "git format-patch" and a
>>> zipped diff from the entire series.
>>
>> Thanks - that was exactly what I needed.
>>
>> Patch series approved - please apply.
>>
>
> Hi Matthew,
>
> After your commit, I noticed a new failure on aarch64_be:
> gas/aarch64/sve2
>
> Christophe
>
>> Cheers
>> Nick
>>
Thanks Christophe -- I'd left some of the output from objdump in that
test so I was accidentally requiring little-endian.
Fixed as obvious with the below change (entire patch attached for
reference).
diff --git a/gas/testsuite/gas/aarch64/sve2.d
b/gas/testsuite/gas/aarch64/sve2.d
index d7c56c0..efa9b27 100644
--- a/gas/testsuite/gas/aarch64/sve2.d
+++ b/gas/testsuite/gas/aarch64/sve2.d
@@ -1,7 +1,7 @@
#as: -march=armv8-a+sve2+sve2-aes+sve2-sm4+sve2-sha3+bitperm
#objdump: -dr
-[^:]+: file format elf64-littleaarch64
+[^:]+: file format .*
Disassembly of section \.text:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: remove-file-format-restriction.patch --]
[-- Type: text/x-patch; name="remove-file-format-restriction.patch", Size: 1646 bytes --]
commit 8de09632ff6683a48b8acfb05d3b35b4ab4507fe
Author: Matthew Malcomson <matthew.malcomson@arm.com>
Date: Thu May 9 14:52:45 2019 +0100
[gas][testsuite] Don't specify arch in testsuite output
My testcase matched against a file format of elf64-littleaarch64 in the
objdump output. This was unnecessarily restrictive and causes testcase
failures on aarch64_be.
Here we remove that restriction.
Committed as obvious.
Testing done on aarch64_be-none-elf gas to see the failure goes away.
gas/ChangeLog:
2019-05-09 Matthew Malcomson <matthew.malcomson@arm.com>
* testsuite/gas/aarch64/sve2.d: Remove file format restriction.
diff --git a/gas/ChangeLog b/gas/ChangeLog
index fa81e97..5307d23 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,9 @@
2019-05-09 Matthew Malcomson <matthew.malcomson@arm.com>
+ * testsuite/gas/aarch64/sve2.d: Remove file format restriction.
+
+2019-05-09 Matthew Malcomson <matthew.malcomson@arm.com>
+
* testsuite/gas/aarch64/illegal-sve2-aes.d: New test.
* testsuite/gas/aarch64/illegal-sve2-bitperm.d: New test.
* testsuite/gas/aarch64/illegal-sve2-sha3.d: Test new instructions.
diff --git a/gas/testsuite/gas/aarch64/sve2.d b/gas/testsuite/gas/aarch64/sve2.d
index d7c56c0..efa9b27 100644
--- a/gas/testsuite/gas/aarch64/sve2.d
+++ b/gas/testsuite/gas/aarch64/sve2.d
@@ -1,7 +1,7 @@
#as: -march=armv8-a+sve2+sve2-aes+sve2-sm4+sve2-sha3+bitperm
#objdump: -dr
-[^:]+: file format elf64-littleaarch64
+[^:]+: file format .*
Disassembly of section \.text:
prev parent reply other threads:[~2019-05-09 14:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 14:44 Matthew Malcomson
2019-05-01 14:44 ` [PATCH 01/16] [binutils][aarch64] SVE2 feature extension flags Matthew Malcomson
2019-05-01 14:44 ` [PATCH 08/16] [binutils][aarch64] New sve_size_bh iclass Matthew Malcomson
2019-05-01 14:44 ` [PATCH 05/16] [binutils][aarch64] New SVE_Zm3_11_INDEX operand Matthew Malcomson
2019-05-01 14:44 ` [PATCH 03/16] [binutils][aarch64] Introduce SVE_IMM_ROT3 operand Matthew Malcomson
2019-05-01 14:44 ` [PATCH 02/16] [binutils][aarch64] Allow movprfx for SVE2 instructions Matthew Malcomson
2019-05-01 14:44 ` [PATCH 04/16] [binutils][aarch64] New iclass sve_size_hsd2 Matthew Malcomson
2019-05-01 14:44 ` [PATCH 09/16] [binutils][aarch64] New sve_size_013 iclass Matthew Malcomson
2019-05-01 14:44 ` [PATCH 07/16] [binutils][aarch64] New sve_size_sd2 iclass Matthew Malcomson
2019-05-01 14:45 ` [PATCH 06/16] [binutils][aarch64] New SVE_ADDR_ZX operand Matthew Malcomson
2019-05-01 14:45 ` [PATCH 14/16] [binutils][aarch64] New SVE_SHLIMM_UNPRED_22 operand Matthew Malcomson
2019-05-01 14:45 ` [PATCH 12/16] [binutils][aarch64] New SVE_Zm4_11_INDEX operand Matthew Malcomson
2019-05-01 14:45 ` [PATCH 13/16] [binutils][aarch64] New sve_size_tsz_bhs iclass Matthew Malcomson
2019-05-01 14:45 ` [PATCH 11/16] [binutils][aarch64] New sve_shift_tsz_bhsd iclass Matthew Malcomson
2019-05-01 14:45 ` [PATCH 10/16] [binutils][aarch64] New SVE_SHRIMM_UNPRED_22 operand Matthew Malcomson
2019-05-01 14:55 ` [Patch 15/16] [binutils][aarch64] Add SVE2 instructions Matthew Malcomson
2019-05-01 15:02 ` [Patch 16/16] [binutils][aarch64] Add SVE2 tests Matthew Malcomson
2019-05-02 15:25 ` [Patch 00/16] [gas][aarch64] SVE2 binutils instructions for aarch64 Joseph Myers
2019-05-02 15:34 ` Matthew Malcomson
2019-05-03 11:21 ` Nick Clifton
2019-05-03 14:56 ` Matthew Malcomson
2019-05-08 10:08 ` Nick Clifton
2019-05-09 13:30 ` Christophe Lyon
2019-05-09 14:04 ` Matthew Malcomson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e0b0076-2dc2-6e0d-1665-d04915af82d7@arm.com \
--to=matthew.malcomson@arm.com \
--cc=binutils@sourceware.org \
--cc=christophe.lyon@linaro.org \
--cc=nd@arm.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).