From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 067FA3858D39 for ; Wed, 2 Nov 2022 12:21:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 067FA3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667391686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IOrshN6RwQw1Sd7DV7Xfp7ZI5w23gDeAeK2pcacr2Rk=; b=IEphJrkFGnhmLicdQ0F/tnF68tNVvTKKg+yvogOVqRDKfL9aEyRLUS/qWkQT+xZQpo0QMd qzUTBcwr1/zyPIq7mVbib0VsGCcxZaJEIoyTe/2WbzLSmU4b58VhQ4ymAVGtCqjVwSTFkJ m90/yI9sOaBgRWecrN/t4rkpJfiCi5w= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-322-iFI3nNvgN9CGZXvpWL37gw-1; Wed, 02 Nov 2022 08:21:25 -0400 X-MC-Unique: iFI3nNvgN9CGZXvpWL37gw-1 Received: by mail-qk1-f197.google.com with SMTP id az31-20020a05620a171f00b006fa2cc1b0bfso8033217qkb.23 for ; Wed, 02 Nov 2022 05:21:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IOrshN6RwQw1Sd7DV7Xfp7ZI5w23gDeAeK2pcacr2Rk=; b=xRrqL/zBtL3drg8wv9IMRRnXiorfzSF015ySnq4jhrhILCj5QdFHKFIvOy8Vc6Yib4 1Gyh0Do2diZYxd4EgqgWyXOk4zuNOxob2DjsI8LkVF47Nm9FCtJQnN9gxu/MOxEmf4QV JjrAuaRkoZj1BXgd91V2DRQpOfK0bbraD55GLScML1PdLYzev7kmtCZLvkQdXM80Hgzy A0PIw1rqGeG1YnknaAheVrvS4RNb8bMKz8Od0DeUTtVOTXB34t8B4eHeps0W0lFiRTq/ bo95ToNEA2s2rlXLzxtOuAxMvlLD2jGnFeIXy97E1NRO9fn7N3S87b4FkYDrHG+DTc43 zFuQ== X-Gm-Message-State: ACrzQf1W0KVayGd0JlhxAzd54VL/PG3hs70oGQjNr28VGWw8/SSySG00 otrpzrtJio00BxqxGH4z6iEnVbh7ZMT6wH05WDMFNDYsCcSZs3Ns4//QhMNzRcYirZCl6RUZiIQ mLHO7NY7rk2QRUcYD9g== X-Received: by 2002:a05:620a:13ee:b0:6fa:1ef7:a3b7 with SMTP id h14-20020a05620a13ee00b006fa1ef7a3b7mr14473904qkl.265.1667391685064; Wed, 02 Nov 2022 05:21:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6vf1GfipHn8rq9IjOvMZhL/dTv9Jte0Bynxdk3I0x2JK/dgbwm24c65Hb84MOiomJfOVN3Yg== X-Received: by 2002:a05:620a:13ee:b0:6fa:1ef7:a3b7 with SMTP id h14-20020a05620a13ee00b006fa1ef7a3b7mr14473890qkl.265.1667391684827; Wed, 02 Nov 2022 05:21:24 -0700 (PDT) Received: from [192.168.1.18] (adsl-164-85.freeuk.com. [80.168.164.85]) by smtp.gmail.com with ESMTPSA id f11-20020a05620a280b00b006f8665f483fsm8354408qkp.85.2022.11.02.05.21.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 05:21:24 -0700 (PDT) Message-ID: <9e232c97-b0c7-763e-bcc6-f998716a35fd@redhat.com> Date: Wed, 2 Nov 2022 12:21:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: Jojo R , binutils@sourceware.org References: <20220729074837.82957-1-rjiejie@linux.alibaba.com> <20221102080112.33378-1-rjiejie@linux.alibaba.com> From: Nick Clifton Subject: Re: [PATCH v2] Support multiple .eh_frame sections In-Reply-To: <20221102080112.33378-1-rjiejie@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jojo, > This patch is based on MULTIPLE_FRAME_SECTIONS and EH_FRAME_LINKONCE, > it allows backend to enable this feature and use '--gc-sections' simply. Do you (or your employer) have a copyright assignment on file with the FSF for contributions to the GNU Binutils project ? If not, are you willing to contribute the patch with a DCO attached ? https://developercertificate.org/ > _bfd_elf_default_action_discarded (asection *sec) > { > + const struct elf_backend_data *bed; > + bed = get_elf_backend_data (sec->owner); > + > + if (bed->elf_backend_can_make_multiple_eh_frame > + && strncmp (sec->name, ".eh_frame.", 10) == 0) > + return 0; > + > if (sec->flags & SEC_DEBUGGING) > return PRETEND; I think that this test would be better if it was moved down a few lines, until it was just after this test: if (strcmp (".eh_frame", sec->name) == 0) return 0; > + exp.X_op = O_symbol; > + exp.X_add_symbol = (symbolS *) local_symbol_make (cseg->name, cseg, 0, frch->frch_root);; > + exp.X_add_number = 0; The arguments to local_symbol_make() are in the wrong order: struct local_symbol *local_symbol_make (const char *, segT, fragS *, valueT); Ie the frag should come before the value. Also there is a double semi-colon at the end of the line. Cheers Nick