From: Nick Clifton <nickc@redhat.com>
To: "Natarajan, Kavitha" <Kavitha.Natarajan@amd.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>
Subject: Re: [PATCH] Binutils support for DWARF-5 DW_OP_addrx
Date: Fri, 29 Apr 2022 15:21:18 +0100 [thread overview]
Message-ID: <9f4f230e-3ded-71f2-1cab-ea5bf3170d0b@redhat.com> (raw)
In-Reply-To: <DM4PR12MB57967946925D3DEC0E9D6437F7FD9@DM4PR12MB5796.namprd12.prod.outlook.com>
Hi Natarajan,
> [Public]
(Thanks for re-posting).
> Please review.
The patch introduced some new failures into the binutils testsuite. For example
the new testprog.s source file fails to assemble on most architectures because it
contains x86_64 instructions...
> @@ -2661,9 +2665,10 @@ read_and_display_attr_value (unsigned long attribute,
>
> uvalue = check_uvalue (block_start, uvalue, end);
>
> - if (do_loc)
> - data = block_start + uvalue;
> - else
> + data = block_start + uvalue;
> +
> + /* DW_OP_addrx has only the index and not address. */
> + if (!do_loc && ((unsigned)(*block_start) != DW_OP_addrx))
This looks wrong to me. Why are you testing the first word of
the block for a DW_OP_addrx op ? At this point the code is just
displaying the contents of the block, not interpreting them. Plus
you do not check to see that there are enough bytes present in the
block to make up a word.
Cheers
Nick
next prev parent reply other threads:[~2022-04-29 14:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 10:14 Natarajan, Kavitha
2022-04-29 14:21 ` Nick Clifton [this message]
2022-05-20 10:38 ` Natarajan, Kavitha
2022-05-25 15:13 ` Nick Clifton
2022-05-25 23:42 ` Alan Modra
2022-05-26 4:35 ` Natarajan, Kavitha
2022-05-26 7:19 ` Luis Machado
2022-05-26 8:04 ` Alan Modra
2022-05-26 8:06 ` Luis Machado
-- strict thread matches above, loose matches on Subject: below --
2022-04-27 10:33 Natarajan, Kavitha
2022-04-28 9:54 ` Nick Clifton
2022-04-28 10:19 ` Natarajan, Kavitha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f4f230e-3ded-71f2-1cab-ea5bf3170d0b@redhat.com \
--to=nickc@redhat.com \
--cc=JiniSusan.George@amd.com \
--cc=Kavitha.Natarajan@amd.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).